From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH edk2-platforms] Platform: remove gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec
Date: Thu, 30 Nov 2017 14:31:46 +0000 [thread overview]
Message-ID: <20171130143146.mlxbdzufjvegadej@bivouac.eciton.net> (raw)
In-Reply-To: <20171130135947.25682-1-ard.biesheuvel@linaro.org>
On Thu, Nov 30, 2017 at 01:59:47PM +0000, Ard Biesheuvel wrote:
> Remove references to the ArmPlatformPkg PCD PcdSystemMemoryInitializeInSec,
> which is only used on PrePeiCore platforms anyway, and which has no effect
> whatsoever given that it decides when ArmPlatformInitializeSystemMemory()
> is called, which is implemented as an empty function by all these platforms
> anyway.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Platform/ARM/JunoPkg/ArmJuno.dsc | 2 --
> Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 1 -
> Platform/Hisilicon/D05/D05.dsc | 1 -
> Platform/Hisilicon/HiKey/HiKey.dsc | 2 --
> 4 files changed, 6 deletions(-)
>
> diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc
> index 115609180263..2844c91813d4 100644
> --- a/Platform/ARM/JunoPkg/ArmJuno.dsc
> +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc
> @@ -78,8 +78,6 @@ [BuildOptions]
> ################################################################################
>
> [PcdsFeatureFlag.common]
> - gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec|TRUE
> -
> ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe.
> # It could be set FALSE to save size.
> gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
> diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc
> index b2eb4b14da0b..98513b282fa7 100644
> --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc
> +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc
> @@ -86,7 +86,6 @@ [BuildOptions]
>
> [PcdsFeatureFlag.common]
> gArmTokenSpaceGuid.PcdNormalMemoryNonshareableOverride|TRUE
> - gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec|TRUE
> gArmPlatformTokenSpaceGuid.PcdSendSgiToBringUpSecondaryCores|TRUE
>
> ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe.
> diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc
> index 00cf0f20d23f..1daac38e1152 100644
> --- a/Platform/Hisilicon/D05/D05.dsc
> +++ b/Platform/Hisilicon/D05/D05.dsc
> @@ -113,7 +113,6 @@ [BuildOptions]
> [PcdsFeatureFlag.common]
>
> !if $(EDK2_SKIP_PEICORE) == 1
> - gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec|TRUE
> gArmPlatformTokenSpaceGuid.PcdSendSgiToBringUpSecondaryCores|TRUE
> !endif
>
> diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc
> index 957e4d4a9e4c..8322ab53c020 100644
> --- a/Platform/Hisilicon/HiKey/HiKey.dsc
> +++ b/Platform/Hisilicon/HiKey/HiKey.dsc
> @@ -192,8 +192,6 @@ [PcdsFeatureFlag.common]
>
> gEmbeddedTokenSpaceGuid.PcdPrePiProduceMemoryTypeInformationHob|TRUE
>
> - gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec|TRUE
> -
> ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe.
> # It could be set FALSE to save size.
> gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|FALSE
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-11-30 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 13:59 [PATCH edk2-platforms] Platform: remove gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec Ard Biesheuvel
2017-11-30 14:31 ` Leif Lindholm [this message]
2017-11-30 14:35 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130143146.mlxbdzufjvegadej@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox