From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::241; helo=mail-wm0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0D025220C1C3A for ; Thu, 30 Nov 2017 06:27:25 -0800 (PST) Received: by mail-wm0-x241.google.com with SMTP id g130so1816916wme.0 for ; Thu, 30 Nov 2017 06:31:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zH2jNePSlmAgewkIWnrV9B87P8CG62zBxAjoEwYCkt0=; b=eo7rgXtmR6W98jtao0udp2mmnUHgePUmk3es+YlkHBErnh0Ge9ZlKuqVKiuSpA3tXD K2PrGzolAzC1BORyxugvLxTS2reuraVqmkLCT5Ixr6caATn7yJTH3Dr/X6FgeSBXFREV PJxHwBAH7xJLP9G0oNdP3O/XJqfL/HB+qGVww= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zH2jNePSlmAgewkIWnrV9B87P8CG62zBxAjoEwYCkt0=; b=F1HdmYPmPsm28jA9d5/kC1dGdpMeeBOgcArjQVdemY5uLgdno4oFkqofjDKe7NDlQ6 eIAnojs4QM4blR+vmSKQdv+tfWVRunKM5SlwuZVrL67ceiogC/p1vA7WfcTB6D3mJctx T6GGkkd+BianHgIWjLdj6tuui7o9DbRKVKxXEgji2oqJJ9KEZiWPEJRvI+f2oCMx4UKI ZdNbQJYz07UNUIkKlKGuvnfRfkHBM1ayTIQ0wfjy/A0LW98C78sAlnN6MXot4JSqXp56 QYRhvoM8g206qsEErFRxVkED5oqvmq5Fijfsa00ve/HzLT+luyDJV9mZm/ZI3Yj0b5he wtvg== X-Gm-Message-State: AJaThX6P+T4lAmfyX8NiiHIzlWXYlxKA8vZ74ndwpvIzRiTuYKhAqjGC uyYyjGcHe4E58s1mbiw4PXTibJqgjrk= X-Google-Smtp-Source: AGs4zMZIrpC00lop5IIwDtWOeXsDYy5YJgO8A+eOndvZBOFK6RqqYbChNWxo2DBDPuH08h/OX2Yt3A== X-Received: by 10.28.71.76 with SMTP id u73mr709855wma.77.1512052309999; Thu, 30 Nov 2017 06:31:49 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f56sm7353455wra.75.2017.11.30.06.31.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Nov 2017 06:31:48 -0800 (PST) Date: Thu, 30 Nov 2017 14:31:46 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20171130143146.mlxbdzufjvegadej@bivouac.eciton.net> References: <20171130135947.25682-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171130135947.25682-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms] Platform: remove gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 14:27:26 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 30, 2017 at 01:59:47PM +0000, Ard Biesheuvel wrote: > Remove references to the ArmPlatformPkg PCD PcdSystemMemoryInitializeInSec, > which is only used on PrePeiCore platforms anyway, and which has no effect > whatsoever given that it decides when ArmPlatformInitializeSystemMemory() > is called, which is implemented as an empty function by all these platforms > anyway. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > Platform/ARM/JunoPkg/ArmJuno.dsc | 2 -- > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 1 - > Platform/Hisilicon/D05/D05.dsc | 1 - > Platform/Hisilicon/HiKey/HiKey.dsc | 2 -- > 4 files changed, 6 deletions(-) > > diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc > index 115609180263..2844c91813d4 100644 > --- a/Platform/ARM/JunoPkg/ArmJuno.dsc > +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc > @@ -78,8 +78,6 @@ [BuildOptions] > ################################################################################ > > [PcdsFeatureFlag.common] > - gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec|TRUE > - > ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe. > # It could be set FALSE to save size. > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > index b2eb4b14da0b..98513b282fa7 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > @@ -86,7 +86,6 @@ [BuildOptions] > > [PcdsFeatureFlag.common] > gArmTokenSpaceGuid.PcdNormalMemoryNonshareableOverride|TRUE > - gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec|TRUE > gArmPlatformTokenSpaceGuid.PcdSendSgiToBringUpSecondaryCores|TRUE > > ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe. > diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > index 00cf0f20d23f..1daac38e1152 100644 > --- a/Platform/Hisilicon/D05/D05.dsc > +++ b/Platform/Hisilicon/D05/D05.dsc > @@ -113,7 +113,6 @@ [BuildOptions] > [PcdsFeatureFlag.common] > > !if $(EDK2_SKIP_PEICORE) == 1 > - gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec|TRUE > gArmPlatformTokenSpaceGuid.PcdSendSgiToBringUpSecondaryCores|TRUE > !endif > > diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc > index 957e4d4a9e4c..8322ab53c020 100644 > --- a/Platform/Hisilicon/HiKey/HiKey.dsc > +++ b/Platform/Hisilicon/HiKey/HiKey.dsc > @@ -192,8 +192,6 @@ [PcdsFeatureFlag.common] > > gEmbeddedTokenSpaceGuid.PcdPrePiProduceMemoryTypeInformationHob|TRUE > > - gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec|TRUE > - > ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe. > # It could be set FALSE to save size. > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|FALSE > -- > 2.11.0 >