Re: [platforms: PATCH v3 0/4] Armada 7k/8k variable support

[Leif Lindholm <leif.lindholm@linaro.org>]

On Tue, Nov 28, 2017 at 09:19:09AM +0100, Marcin Wojtas wrote:
> Hi,
> 
> I submit v3 of the Armada variable support with the MvFvbDxe
> driver improved according to the recent review. The biggest
> changes are a proper implementation of Set/GetAttributes
> protocol callbacks. Details can be found in the changelog below.
> 
> Patches are available in the github:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/var-upstream-r20171128
> 
> I'm looking forward to the comments or remarks.
> 
> Best regards,
> Marcin

This looks a lot better, thanks.

For the series: Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 4fe276ea64..93f1d9689a.

> Changelog:
> v2 -> v3
> * 2/4 - 4/4
>     - Add RBs
> 
> * 1/4
>     - Fix line-breaking in MvFvbValidateFvHeader
>     - Check actual WriteDisabled attributes MvFvbEraseBlocks
>     - Rework MvFvbGetAttributes/MvFvbSetAttributes to properly
>       support those features
> 
> v1 -> v2:
> * Change patches order in order to safely apply related Depex modifications
> 
> * 1/4:
>   - Fix style (line breaking, openining brackets, alignment, typos)
>   - Rework MvFvbSetAttributes - because it can return only EFI_SUCCESS /
>     EFI_INVALID_PARAMETER and should return FVB attributes,
>     add debug information, that operation is not supported and return
>     default values via MvFvbGetAttributes.
>   - Return EFI_SUCCESS, in case NumBytes == 0 in MvFvbRead.
> 
> * 2/4:
>   - Move Depex configuration from 4/4
> 
> * 3/4:
>   - Move Depex configuration from 4/4
>   - Reword and break commit message.
> 
> * 4/4:
>   - Remove Depex configuration
> 
> 
> Marcin Wojtas (4):
>   Platform/Marvell: Introduce MvFvbDxe variable support driver
>   Marvell/Drivers: MvSpiFlash: Enable using driver in RT
>   Marvell/Drivers: MvSpiDxe: Enable using driver in RT
>   Marvell/Armada: Enable variables support
> 
>  Platform/Marvell/Armada/Armada.dsc.inc              |   25 +-
>  Platform/Marvell/Armada/Armada70x0.fdf              |    6 +-
>  Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.c   |   58 +-
>  Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.h   |    1 +
>  Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.inf |   11 +-
>  Platform/Marvell/Drivers/Spi/MvSpiDxe.c             |   50 +-
>  Platform/Marvell/Drivers/Spi/MvSpiDxe.h             |    2 +
>  Platform/Marvell/Drivers/Spi/MvSpiDxe.inf           |    9 +-
>  Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.c   | 1138 ++++++++++++++++++++
>  Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.h   |  128 +++
>  Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.inf |   91 ++
>  Platform/Marvell/Include/Protocol/Spi.h             |    7 +
>  Platform/Marvell/Marvell.dec                        |    4 +
>  13 files changed, 1516 insertions(+), 14 deletions(-)
>  create mode 100644 Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.c
>  create mode 100644 Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.h
>  create mode 100644 Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.inf
> 
> -- 
> 2.7.4
>