From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::244; helo=mail-wr0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2107F220C1C3A for ; Thu, 30 Nov 2017 07:46:52 -0800 (PST) Received: by mail-wr0-x244.google.com with SMTP id g53so7094835wra.2 for ; Thu, 30 Nov 2017 07:51:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HdeIcCRJTPKE5BRImJ1h8BT40juE4hrAf143jSYRUBU=; b=XPHwPo+ktrfmwJWnGlxFyEWS+Jck/GmtAlIPINBT966C2VSPO1raW9ttSegvljZIlI N0ZiIB98Xp3MlnSd4918HtqMg1twX2KXCBwLVTF5SNXyRACOvPC+FG/gPVI9F506dQbN KK5c/RREcV6C5dsFmqPe02lpCJxQPnLcFz7QY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HdeIcCRJTPKE5BRImJ1h8BT40juE4hrAf143jSYRUBU=; b=NluBAAFItl41vIGQ5RkdNj9bTyq56qrhdkPtSsR2pWVuJ2DCh0PGtFQmqNj1nnur+4 GdEh+dbh7j5VOZYo0Uf8u1jZ/YGId4w6U1J8wJezwGyIRBFVP21bMkMrMKW97moHd5Is poazpiHPel0n0Knepywt5/5uCmote1AEv0dNh/H8pbTGXf2LUsCalaIzagNbzl47L/nL /igEo8yQx6MMCH1M6xyU9mG29mAyMKxRxQzEyi/BfbXbQ++/wcBCtiAZpXALdkjupuZw 6FOFKf/fe7UPWp1kdyJthQjHJYhuCmQ+bjmQjN/UtVYEeRpBiBbk5rV5tb2zlD9zWC8b kRNw== X-Gm-Message-State: AJaThX5ICVxExRkzb9EvdME4VEPo65rQ7YLPHCheY+YFPYGwQaNLGsrO STVEE8872IfZ+lxM1O1GR6mnhg== X-Google-Smtp-Source: AGs4zMYZBgIjSc8ab83LRiut8eNmBhZNwxpAX0iogU3V5LylmDFm4GOLm7t+rljJ/hkBp1r+rf0XPw== X-Received: by 10.223.182.81 with SMTP id i17mr2387138wre.224.1512057077015; Thu, 30 Nov 2017 07:51:17 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id r3sm4085901wmg.31.2017.11.30.07.51.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Nov 2017 07:51:16 -0800 (PST) Date: Thu, 30 Nov 2017 15:51:14 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, jsd@semihalf.com Message-ID: <20171130155114.pjzemqpsbtem6oz5@bivouac.eciton.net> References: <1511857153-9266-1-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1511857153-9266-1-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v3 0/4] Armada 7k/8k variable support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 15:46:53 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 28, 2017 at 09:19:09AM +0100, Marcin Wojtas wrote: > Hi, > > I submit v3 of the Armada variable support with the MvFvbDxe > driver improved according to the recent review. The biggest > changes are a proper implementation of Set/GetAttributes > protocol callbacks. Details can be found in the changelog below. > > Patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/var-upstream-r20171128 > > I'm looking forward to the comments or remarks. > > Best regards, > Marcin This looks a lot better, thanks. For the series: Reviewed-by: Leif Lindholm Pushed as 4fe276ea64..93f1d9689a. > Changelog: > v2 -> v3 > * 2/4 - 4/4 > - Add RBs > > * 1/4 > - Fix line-breaking in MvFvbValidateFvHeader > - Check actual WriteDisabled attributes MvFvbEraseBlocks > - Rework MvFvbGetAttributes/MvFvbSetAttributes to properly > support those features > > v1 -> v2: > * Change patches order in order to safely apply related Depex modifications > > * 1/4: > - Fix style (line breaking, openining brackets, alignment, typos) > - Rework MvFvbSetAttributes - because it can return only EFI_SUCCESS / > EFI_INVALID_PARAMETER and should return FVB attributes, > add debug information, that operation is not supported and return > default values via MvFvbGetAttributes. > - Return EFI_SUCCESS, in case NumBytes == 0 in MvFvbRead. > > * 2/4: > - Move Depex configuration from 4/4 > > * 3/4: > - Move Depex configuration from 4/4 > - Reword and break commit message. > > * 4/4: > - Remove Depex configuration > > > Marcin Wojtas (4): > Platform/Marvell: Introduce MvFvbDxe variable support driver > Marvell/Drivers: MvSpiFlash: Enable using driver in RT > Marvell/Drivers: MvSpiDxe: Enable using driver in RT > Marvell/Armada: Enable variables support > > Platform/Marvell/Armada/Armada.dsc.inc | 25 +- > Platform/Marvell/Armada/Armada70x0.fdf | 6 +- > Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.c | 58 +- > Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.h | 1 + > Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.inf | 11 +- > Platform/Marvell/Drivers/Spi/MvSpiDxe.c | 50 +- > Platform/Marvell/Drivers/Spi/MvSpiDxe.h | 2 + > Platform/Marvell/Drivers/Spi/MvSpiDxe.inf | 9 +- > Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.c | 1138 ++++++++++++++++++++ > Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.h | 128 +++ > Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.inf | 91 ++ > Platform/Marvell/Include/Protocol/Spi.h | 7 + > Platform/Marvell/Marvell.dec | 4 + > 13 files changed, 1516 insertions(+), 14 deletions(-) > create mode 100644 Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.c > create mode 100644 Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.h > create mode 100644 Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.inf > > -- > 2.7.4 >