From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::243; helo=mail-wr0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4EE02221786A2 for ; Thu, 30 Nov 2017 08:29:47 -0800 (PST) Received: by mail-wr0-x243.google.com with SMTP id v105so7198193wrc.3 for ; Thu, 30 Nov 2017 08:34:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tJeUC3LgfeDp5K4j7rqd8jfDtZDqPf7aryMSIBlJf6A=; b=FUNgM5IXivBJy55vje87jIo48RYeuh5HMntqg7eTcSbSwYBLRsK6Y+QENQIM1SlS90 Q/3sXA5cWCEJ4vt/Oxkcfd3fIL1KC1zsXROvxLLwV9FWpYRfQhpGbNw8O8ZAqs9xNhxi vmVGie9774UAaDhF7mu2lNIU6XiWTuw7ICYHA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tJeUC3LgfeDp5K4j7rqd8jfDtZDqPf7aryMSIBlJf6A=; b=Ot+9CzjyZilJLWtNMqC0tDKrQitDZhXlSZDHU9zuZGRew8PyJTIDbMWX/QxUHTHotg c3YjrKnIaJVw6iEqUsUC3/OYH6ivmIHeMREGugqYWYL40ONlykd3ClIo0vUFWw0nw4mi yGih8vYCEEgq2adRv+Y7hEwfXy7Z42uG5XEqlSbRSnhjisqyRflmgnvv6RI30wA3rhAc cCpOQ3KdnHH8vp6K/v9oI9/sFa9BSYagc6uep9XDdaoq7szlGEBsovi9SwXQIhaaqfV3 zjART9GmLOYXnvWCRUTn1ho9aKOc5MlsUv03qfmDAyR2WMcbXu3ilbt7MG2hyslvy3RY ooGg== X-Gm-Message-State: AJaThX7hK3ttmXaDog/QhnZGzgcbARGOkGg/Mn3gVK++YPgJnz5KnSel 5ksnhtp8qFb5M/JAF83sbaDMSz3KysQ= X-Google-Smtp-Source: AGs4zMb8b4PtY6tLlrAu64N+pNBSiNUxeZfuGC/t1Nyhx80EnazAkTPteD5Vd7WWcS8NjktSOU4AYQ== X-Received: by 10.223.134.76 with SMTP id 12mr2665053wrw.137.1512059651330; Thu, 30 Nov 2017 08:34:11 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id x52sm4444117wrb.25.2017.11.30.08.34.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Nov 2017 08:34:10 -0800 (PST) Date: Thu, 30 Nov 2017 16:34:08 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20171130163408.h2t7mnnmou3om6an@bivouac.eciton.net> References: <20171130161306.1454-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171130161306.1454-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms] Platform Silicon: remove ArmPlatformInitializeSystemMemory () functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 16:29:47 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 30, 2017 at 04:13:06PM +0000, Ard Biesheuvel wrote: > The function ArmPlatformInitializeSystemMemory () has been removed from > ArmPlatformLib, so remove all the [empty] implementations provided by > the various platforms. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c | 13 ------------- > Platform/Hisilicon/HiKey/Library/HiKeyLib/HiKey.c | 13 ------------- > Platform/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c | 14 -------------- > Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c | 15 --------------- > Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c | 14 -------------- > Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c | 13 ------------- > 6 files changed, 82 deletions(-) > > diff --git a/Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c b/Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c > index 5ec72ff7ed8b..cbc5ed595571 100644 > --- a/Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c > +++ b/Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c > @@ -146,19 +146,6 @@ ArmPlatformInitialize ( > return Status; > } > > -/** > - Initialize the system (or sometimes called permanent) memory > - > - This memory is generally represented by the DRAM. > - > -**/ > -VOID > -ArmPlatformInitializeSystemMemory ( > - VOID > - ) > -{ > -} > - > EFI_STATUS > PrePeiCoreGetMpCoreInfo ( > OUT UINTN *CoreCount, > diff --git a/Platform/Hisilicon/HiKey/Library/HiKeyLib/HiKey.c b/Platform/Hisilicon/HiKey/Library/HiKeyLib/HiKey.c > index f4a47b28493a..6bf0d39bd4e2 100644 > --- a/Platform/Hisilicon/HiKey/Library/HiKeyLib/HiKey.c > +++ b/Platform/Hisilicon/HiKey/Library/HiKeyLib/HiKey.c > @@ -111,19 +111,6 @@ ArmPlatformInitialize ( > return RETURN_SUCCESS; > } > > -/** > - Initialize the system (or sometimes called permanent) memory > - > - This memory is generally represented by the DRAM. > - > -**/ > -VOID > -ArmPlatformInitializeSystemMemory ( > - VOID > - ) > -{ > -} > - > EFI_STATUS > PrePeiCoreGetMpCoreInfo ( > OUT UINTN *CoreCount, > diff --git a/Platform/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c b/Platform/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c > index 968d28f813f6..b2b415571c74 100644 > --- a/Platform/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c > +++ b/Platform/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c > @@ -89,20 +89,6 @@ ArmPlatformInitialize ( > return RETURN_SUCCESS; > } > > -/** > - Initialize the system (or sometimes called permanent) memory > - > - This memory is generally represented by the DRAM. > - > -**/ > -VOID > -ArmPlatformInitializeSystemMemory ( > - VOID > - ) > -{ > - //TODO: Initialize DRAM controller here > -} > - > EFI_STATUS > PrePeiCoreGetMpCoreInfo ( > OUT UINTN *CoreCount, > diff --git a/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c b/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c > index facfd61ca230..dc59d4f08f5a 100644 > --- a/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c > +++ b/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c > @@ -84,21 +84,6 @@ ArmPlatformInitialize ( > } > > > -/** > - Initialize the system (or sometimes called permanent) memory > - > - This memory is generally represented by the DRAM. > - > -**/ > -VOID > -ArmPlatformInitializeSystemMemory ( > - VOID > - ) > -{ > - // Nothing to do here > -} > - > - > // > // Return list of cores in the system > // > diff --git a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c > index b59b9f027573..4962543f5531 100644 > --- a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c > +++ b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c > @@ -56,20 +56,6 @@ ArmPlatformInitialize ( > return RETURN_SUCCESS; > } > > -/** > - Initialize the system (or sometimes called permanent) memory > - > - This memory is generally represented by the DRAM. > - > -**/ > -VOID > -ArmPlatformInitializeSystemMemory ( > - VOID > - ) > -{ > - // Nothing to do here > -} > - > EFI_STATUS > PrePeiCoreGetMpCoreInfo ( > OUT UINTN *CoreCount, > diff --git a/Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c b/Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c > index 4da0200279cd..6d4be4badb80 100644 > --- a/Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c > +++ b/Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c > @@ -76,19 +76,6 @@ ArmPlatformInitialize ( > return RETURN_SUCCESS; > } > > -/** > - Initialize the system (or sometimes called permanent) memory > - > - This memory is generally represented by the DRAM. > - > -**/ > -VOID > -ArmPlatformInitializeSystemMemory ( > - VOID > - ) > -{ > -} > - > STATIC > EFI_STATUS > PrePeiCoreGetMpCoreInfo ( > -- > 2.11.0 >