From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::241; helo=mail-wm0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8165B221786A0 for ; Thu, 30 Nov 2017 08:41:11 -0800 (PST) Received: by mail-wm0-x241.google.com with SMTP id 64so13546927wme.3 for ; Thu, 30 Nov 2017 08:45:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+7dcRZwgee8up3OrH4REFkHiha7ra2VHrWB2sojSypc=; b=FRXwgw2nbCDE+tlr0cJWHakZ7ClxRk0hV9qN/qky09KAK5a1FIAb/8Pe3wg30RGJpl WDVHQtjaXd/w4EAzi755un7WiIFSCcS0tTyFD955bxkCJJO6rWv8o6PvZ5hplRTIkYna 0dL+b0n+wFrDLgh/ryoFIuRseTgeXnTGh3WA8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+7dcRZwgee8up3OrH4REFkHiha7ra2VHrWB2sojSypc=; b=qnnrCYeW09XWA4bzf7SWmzIJ5m9Zk8ssbLFG8clcvDdZT3+XgM14EvWShOlhJ/4ZZE gW/AT3IDuFLIUDUsRlyuX9NQcLEEe4HeJyuUVeiypX+3DxDKZfscAP1e6gctQZPxDz6h nWtofPck+9zBjai/cPlMsSQY/HOs8ShaQ1GM4oELj1ZzHcxQL8kid1C76OvwFFcomv8T H2pgurVLD82SVoiCdR8wNsvdxGaAyRMwlP6CRdQ1iB80gr/ANjtR8/wjjLe/yd8PBvpH ws82/bdFECOURW4guK9q7Z2ax5Gdo9Ve/+wA7Ipt/S+E8N+00Oq5O6JFb+oMcO6yazgS YSuQ== X-Gm-Message-State: AJaThX58mO+UzBJCw+Wix2mwYWymFI9zt0nddLc/191lV99opnE0ueg2 hQZ28S4lDmKUc/hitCxgg52DGg== X-Google-Smtp-Source: AGs4zMZFVEFvJ6Br9tIUa8r3csfRpC2UUEqkyfLbym40rqTNEpd+7ITJ5Q7wPQleCQ8MWrewtCK04A== X-Received: by 10.28.62.5 with SMTP id l5mr1068422wma.47.1512060335462; Thu, 30 Nov 2017 08:45:35 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o80sm4413800wmg.6.2017.11.30.08.45.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Nov 2017 08:45:34 -0800 (PST) Date: Thu, 30 Nov 2017 16:45:32 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" Message-ID: <20171130164532.6s4uqm62w43rqrni@bivouac.eciton.net> References: <20171130152453.19205-1-ard.biesheuvel@linaro.org> <20171130152453.19205-7-ard.biesheuvel@linaro.org> <20171130163129.ddh7xtg5co2d3bbd@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 6/7] ArmPlatformPkg/PrePi; call all constructors by hand X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 16:41:11 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 30, 2017 at 04:35:41PM +0000, Ard Biesheuvel wrote: > On 30 November 2017 at 16:31, Leif Lindholm wrote: > > On Thu, Nov 30, 2017 at 03:24:52PM +0000, Ard Biesheuvel wrote: > >> Call ProcessLibraryConstructorList () to invoke all library constructors > >> by hand rather than calling only some of them explicitly. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Ard Biesheuvel > >> --- > >> ArmPlatformPkg/PrePi/PrePi.c | 13 +++---------- > >> 1 file changed, 3 insertions(+), 10 deletions(-) > >> > >> diff --git a/ArmPlatformPkg/PrePi/PrePi.c b/ArmPlatformPkg/PrePi/PrePi.c > >> index a60cafdce45e..76a53bc871d2 100644 > >> --- a/ArmPlatformPkg/PrePi/PrePi.c > >> +++ b/ArmPlatformPkg/PrePi/PrePi.c > >> @@ -33,15 +33,9 @@ > >> UINT64 mSystemMemoryEnd = FixedPcdGet64(PcdSystemMemoryBase) + > >> FixedPcdGet64(PcdSystemMemorySize) - 1; > >> > >> -EFI_STATUS > >> -EFIAPI > >> -ExtractGuidedSectionLibConstructor ( > >> - VOID > >> - ); > >> - > >> -EFI_STATUS > >> +VOID > >> EFIAPI > >> -LzmaDecompressLibConstructor ( > >> +ProcessLibraryConstructorList ( > >> VOID > >> ); > > > > Hmm ... > > Do we need this local declaration? > > Is there some header we could use? > > That doesn't appear to be the case, no Seems like a future opportunity. > > If not - could we move it out to PrePi.h? > > Yes, that works for me. OK, if you fold that in, for the series: Reviewed-by: Leif Lindholm > >> @@ -162,8 +156,7 @@ PrePiMain ( > >> PERF_START (NULL, "PEI", NULL, StartTimeStamp); > >> > >> // SEC phase needs to run library constructors by hand. > >> - ExtractGuidedSectionLibConstructor (); > >> - LzmaDecompressLibConstructor (); > >> + ProcessLibraryConstructorList (); > >> > >> // Assume the FV that contains the SEC (our code) also contains a compressed FV. > >> Status = DecompressFirstFv (); > >> -- > >> 2.11.0 > >> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel