From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::241; helo=mail-wm0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 488B521A10968 for ; Fri, 1 Dec 2017 04:59:39 -0800 (PST) Received: by mail-wm0-x241.google.com with SMTP id v19so3248405wmh.5 for ; Fri, 01 Dec 2017 05:04:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MF1zMyWhZ4fNwilfg5Z5wjGdWuC/MiprYJf2SldCwNw=; b=ZTRCaA/ZiREW4F3WWk8CoP2BoONWjfpmXLqt1lwOl1cL8/MYDO1DJDhlsqRQbDa9g7 vkWLYOjXX6ShqXUArcT0PRwBvXAmAylX8JgrnNfgGrgtqo0r8ytLTMyL9Zp3iZdx8Oo1 GHBNqkDi6MZqabd+Ym2oOX61Igz8EVlgDnpuM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MF1zMyWhZ4fNwilfg5Z5wjGdWuC/MiprYJf2SldCwNw=; b=Ozn9+acH2HW3rErBOQlqLSm5VrAb1tBOFEAro5294Q7rwIjw7Aur78dylQqNdAnDH9 6BDBU7PsdSjpsFegn4GpnIJkpOtco2B+SbdaRKyxwghRgR2W6qilaxNSWqS6F7iHZ3Wk Lg5SP4jhipRpgrl4Wk8SjV8/wBpbTaqRUQhN+u5tFsMTij9V1AtswfuDfHDlFt9AfyAF wnkyp+FFTCnfOX/7rURsahj8lKthA5rWqKtB48Faeo5St+yAxPKtLcJ+3pacuZI1ixjI iNaNt+nuewHHE3EzDIy40oV67aZH+4MpmAyHsxYR975KczvBKaqNl4voRUv2aa6kRG1v zepA== X-Gm-Message-State: AJaThX5zBQwMx9Oh4Hja7SCYTcvStppkir1a4Gqvz/3UiAWxyHDS0W9J 5P0jDKUvOkzQy4o5/DnLfY163w== X-Google-Smtp-Source: AGs4zMYRUgcq3gVcvj0DfHbwSccXNzArrW5ZwVvV4TSp9kiMqYhtioyH4qLixrti+4yhmIt7T10J9w== X-Received: by 10.28.71.136 with SMTP id m8mr1251686wmi.89.1512133444863; Fri, 01 Dec 2017 05:04:04 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id r71sm1103394wmd.20.2017.12.01.05.04.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Dec 2017 05:04:03 -0800 (PST) Date: Fri, 1 Dec 2017 13:04:02 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, jsd@semihalf.com Message-ID: <20171201130401.p4kirliksdkr6nra@bivouac.eciton.net> References: <1512095334-20345-1-git-send-email-mw@semihalf.com> <1512095334-20345-2-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1512095334-20345-2-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 1/4] Marvell/Armada: Switch to dynamic tftp command X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 12:59:40 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 01, 2017 at 03:28:51AM +0100, Marcin Wojtas wrote: > After removal of the tftp library in EDK2, the tftp was > disabled on Armada platform. Re-enable this functionality > as a dynamic command. I did request this to be re-added as a build-time selectable option like it is done on the Hisilicon platforms. Including non-standard shell commands by default does not make sense to me. / Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas > --- > Platform/Marvell/Armada/Armada.dsc.inc | 1 + > Platform/Marvell/Armada/Armada70x0.fdf | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Platform/Marvell/Armada/Armada.dsc.inc b/Platform/Marvell/Armada/Armada.dsc.inc > index 2a8a226..1b68ef3 100644 > --- a/Platform/Marvell/Armada/Armada.dsc.inc > +++ b/Platform/Marvell/Armada/Armada.dsc.inc > @@ -524,6 +524,7 @@ > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000 > } > + ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > > [BuildOptions.common.EDKII.DXE_CORE,BuildOptions.common.EDKII.DXE_DRIVER,BuildOptions.common.EDKII.UEFI_DRIVER,BuildOptions.common.EDKII.UEFI_APPLICATION] > GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 > diff --git a/Platform/Marvell/Armada/Armada70x0.fdf b/Platform/Marvell/Armada/Armada70x0.fdf > index ca92c60..65c6474 100644 > --- a/Platform/Marvell/Armada/Armada70x0.fdf > +++ b/Platform/Marvell/Armada/Armada70x0.fdf > @@ -176,6 +176,7 @@ FvNameGuid = 5eda4200-2c5f-43cb-9da3-0baf74b1b30c > > # UEFI application (Shell Embedded Boot Loader) > INF ShellPkg/Application/Shell/Shell.inf > + INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > > # Bds > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > -- > 2.7.4 >