From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::244; helo=mail-wr0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 034D922183C63 for ; Fri, 1 Dec 2017 05:15:30 -0800 (PST) Received: by mail-wr0-x244.google.com with SMTP id o2so10074396wro.5 for ; Fri, 01 Dec 2017 05:19:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=M1oJxH2AMnQYwf0cfOikWFru2VzBg0yGWyMfL5ZcG+o=; b=QJl6KErLyfVHpmabjXPG0wmzH+yGc7oVPFIj4FJP80EROIB3Tvr9ATyvISLCB9dwOb OB5OIdrvg86zHtLY1G7Xich0Nos8rR0bANTwbbZm5sNNNclxK2PLjs/qo6MhExdfDCjz SdAaqooFkG63sVHPOhgZA52opEMs9rlOB7WY0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=M1oJxH2AMnQYwf0cfOikWFru2VzBg0yGWyMfL5ZcG+o=; b=UcdRlygjZdYRpPF0Ryy5Qq3DmYHLV7KDbtg/FqlMGgKfkKXFV/nV+VmsySdFviV4l7 Qbg364UVa+wUoxCcFZnOsNv2zYA9QGT/TpEfm8jQXad4uq0AIHvUgFlsgrw/N9uhqRaL O+Ji/F0hbmaxzyLbJucm95MtQBPt/+yuQ1wAxiROt/500iYkOgbYCVQvJBZFMzaTR6ZX v//0W4Kc1Ziv7vYNoi2F2Fg7KySuPC1y3ic+yfA4U4Vlr35H0roetV83/uWF74q//rfk RGUb1RwZqThWewOZ3NSXPYZV+WlJV5xcDaOqdCU//wVNZaR36rfbhhNH5zcRLFeeKsyM vrnA== X-Gm-Message-State: AJaThX4fuKM0/5lK4czUIdkXm/192h1r8lu6glRrU8ixOJrVnv73DNhN 6lL11bzrGDbSPpn/LglktsNqgA== X-Google-Smtp-Source: AGs4zMawUbqAOcaD2mNMmfoqnAAXH0xRIepsq29q5H+iYAyyTtTJMLMId/ks5ByWJcCtW6kV8EPglQ== X-Received: by 10.223.129.135 with SMTP id 7mr5063953wra.55.1512134395980; Fri, 01 Dec 2017 05:19:55 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j13sm7445289wre.55.2017.12.01.05.19.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Dec 2017 05:19:54 -0800 (PST) Date: Fri, 1 Dec 2017 13:19:52 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, jsd@semihalf.com Message-ID: <20171201131952.4xalq43sehniptdr@bivouac.eciton.net> References: <1512095334-20345-1-git-send-email-mw@semihalf.com> <1512095334-20345-3-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1512095334-20345-3-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 2/4] Marvell/Armada: Fix watchdog control base X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 13:15:31 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 01, 2017 at 03:28:52AM +0100, Marcin Wojtas wrote: > Proper watchdog control base is 0xf0610000, so fix the > incorrect value. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas > --- > Platform/Marvell/Armada/Armada.dsc.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/Marvell/Armada/Armada.dsc.inc b/Platform/Marvell/Armada/Armada.dsc.inc > index 1b68ef3..cf81615 100644 > --- a/Platform/Marvell/Armada/Armada.dsc.inc > +++ b/Platform/Marvell/Armada/Armada.dsc.inc > @@ -269,7 +269,7 @@ > gEmbeddedTokenSpaceGuid.PcdMetronomeTickPeriod|1000 > > # ARM SBSA Watchdog > - gArmTokenSpaceGuid.PcdGenericWatchdogControlBase|0xF0620000 > + gArmTokenSpaceGuid.PcdGenericWatchdogControlBase|0xF0610000 Hmm, do we never start the watchdog, or how did we not notice this? I can confirm against the docs that the fix is correct, so: Reviewed-by: Leif Lindholm > gArmTokenSpaceGuid.PcdGenericWatchdogRefreshBase|0xF0600000 > gArmTokenSpaceGuid.PcdGenericWatchdogEl2IntrNum|34 > > -- > 2.7.4 >