From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::233; helo=mail-wm0-x233.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 23AB720352A84 for ; Fri, 1 Dec 2017 09:25:16 -0800 (PST) Received: by mail-wm0-x233.google.com with SMTP id 9so4829759wme.4 for ; Fri, 01 Dec 2017 09:29:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=aN+f/Ec7fc/Wd1IyRUpPmDlMxrdTL/dQMNPoRRG6/3o=; b=fgJGwdW2pYV0lG2LVGZs7KYuVqel6n3Max9ticcAXjnu3Cr+S6BOVc2Y3hgBXZ249A bUAoiCuyTGgd/u3GeBxH4jt+YiKTaRJv8NDLIS418h+81DWrmwEnov1VdDn2/Iw+1WM3 hQs+B34DhSxka6l/xdRHVrOm3/eOc9kLE7aUY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=aN+f/Ec7fc/Wd1IyRUpPmDlMxrdTL/dQMNPoRRG6/3o=; b=gUBtkCqpdj1oX6XNVxvl77x02YcqJ2tQNRxEzkEQ4U8puEEO4BzEVQy3KKfSDNGaB2 ZbN0IeFoMUEiWDpFq30UrU65qbofvSF9mhrRkXcxm1lFosg/1QqCUPM8GFfYaF3yutvz WLXQN/zVxNTJrAUoevu+6OcaJH1TYKlX/gfFZthcvZ+Z273yctc5LcvWzQgGr7ji7Nh+ aiKI1pK/qGeQLYB6vcq4Azq0CBMkH9tXxxC3OrKNQvCiBVDGKf8SGi5v+43XkTihxXOV hd50BqeBsaQ5hc2DgqwY5YcmH06Y8bLcNY+VHjt0lARLBKXxBRYkjvZYwNj9XSMCMpqU ZkGA== X-Gm-Message-State: AJaThX4AzWyAlKJ6Uodq40jzQsj0oF6joVy45svNdlZtiDttaW+kER/4 7n9eAg8Xw8Idd5/TCaHsrokHGoze1mk= X-Google-Smtp-Source: AGs4zMZAMtcaiPvlawsa5l71C/7PQbE0avPK3DNSqYNtcbIVG+lh1CwvIXZicku+dAI1ozxC0ukFFA== X-Received: by 10.28.47.66 with SMTP id v63mr1729512wmv.144.1512149381771; Fri, 01 Dec 2017 09:29:41 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p15sm4396472wre.24.2017.12.01.09.29.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Dec 2017 09:29:40 -0800 (PST) Date: Fri, 1 Dec 2017 17:29:38 +0000 From: Leif Lindholm To: Evan Lloyd Cc: Ard Biesheuvel , "edk2-devel@lists.01.org" , Matteo Carlini , Girish Pathak Message-ID: <20171201172938.l76c25lubsraem35@bivouac.eciton.net> References: <20170926201529.11644-1-evan.lloyd@arm.com> <20170926201529.11644-20-evan.lloyd@arm.com> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 19/19] ArmPlatformPkg: New DP500/DP550/DP650 GOP driver. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 17:25:17 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 01, 2017 at 01:12:49PM +0000, Evan Lloyd wrote: > > whatsoever. If you introduce any library classes that abstract away > > the differences between platforms, you can include a Null version of > > such a library that simply does ASSERT (FALSE) in every function: this > > [[Evan Lloyd]] One could, indeed, do that. We, however, would be > very reluctant to incur the overhead of rework in response to > spurious cavils from a maintainer when it is of no direct relevance > to us. Rework is the expected norm for the first version of any patchset. If that is not calculated into your schedules, you will continue to be disappointed. An open source project is not a scrapyard for proprietary code, it is a collaborative environment where people and organisations work together to achieve better results than they could hope for individually. Like these suggestions for rework are of no direct relevance to you, your patches are of no direct relevance for the project - yet we have taken the time to sit down, try to understand them, and give feedback on how they could be improved to be of greater value to the community as a whole. I don't think I would be taking to hard a line if I suggest that you apologise to Ard for your statement above. Yes, we're all permitted to get annoyed and throw our toys out of the pram from time to time, but personal attacks are not acceptable. / Leif