From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::241; helo=mail-wr0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EBBC722152389 for ; Mon, 4 Dec 2017 05:48:20 -0800 (PST) Received: by mail-wr0-x241.google.com with SMTP id v22so17372267wrb.0 for ; Mon, 04 Dec 2017 05:52:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=uGU2LaW1hhJbApZQ/Dt47mKh9kPMTOfTlcz/glMNKSM=; b=DmwrVWug3Gd41Efkvbi5EJZbyLb5D70L0tUmnXOVlbjl4LYABjVQcqs99yEnUW0PPh 1qbvALrZ33KqWTqFhizjvEKdCSxCqcoTPN6rqJq+62UFnug5pFwkEd9JkgsOAqLExK18 CF4a5z7mq7OehgfUNR0zlLxi4/1drpcxmIGT4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=uGU2LaW1hhJbApZQ/Dt47mKh9kPMTOfTlcz/glMNKSM=; b=GuNvpxAVf0tYnXMITVb0hq26bBVkTSE5VXDChiKrQYl6GxwOpdfigOgJhwG/2w7jtB DtPxYI1tzFGs1INughShWaumynyScdlsr5V6r69RIj3J80lCHOwvcENNmhBOsLYQZ+x0 HqqidKsYcAr+JjMLYyJas4tXvmj6INO7zrRNhEN5D9uwvEUSS00kgl4UEPtZdgXAy/lt 7j30he3S4eJ4TvYoPErj2RPbbKJN389KOdszRiAXxarMEKOvQyfkeYaamuDl0MS4KVqQ C0ba4tju8XA0aSBdgJSL9xYYMvpxXbP2GbQtDv6JKPARWupPWMM2ICw4FQuLEzlI/gBt 9DOA== X-Gm-Message-State: AJaThX495Csqs20J3t0TpvxgXYxYKByWPBBDJh/4/gLleRSZsqX9Tcb4 UTdazckstdBzI2OJ0RJREyHcEA== X-Google-Smtp-Source: AGs4zMazLLx2wlA3wDICOaOr+Q+KvltggSWsXfL2sTIzUbqXIGmQcFQ+Tf2YijUERzBAOSw0VmLNNA== X-Received: by 10.223.151.49 with SMTP id r46mr13307109wrb.238.1512395569095; Mon, 04 Dec 2017 05:52:49 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e71sm8491626wma.13.2017.12.04.05.52.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Dec 2017 05:52:47 -0800 (PST) Date: Mon, 4 Dec 2017 13:52:46 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, jsd@semihalf.com Message-ID: <20171204135246.tozopcqfetsiutgx@bivouac.eciton.net> References: <1512142507-23282-1-git-send-email-mw@semihalf.com> <1512142507-23282-4-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1512142507-23282-4-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v2 3/4] Marvell/Applications: FirmwareUpdate: Fix usage information X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2017 13:48:21 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 01, 2017 at 04:35:06PM +0100, Marcin Wojtas wrote: > fupdate command's usage information referred to a deprecated > '-f' flag in 'examples' section. It was a residue from the > initial version of the application, removed during review > before merging to upstream branch. Correct the help information. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas I boggled slightly at how the file with deleted content is larger than the original, so went to have a look, and what I see is: --- pre.txt 2017-12-04 13:43:32.985446108 +0000 +++ post.txt 2017-12-04 13:44:30.433120594 +0000 @@ -50,10 +50,10 @@ ".SH EXAMPLES\r\n" " \r\n" "EXAMPLES:\r\n" -"Update firmware from file fs2:flash-image.bin\r\n" -" fupdate -f fs2:flash-image.bin\r\n" +"Update firmware in SPI flash from file fs2:flash-image.bin\r\n" +" fupdate fs2:flash-image.bin\r\n" ".SH RETURNVALUES\r\n" " \r\n" "RETURN VALUES:\r\n" " SHELL_SUCCESS The action was completed as requested.\r\n" -" SHELL_ABORTED Error while processing command\r\n" +" SHELL_ABORTED Error while processing command\r\n" Now, I don't mind random format cleanup as much in .uni files as elsewhere, since we don't get sane diffs anyway. But that also makes detailed and accurate commit messages much more important. So please, add something about the rewording and the whitespace fixes. / Leif > --- > Platform/Marvell/Applications/FirmwareUpdate/FUpdate.uni | Bin 5146 -> 5190 bytes > 1 file changed, 0 insertions(+), 0 deletions(-) > > diff --git a/Platform/Marvell/Applications/FirmwareUpdate/FUpdate.uni b/Platform/Marvell/Applications/FirmwareUpdate/FUpdate.uni > index 9d52e590c6d239621d226a240a3f9755210f52fe..146f624737d96e2cd354857dbb63390ebe2f347e 100644 > GIT binary patch > delta 56 > zcmbQGaZF=_h>& HAnXMIdh-p2 > > delta 28 > kcmX@6F-v2Eh|pv`p*Ut;hP27{LYA8k2`Mp7{v+%K0D@Hs0RR91 > > -- > 2.7.4 >