From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::241; helo=mail-wm0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1A2F722152383 for ; Mon, 4 Dec 2017 06:44:08 -0800 (PST) Received: by mail-wm0-x241.google.com with SMTP id r78so6291386wme.5 for ; Mon, 04 Dec 2017 06:48:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gsX3kexsHT5iSO2+v1bPRxDj6REI4gEURVl3mjTaVvM=; b=UJU4P/JMhGOYALqHEw0QPxP+dGCzCH23JcpII4crMIRBUvwx3DiseibZYpOQJASeX3 KmjyaoOXGxMT5FoIeZdZkKtn7L65EMmKAOpmp1aoiUsGwdwuJe2/DClAEZk0UmEi3KMY N0Ebl8oS60rOXBOaWXmNkQa6Fo2Yo9J65z7P0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gsX3kexsHT5iSO2+v1bPRxDj6REI4gEURVl3mjTaVvM=; b=mOGEXkm+joWegKRSSimPFFwZpswy8AJRYN7XBz/iklGSdRWKsY0GLnsVwNSwoNEE9S tbxfcCg14naFdjElaNA91bXjIFhhBj+4UMjRD1lvTKJMu8FRq3Hvs5OrDoVEX/W3Y3Jm StWdi9dc3V3rqHZAl7Oq5dPbzjvh73wnWgDVvF97E9UcgaxI4wN6HoF7QsioEuZIMGdg TZ+8Je/PLkN7t7hr1861GcImDNqgflV7OALJF23njCp7Zh2vmJbzSy9bUKKens1ihh0C pypD7fgRBOF5/xAmjO3RWvubWDJ1u0rtENtkIWWYb4oYt4RAFouf+OqjeNw3h7HCMNbj A+Nw== X-Gm-Message-State: AKGB3mLbJEAhBD8Vvob59W4Sq12STc82HgbauqWAxZ74QaYNClr1bgqr kHJ42k/sts5epMp75QUGt9lOaQ== X-Google-Smtp-Source: AGs4zMYsFbwkw8qv0uSA1MMQjGQFDg30R6KSWW97VJ+eMBUoH4ry+1WMEtHQBtDnOTr4ikURcTWv2Q== X-Received: by 10.28.96.195 with SMTP id u186mr3139478wmb.121.1512398917441; Mon, 04 Dec 2017 06:48:37 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d71sm3928431wma.7.2017.12.04.06.48.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Dec 2017 06:48:36 -0800 (PST) Date: Mon, 4 Dec 2017 14:48:34 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, masami.hiramatsu@linaro.org, masahisa.kojima@Linaro.org, daniel.thompson@linaro.org Message-ID: <20171204144834.sefvh4afhblzxw5s@bivouac.eciton.net> References: <20171204133308.32012-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171204133308.32012-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms] Silicon/SynQuacerI2CDxe: add missing __FUNCTION__ argument to %a specifier X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2017 14:44:09 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 04, 2017 at 01:33:08PM +0000, Ard Biesheuvel wrote: > The I2C driver prints a warning under DEBUG when a I2C transaction times > out. This will occur on the rev 0.1 DeveloperBox boards due to a board > level error in the I2C routing (unless the MCU has been lifted off the > bus). > > Currently, this will trigger a crash due to a missing __FUNCTION__ > argument to a %a specifier in a DEBUG string, because instead, the code > will attempt to dereference a EFI_STATUS variable as a char pointer. > > So add the missing __FUNCTION__ argument. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c b/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c > index fb404b17f93c..c3703dfb6c33 100644 > --- a/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c > +++ b/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c > @@ -330,7 +330,7 @@ SynQuacerI2cStartRequest ( > Status = WaitForInterrupt (I2c); > if (EFI_ERROR (Status)) { > BOOTTIME_DEBUG ((DEBUG_WARN, "%a: Timeout waiting for interrupt - %r\n", > - Status)); > + __FUNCTION__, Status)); > break; > } > > -- > 2.11.0 >