From: Leif Lindholm <leif.lindholm@linaro.org>
To: kalyan-nagabhirava <kalyankumar.nagabhirava@linaro.org>
Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org,
mark.gregotski@linaro.org
Subject: Re: [PATCH] [edk2 EmbeddedPkg]:Adding secure boot and HTTP image download (Disaster recovery image) Applications for Linux based platforms
Date: Mon, 4 Dec 2017 15:33:58 +0000 [thread overview]
Message-ID: <20171204153358.7jzrb4qokr6p7t7h@bivouac.eciton.net> (raw)
In-Reply-To: <20171128072758.13509-1-kalyankumar.nagabhirava@linaro.org>
Hi Kalyan,
Am I right in assuming that since this is the output of your team, you
have some time to look into reworking based on feedback (unlike the
HiKey support)?
A few high-level comments:
1) Please generate your patches with --stat=1000 --stat-graph-width=20
as per https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers
2) I see at least 3 separate patches below:
- Application/Dri
- Application/DriSecureBoot
- RdkBootManagerLib
3) List.h looks mostly to be reimplementing functionality that already
exists in BaseLib.h.
If you could address these three things and send out as a v2, then we
would be in a much better position to review the contribution
properly.
Best Regards,
Leif
On Tue, Nov 28, 2017 at 12:57:58PM +0530, kalyan-nagabhirava wrote:
> Linaro and RDK are working on standardizing the boot process for RDK STB boxes using Uefi.
> Added applications are reference implementation of RDK STB boot process on Arm platforms
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: kalyan-nagabhirava <kalyankumar.nagabhirava@linaro.org>
> ---
> EmbeddedPkg/Application/Dri/Dri.c | 26 +
> EmbeddedPkg/Application/Dri/Dri.inf | 56 ++
> .../Application/DriSecureBoot/DriSecureBoot.c | 32 ++
> .../Application/DriSecureBoot/DriSecureBoot.inf | 57 ++
> EmbeddedPkg/Application/SecureBoot/SecureBoot.c | 30 ++
> EmbeddedPkg/Application/SecureBoot/SecureBoot.inf | 57 ++
> EmbeddedPkg/Drivers/RdkDxe/RdkDxe.c | 97 ++++
> EmbeddedPkg/Drivers/RdkDxe/RdkDxe.h | 14 +
> EmbeddedPkg/Drivers/RdkDxe/RdkDxe.inf | 45 ++
> EmbeddedPkg/Library/RdkBootManagerLib/DiskIo.c | 536 +++++++++++++++++++
> EmbeddedPkg/Library/RdkBootManagerLib/HttpBoot.c | 315 +++++++++++
> .../Library/RdkBootManagerLib/Include/DiskIo.h | 20 +
> .../Library/RdkBootManagerLib/Include/HttpBoot.h | 7 +
> .../Library/RdkBootManagerLib/Include/List.h | 136 +++++
> .../RdkBootManagerLib/Include/RdkBootManagerLib.h | 31 ++
> .../Library/RdkBootManagerLib/Include/RdkFile.h | 20 +
> .../Library/RdkBootManagerLib/Include/SecureBoot.h | 40 ++
> .../RdkBootManagerLib/RdkBootManagerLib.dec | 52 ++
> .../RdkBootManagerLib/RdkBootManagerLib.inf | 81 +++
> EmbeddedPkg/Library/RdkBootManagerLib/RdkFile.c | 259 +++++++++
> EmbeddedPkg/Library/RdkBootManagerLib/SecureBoot.c | 577 +++++++++++++++++++++
> 21 files changed, 2488 insertions(+)
> create mode 100644 EmbeddedPkg/Application/Dri/Dri.c
> create mode 100644 EmbeddedPkg/Application/Dri/Dri.inf
> create mode 100644 EmbeddedPkg/Application/DriSecureBoot/DriSecureBoot.c
> create mode 100644 EmbeddedPkg/Application/DriSecureBoot/DriSecureBoot.inf
> create mode 100644 EmbeddedPkg/Application/SecureBoot/SecureBoot.c
> create mode 100644 EmbeddedPkg/Application/SecureBoot/SecureBoot.inf
> create mode 100644 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.c
> create mode 100644 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.h
> create mode 100644 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.inf
> create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/DiskIo.c
> create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/HttpBoot.c
> create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/DiskIo.h
> create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/HttpBoot.h
> create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/List.h
> create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/RdkBootManagerLib.h
> create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/RdkFile.h
> create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/SecureBoot.h
> create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/RdkBootManagerLib.dec
> create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/RdkBootManagerLib.inf
> create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/RdkFile.c
> create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/SecureBoot.c
next prev parent reply other threads:[~2017-12-04 15:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 7:27 [PATCH] [edk2 EmbeddedPkg]:Adding secure boot and HTTP image download (Disaster recovery image) Applications for Linux based platforms kalyan-nagabhirava
2017-12-04 15:33 ` Leif Lindholm [this message]
2017-12-04 15:47 ` Kalyan Nagabhirava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204153358.7jzrb4qokr6p7t7h@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox