From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::22e; helo=mail-wm0-x22e.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com [IPv6:2a00:1450:400c:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D4CD322152383 for ; Mon, 4 Dec 2017 07:29:32 -0800 (PST) Received: by mail-wm0-x22e.google.com with SMTP id n138so6555414wmg.2 for ; Mon, 04 Dec 2017 07:34:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=S1X7SyWrvIJq5Itz/Z1F/6diKo2NKitAHzBbp7jlpJw=; b=EKMYhz3DTsqV+ZtftNB9UPCyvIao++pRm0rAnB4f4E+9KYs7yj1PrxBe+BvueGCxqf h+8EN9X9m6NNK5tucqD+I9tONPF4414ugqZIWG8EV0zoFgFczLhda/q3CmReOtRRahFc ckq3zhJzbGFvC8fKo3v+/9qmaLa+cI0ul16Lg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=S1X7SyWrvIJq5Itz/Z1F/6diKo2NKitAHzBbp7jlpJw=; b=Clb2bT9rJe9RW8Ayi5S8fICcO2v+wYazFiVWiriHfMdRLMLxkY96TWQMF9HnGLLbyt FUqQTdHmY7k7NMhCM0fPeygEfMQ46nttNlYIvheJ/hPrCPvaZYN3YwDjsLFlCs2SmtQZ h6RNDhLrNNHMjQrlDoupzeuGIAHYEWhTFd7fkSJe7mH44BDfdiCPLP/8xiHPGJkwADia ObmYkrKHfQmq7+F1qar2W0uYNPtxPh2NTGwNrcVwwIjxavF10Lbg/VYzqkckDy+bNmCZ rKNyySNGJ0h9i5ftDrVBME8q4aPf6FKyDVIY+xqL8m/IDtvGGrTcRdvqVtfSpaQu7hkW Fafg== X-Gm-Message-State: AJaThX5kHenFnGQoBgB5yc3AAWVkKrpP/xu8e3ldW3wSZ1AGyQXoVlQ5 3rAcuQv0p7RQBiDZC9vvFQtlfA== X-Google-Smtp-Source: AGs4zMa1Yi9tVouyRfr3QKjodi/4QO92VBuj9gjCreGbtZBhScY0VxBJz/r5ccDHCxFvGZNr+0PiKg== X-Received: by 10.28.62.20 with SMTP id l20mr8289482wma.6.1512401641090; Mon, 04 Dec 2017 07:34:01 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o88sm21096811wrc.10.2017.12.04.07.33.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Dec 2017 07:33:59 -0800 (PST) Date: Mon, 4 Dec 2017 15:33:58 +0000 From: Leif Lindholm To: kalyan-nagabhirava Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, mark.gregotski@linaro.org Message-ID: <20171204153358.7jzrb4qokr6p7t7h@bivouac.eciton.net> References: <20171128072758.13509-1-kalyankumar.nagabhirava@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171128072758.13509-1-kalyankumar.nagabhirava@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] [edk2 EmbeddedPkg]:Adding secure boot and HTTP image download (Disaster recovery image) Applications for Linux based platforms X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2017 15:29:33 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Kalyan, Am I right in assuming that since this is the output of your team, you have some time to look into reworking based on feedback (unlike the HiKey support)? A few high-level comments: 1) Please generate your patches with --stat=1000 --stat-graph-width=20 as per https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers 2) I see at least 3 separate patches below: - Application/Dri - Application/DriSecureBoot - RdkBootManagerLib 3) List.h looks mostly to be reimplementing functionality that already exists in BaseLib.h. If you could address these three things and send out as a v2, then we would be in a much better position to review the contribution properly. Best Regards, Leif On Tue, Nov 28, 2017 at 12:57:58PM +0530, kalyan-nagabhirava wrote: > Linaro and RDK are working on standardizing the boot process for RDK STB boxes using Uefi. > Added applications are reference implementation of RDK STB boot process on Arm platforms > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: kalyan-nagabhirava > --- > EmbeddedPkg/Application/Dri/Dri.c | 26 + > EmbeddedPkg/Application/Dri/Dri.inf | 56 ++ > .../Application/DriSecureBoot/DriSecureBoot.c | 32 ++ > .../Application/DriSecureBoot/DriSecureBoot.inf | 57 ++ > EmbeddedPkg/Application/SecureBoot/SecureBoot.c | 30 ++ > EmbeddedPkg/Application/SecureBoot/SecureBoot.inf | 57 ++ > EmbeddedPkg/Drivers/RdkDxe/RdkDxe.c | 97 ++++ > EmbeddedPkg/Drivers/RdkDxe/RdkDxe.h | 14 + > EmbeddedPkg/Drivers/RdkDxe/RdkDxe.inf | 45 ++ > EmbeddedPkg/Library/RdkBootManagerLib/DiskIo.c | 536 +++++++++++++++++++ > EmbeddedPkg/Library/RdkBootManagerLib/HttpBoot.c | 315 +++++++++++ > .../Library/RdkBootManagerLib/Include/DiskIo.h | 20 + > .../Library/RdkBootManagerLib/Include/HttpBoot.h | 7 + > .../Library/RdkBootManagerLib/Include/List.h | 136 +++++ > .../RdkBootManagerLib/Include/RdkBootManagerLib.h | 31 ++ > .../Library/RdkBootManagerLib/Include/RdkFile.h | 20 + > .../Library/RdkBootManagerLib/Include/SecureBoot.h | 40 ++ > .../RdkBootManagerLib/RdkBootManagerLib.dec | 52 ++ > .../RdkBootManagerLib/RdkBootManagerLib.inf | 81 +++ > EmbeddedPkg/Library/RdkBootManagerLib/RdkFile.c | 259 +++++++++ > EmbeddedPkg/Library/RdkBootManagerLib/SecureBoot.c | 577 +++++++++++++++++++++ > 21 files changed, 2488 insertions(+) > create mode 100644 EmbeddedPkg/Application/Dri/Dri.c > create mode 100644 EmbeddedPkg/Application/Dri/Dri.inf > create mode 100644 EmbeddedPkg/Application/DriSecureBoot/DriSecureBoot.c > create mode 100644 EmbeddedPkg/Application/DriSecureBoot/DriSecureBoot.inf > create mode 100644 EmbeddedPkg/Application/SecureBoot/SecureBoot.c > create mode 100644 EmbeddedPkg/Application/SecureBoot/SecureBoot.inf > create mode 100644 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.c > create mode 100644 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.h > create mode 100644 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.inf > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/DiskIo.c > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/HttpBoot.c > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/DiskIo.h > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/HttpBoot.h > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/List.h > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/RdkBootManagerLib.h > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/RdkFile.h > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/SecureBoot.h > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/RdkBootManagerLib.dec > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/RdkBootManagerLib.inf > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/RdkFile.c > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/SecureBoot.c