Re: [PATCH 00/19] ArmPlatformPkg: remove unused or migrated modules

[Leif Lindholm <leif.lindholm@linaro.org>]

On Sat, Nov 25, 2017 at 11:47:39AM +0000, Leif Lindholm wrote:
> On Wed, Nov 15, 2017 at 04:56:18PM +0000, Ard Biesheuvel wrote:
> > Remove everything from ArmPlatformPkg that is either unused, or so highly
> > specific to development platforms manufactured by ARM Ltd. that they really
> > don't belong in the main branch.
> > 
> > Note that the migration involves patches against edk2-platforms that add
> > some of this code back under Platform/ARM. Most of it (but not all of it)
> > has been posted as a separate series already.
> > 
> > Ard Biesheuvel (19):
> >   ArmPkg: remove unused ArmGicSecLib library implementation
> >   ArmPlatformPkg: remove ArmPlatformSecLib definition and
> >     implementations
> >   ArmPlatformPkg: remove unused DebugSecExtraActionLib library
> >   ArmPlatformPkg: remove ArmTrustedMonitorLib definition and
> >     implementation
> >   ArmPlatformPkg: remove ArmGetCpuCountPerCluster () from ArmPlatformLib
> >   ArmPlatformPkg: remove NorFlashArmVExpressLib
> >   ArmPlatformPkg: remove ArmJunoPkg
> >   ArmPlatformPkg/PL031RealTimeClockLib: drop ArmPlatformSysConfigLib
> >     reference
> >   ArmPlatformPkg: remove ArmVExpressPkg
> 
> Please hold off on this one (remove ArmVExpressPkg) until we hear back
> from Evan.

Once imported into edk2-platforms:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> >   ArmPlatformPkg: remove ArmPlatformSysConfigLib library class
> 
> No separate comment on this one, just to break it away from the below.
> 
> >   ArmPlatformPkg: remove unused PL301Axi driver
> >   ArmPlatformPkg: remove unused PL35x driver
> >   ArmPlatformPkg: remove PL34xDmc driver
> >   ArmPlatformPkg: remove unused PL310 driver
> >   ArmPlatformPkg: remove unused ArmTrustZone driver
> >   ArmPlatformPkg: remove unused SP804 driver and TimerLib
> >   implementation
> 
> Please separate the "delete used drivers" from the rest of this set.
> Let's give potential out-of-tree users a few weeks to respond.
> 
> My last working day before sabbatical is 15 Dec, so how about
> Reviewed-by-if-no-comments-by-15-Dec: Leif Lindholm <leif.lindholm@linaro.org>
> ?
> 
> >   ArmPlatformPkg: remove unused L2X0CacheLibNull library
> >   ArmPlatformPkg: remove EblCmdLib implementation
> >   ArmPlatformPkg: remove BootMonFs and ArmShellCmdRunAxf
> 
> For the remainder:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>