From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH] ArmPlatformPkg/LcdGraphicsOutputDxe: remove VExpressPkg dependency
Date: Mon, 4 Dec 2017 21:34:15 +0000 [thread overview]
Message-ID: <20171204213415.zhjostmh4pusgk2f@bivouac.eciton.net> (raw)
In-Reply-To: <20171204205052.10197-1-ard.biesheuvel@linaro.org>
On Mon, Dec 04, 2017 at 08:50:52PM +0000, Ard Biesheuvel wrote:
> The two instantiations of LcdGraphicsOutputDxe reference VExpressPkg.dec
> without actually relying on anything it defines. In preparation of
> moving out VExpressPkg into edk2-platforms, drop these references so we
> can keep LcdGraphicsOutputDxe in EDK2.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> This is a preparatory patch for my rebase of the ArmPlatformPkg cleanup
> series, allowing future contributions to the LCD output driver to remain
> in EDK2, while forcing VExpress specific glue code to be factored out
> correctly and contributed to edk2-platforms.
>
> ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcdGraphicsOutputDxe.inf | 1 -
> ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111LcdGraphicsOutputDxe.inf | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcdGraphicsOutputDxe.inf b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcdGraphicsOutputDxe.inf
> index 462d1fa402d7..896fc588b275 100644
> --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcdGraphicsOutputDxe.inf
> +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcdGraphicsOutputDxe.inf
> @@ -31,7 +31,6 @@ [Packages]
> MdePkg/MdePkg.dec
> MdeModulePkg/MdeModulePkg.dec
> ArmPkg/ArmPkg.dec
> - ArmPlatformPkg/ArmVExpressPkg/ArmVExpressPkg.dec
> ArmPlatformPkg/ArmPlatformPkg.dec
>
> [LibraryClasses]
> diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111LcdGraphicsOutputDxe.inf b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111LcdGraphicsOutputDxe.inf
> index 003cc2ffa912..39e42bcbab2a 100644
> --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111LcdGraphicsOutputDxe.inf
> +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111LcdGraphicsOutputDxe.inf
> @@ -30,7 +30,6 @@ [Packages]
> MdePkg/MdePkg.dec
> MdeModulePkg/MdeModulePkg.dec
> ArmPkg/ArmPkg.dec
> - ArmPlatformPkg/ArmVExpressPkg/ArmVExpressPkg.dec
> ArmPlatformPkg/ArmPlatformPkg.dec
>
> [LibraryClasses]
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-12-04 21:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 20:50 [PATCH] ArmPlatformPkg/LcdGraphicsOutputDxe: remove VExpressPkg dependency Ard Biesheuvel
2017-12-04 21:34 ` Leif Lindholm [this message]
2017-12-04 22:02 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204213415.zhjostmh4pusgk2f@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox