[PATCH 0/2] MdeModulePkg: Remove unnecessary parentheses in 'if'

[PATCH 0/2] MdeModulePkg: Remove unnecessary parentheses in 'if'

[Hao Wu]

The series removes unnecessary parentheses in 'if' statements.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>

Hao Wu (2):
  MdeModulePkg/PartitionDxe: Remove unnecessary parentheses in 'if'
  MdeModulePkg/DisplayEngineDxe: Remove unnecessary parentheses in 'if'

 MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 2 +-
 MdeModulePkg/Universal/DisplayEngineDxe/Popup.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.12.0.windows.1

[PATCH 1/2] MdeModulePkg/PartitionDxe: Remove unnecessary parentheses in 'if'

[Hao Wu]

This commit removes unnecessary parentheses in 'if' statements to
resolve the build failures by the XCODE5 tool chain.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c
index 603abfe55a..bb9d0b70ce 100644
--- a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c
+++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c
@@ -1212,7 +1212,7 @@ PartitionInstallChildHandle (
   //
   CopyMem (&Private->PartitionInfo, PartitionInfo, sizeof (EFI_PARTITION_INFO_PROTOCOL));
 
-  if ((PartitionInfo->System == 1)) {
+  if (PartitionInfo->System == 1) {
     Private->EspGuid = &gEfiPartTypeSystemPartGuid;
   } else {
     //
-- 
2.12.0.windows.1

[PATCH 2/2] MdeModulePkg/DisplayEngineDxe: Remove unnecessary parentheses in 'if'

[Hao Wu]

This commit removes unnecessary parentheses in 'if' statements to
resolve the build failures by the XCODE5 tool chain.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 MdeModulePkg/Universal/DisplayEngineDxe/Popup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/DisplayEngineDxe/Popup.c b/MdeModulePkg/Universal/DisplayEngineDxe/Popup.c
index 7c76f69447..0a832052ef 100644
--- a/MdeModulePkg/Universal/DisplayEngineDxe/Popup.c
+++ b/MdeModulePkg/Universal/DisplayEngineDxe/Popup.c
@@ -686,7 +686,7 @@ CreatePopup (
   }
 
   gMessageString = HiiGetString (HiiHandle, Message, NULL);
-  if((gMessageString == NULL)) {
+  if(gMessageString == NULL) {
     return EFI_INVALID_PARAMETER;
   }
 
-- 
2.12.0.windows.1

Re: [PATCH 0/2] MdeModulePkg: Remove unnecessary parentheses in 'if'

[Zeng, Star]

Reviewed-by: Star Zeng <star.zeng@intel.com>

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Hao Wu
Sent: Tuesday, December 5, 2017 1:18 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Dong, Eric <eric.dong@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [edk2] [PATCH 0/2] MdeModulePkg: Remove unnecessary parentheses in 'if'

The series removes unnecessary parentheses in 'if' statements.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>

Hao Wu (2):
  MdeModulePkg/PartitionDxe: Remove unnecessary parentheses in 'if'
  MdeModulePkg/DisplayEngineDxe: Remove unnecessary parentheses in 'if'

 MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 2 +-
 MdeModulePkg/Universal/DisplayEngineDxe/Popup.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.12.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [PATCH 0/2] MdeModulePkg: Remove unnecessary parentheses in 'if'

[Gao, Liming]

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Wu, Hao A
> Sent: Tuesday, December 5, 2017 1:18 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming <liming.gao@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; Zeng, Star
> <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> Subject: [PATCH 0/2] MdeModulePkg: Remove unnecessary parentheses in 'if'
> 
> The series removes unnecessary parentheses in 'if' statements.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> 
> Hao Wu (2):
>   MdeModulePkg/PartitionDxe: Remove unnecessary parentheses in 'if'
>   MdeModulePkg/DisplayEngineDxe: Remove unnecessary parentheses in 'if'
> 
>  MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 2 +-
>  MdeModulePkg/Universal/DisplayEngineDxe/Popup.c      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> --
> 2.12.0.windows.1