* [PATCH 0/2] MdeModulePkg: Remove unnecessary parentheses in 'if'
@ 2017-12-05 5:18 Hao Wu
2017-12-05 5:18 ` [PATCH 1/2] MdeModulePkg/PartitionDxe: " Hao Wu
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Hao Wu @ 2017-12-05 5:18 UTC (permalink / raw)
To: edk2-devel; +Cc: Hao Wu, Liming Gao, Ruiyu Ni, Star Zeng, Eric Dong, Dandan Bi
The series removes unnecessary parentheses in 'if' statements.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Hao Wu (2):
MdeModulePkg/PartitionDxe: Remove unnecessary parentheses in 'if'
MdeModulePkg/DisplayEngineDxe: Remove unnecessary parentheses in 'if'
MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 2 +-
MdeModulePkg/Universal/DisplayEngineDxe/Popup.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.12.0.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] MdeModulePkg/PartitionDxe: Remove unnecessary parentheses in 'if'
2017-12-05 5:18 [PATCH 0/2] MdeModulePkg: Remove unnecessary parentheses in 'if' Hao Wu
@ 2017-12-05 5:18 ` Hao Wu
2017-12-05 5:18 ` [PATCH 2/2] MdeModulePkg/DisplayEngineDxe: " Hao Wu
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Hao Wu @ 2017-12-05 5:18 UTC (permalink / raw)
To: edk2-devel; +Cc: Hao Wu, Liming Gao, Ruiyu Ni, Star Zeng, Eric Dong
This commit removes unnecessary parentheses in 'if' statements to
resolve the build failures by the XCODE5 tool chain.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c
index 603abfe55a..bb9d0b70ce 100644
--- a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c
+++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c
@@ -1212,7 +1212,7 @@ PartitionInstallChildHandle (
//
CopyMem (&Private->PartitionInfo, PartitionInfo, sizeof (EFI_PARTITION_INFO_PROTOCOL));
- if ((PartitionInfo->System == 1)) {
+ if (PartitionInfo->System == 1) {
Private->EspGuid = &gEfiPartTypeSystemPartGuid;
} else {
//
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] MdeModulePkg/DisplayEngineDxe: Remove unnecessary parentheses in 'if'
2017-12-05 5:18 [PATCH 0/2] MdeModulePkg: Remove unnecessary parentheses in 'if' Hao Wu
2017-12-05 5:18 ` [PATCH 1/2] MdeModulePkg/PartitionDxe: " Hao Wu
@ 2017-12-05 5:18 ` Hao Wu
2017-12-05 5:47 ` [PATCH 0/2] MdeModulePkg: " Zeng, Star
2017-12-05 6:45 ` Gao, Liming
3 siblings, 0 replies; 5+ messages in thread
From: Hao Wu @ 2017-12-05 5:18 UTC (permalink / raw)
To: edk2-devel; +Cc: Hao Wu, Liming Gao, Eric Dong, Dandan Bi
This commit removes unnecessary parentheses in 'if' statements to
resolve the build failures by the XCODE5 tool chain.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/MdeModulePkg/Universal/DisplayEngineDxe/Popup.c b/MdeModulePkg/Universal/DisplayEngineDxe/Popup.c
index 7c76f69447..0a832052ef 100644
--- a/MdeModulePkg/Universal/DisplayEngineDxe/Popup.c
+++ b/MdeModulePkg/Universal/DisplayEngineDxe/Popup.c
@@ -686,7 +686,7 @@ CreatePopup (
}
gMessageString = HiiGetString (HiiHandle, Message, NULL);
- if((gMessageString == NULL)) {
+ if(gMessageString == NULL) {
return EFI_INVALID_PARAMETER;
}
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] MdeModulePkg: Remove unnecessary parentheses in 'if'
2017-12-05 5:18 [PATCH 0/2] MdeModulePkg: Remove unnecessary parentheses in 'if' Hao Wu
2017-12-05 5:18 ` [PATCH 1/2] MdeModulePkg/PartitionDxe: " Hao Wu
2017-12-05 5:18 ` [PATCH 2/2] MdeModulePkg/DisplayEngineDxe: " Hao Wu
@ 2017-12-05 5:47 ` Zeng, Star
2017-12-05 6:45 ` Gao, Liming
3 siblings, 0 replies; 5+ messages in thread
From: Zeng, Star @ 2017-12-05 5:47 UTC (permalink / raw)
To: Wu, Hao A, edk2-devel@lists.01.org
Cc: Ni, Ruiyu, Dong, Eric, Wu, Hao A, Gao, Liming, Bi, Dandan,
Zeng, Star
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Hao Wu
Sent: Tuesday, December 5, 2017 1:18 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Dong, Eric <eric.dong@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [edk2] [PATCH 0/2] MdeModulePkg: Remove unnecessary parentheses in 'if'
The series removes unnecessary parentheses in 'if' statements.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Hao Wu (2):
MdeModulePkg/PartitionDxe: Remove unnecessary parentheses in 'if'
MdeModulePkg/DisplayEngineDxe: Remove unnecessary parentheses in 'if'
MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 2 +-
MdeModulePkg/Universal/DisplayEngineDxe/Popup.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.12.0.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] MdeModulePkg: Remove unnecessary parentheses in 'if'
2017-12-05 5:18 [PATCH 0/2] MdeModulePkg: Remove unnecessary parentheses in 'if' Hao Wu
` (2 preceding siblings ...)
2017-12-05 5:47 ` [PATCH 0/2] MdeModulePkg: " Zeng, Star
@ 2017-12-05 6:45 ` Gao, Liming
3 siblings, 0 replies; 5+ messages in thread
From: Gao, Liming @ 2017-12-05 6:45 UTC (permalink / raw)
To: Wu, Hao A, edk2-devel@lists.01.org
Cc: Ni, Ruiyu, Zeng, Star, Dong, Eric, Bi, Dandan
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Wu, Hao A
> Sent: Tuesday, December 5, 2017 1:18 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming <liming.gao@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; Zeng, Star
> <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> Subject: [PATCH 0/2] MdeModulePkg: Remove unnecessary parentheses in 'if'
>
> The series removes unnecessary parentheses in 'if' statements.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
>
> Hao Wu (2):
> MdeModulePkg/PartitionDxe: Remove unnecessary parentheses in 'if'
> MdeModulePkg/DisplayEngineDxe: Remove unnecessary parentheses in 'if'
>
> MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 2 +-
> MdeModulePkg/Universal/DisplayEngineDxe/Popup.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> --
> 2.12.0.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-05 6:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-05 5:18 [PATCH 0/2] MdeModulePkg: Remove unnecessary parentheses in 'if' Hao Wu
2017-12-05 5:18 ` [PATCH 1/2] MdeModulePkg/PartitionDxe: " Hao Wu
2017-12-05 5:18 ` [PATCH 2/2] MdeModulePkg/DisplayEngineDxe: " Hao Wu
2017-12-05 5:47 ` [PATCH 0/2] MdeModulePkg: " Zeng, Star
2017-12-05 6:45 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox