From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::241; helo=mail-wm0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BB9AA2035626F for ; Tue, 5 Dec 2017 06:06:06 -0800 (PST) Received: by mail-wm0-x241.google.com with SMTP id 64so1497138wme.3 for ; Tue, 05 Dec 2017 06:10:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3zzgdkQ4OxhVIb+n5ITxYQjM3sMbxRrXm3zCKbreTlU=; b=DATSqZbNz2Nn4plfb1+PGfH9Tv1vYDN7uM0rd9yLJI0LDO1S6k3mlb55YCvGMLh7hq tnREoH1v6ieb4/d2VOqs/7yDglqTbNG8QjP3Ezf53REg0HsumjuKFlNSZL00jidsJfNx Ul4t2rejkrDR/OoCHmuJrs2L/3QGPhPQe9jmw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3zzgdkQ4OxhVIb+n5ITxYQjM3sMbxRrXm3zCKbreTlU=; b=f6H8aZwfue1YoSfS7e0f0OW8+Rd3sMAEVBK5t+/I+CzjDOhWnSmgemc00kiNNI83mD ij/wBTgxGiOcMV5fzsvDhr9sYXxe13DS69s1C6wNZdFhmg10L508BokmmdwdsddmHcpb 6Gyc8bSzWwEy/M8e41u2rLXRNbbEkjjrT61gQCVryeh/G9rPJK9rfNj9H0a0rpEG+XLn hcAIdAa3D7ZTInVjtlGJOLWAZgkx3Xio4obki+o+NFgOZId27AW2gNCEBxJsH9+vjbbQ s0nzKJpLv7paGa/gY4NpKAlWzvjRk8rrZOYytRCGM++EiNDqxx5ItqFbPUh9IOUPPfxi 0KnA== X-Gm-Message-State: AKGB3mLXY/c9sBQYmzXBKjeFcWTwWm69YVz3urt07aXiYMH1mKl2jlwO dAR9gqcPWY9Mi5/SdINRUP0nDQ== X-Google-Smtp-Source: AGs4zMa1Q9sFQ9HvGBS6bxSvM6uGVbUlzYbbRajLuK+M+DgbwztKa7L5/9qZsFCj/7xuI6UVACzBnw== X-Received: by 10.28.220.67 with SMTP id t64mr9949776wmg.150.1512483035998; Tue, 05 Dec 2017 06:10:35 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d10sm686901wmh.15.2017.12.05.06.10.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Dec 2017 06:10:34 -0800 (PST) Date: Tue, 5 Dec 2017 14:10:33 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, jsd@semihalf.com Message-ID: <20171205141033.i5oijhjgc2e6om3e@bivouac.eciton.net> References: <1512453425-25446-1-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1512453425-25446-1-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v3 0/4] Armada 7k/8k - misc improvements pt.3 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Dec 2017 14:06:07 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Thanks. For the series: Reviewed-by: Leif Lindholm Pushed as 84c212b1b4..2348894694. On Tue, Dec 05, 2017 at 06:57:01AM +0100, Marcin Wojtas wrote: > Hi, > > The third version of the patchset brings the corrections > requested in the review. Details can be found in the changelog > below. > > The patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/misc-upstream-r20171205 > > I'm looking forward to your comments or remarks. > > Best regards, > Marcin > > Changelog: > v2 -> v3 > * 1/4 > - remove hardcoded DEFINE from the dsc file and enable > passing the argument in a command line during build time > - Add RB > > * 3/4 > - Mention additional help information improvements in the > commit log > > * 4/4 > - Add RB > > v1 -> v2 > > * 1/4 > - Add tftp as a build-time selectable option > - Update commit message > > * 2/4 > - Add RB > > * 3/4 > - Leave initial file format and reword commit message > > * 4/4 > - Leave PHY_AUTONEGOTIATE_TIMEOUT unmodified and > remove double definition of the timeout. > > Marcin Wojtas (4): > Marvell/Armada: Switch to dynamic tftp command > Marvell/Armada: Fix watchdog control base > Marvell/Applications: FirmwareUpdate: Fix usage information > Marvell/Drivers: MvPhyDxe: Cleanup the header > > Platform/Marvell/Applications/FirmwareUpdate/FUpdate.uni | Bin 5146 -> 5190 bytes > Platform/Marvell/Armada/Armada.dsc.inc | 6 +- > Platform/Marvell/Armada/Armada70x0.fdf | 3 + > Platform/Marvell/Drivers/Net/Phy/MvPhyDxe/MvPhyDxe.c | 2 +- > Platform/Marvell/Drivers/Net/Phy/MvPhyDxe/MvPhyDxe.h | 152 ++++---------------- > 5 files changed, 39 insertions(+), 124 deletions(-) > > -- > 2.7.4 >