From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=pete@akeo.ie; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 415682217CE2E for ; Wed, 6 Dec 2017 03:10:49 -0800 (PST) Received: by mail-wm0-x243.google.com with SMTP id f206so6378065wmf.5 for ; Wed, 06 Dec 2017 03:15:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=egji949xKxTjMFE1aGJgkMed8ibYGDowH5ilG3rxlmk=; b=1UmY95Gan7736uKZkmhOCLn86gLIYERv+hjuJvTlx3XWDHJ0BO3dBbLO/afyum/FYx V3VAU5Po3Or483Rj35et+ajK/7h+hzKMKnQbv6sK6TwdrzeuFx4a2Vl+cFLpT9fCPjKr A+i6FU7yTGGEoQFLLX7Vv0l0R9pAtF7bWNWPWcXlg4u4Q+ZA1gD1VT3dAOaUSmWLNFc1 iiS3KMfzoNSPEnbTjTUF9sjA1BghDO5KoADV334SpqcLUGgVVOz7M9JYcjxrYDCqcc6m CJpu3WXX4ulUSTsy4I39gti29GvjXHhCFXmLHCT79LruzUYh6C/PTPqvnLVH0Vs/s80A pVCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=egji949xKxTjMFE1aGJgkMed8ibYGDowH5ilG3rxlmk=; b=Hbz+sswMey8lr0O32s48OnjTvRsHvrXxuZZWgRpWia6xTa/5JM0lt4JD9GAR4uOl8+ eAuc9eK2BWGB5/u+Aql9huyjNyzQUcYZWWTCNfelkqggw2ynBvp7jKUzHjoicKjMvSHz SoXYeJ4NxxJS7XUK3THwCP8r9wAATZ1T8N3M95Y90NBP/WPTK4FN8eds1iGhQzd1oxRz /97LUWgcnB0bnp8BMi677kVyvhvS5CvrVyUnxgvp7IE4SS25Jd5M30uQYi5l8IKWfU+f nB8LCFpUMgNfvzW3s34OGZQ2wDODwCaI8OfKT4TyHS9hrhgdVlcds+v9yipueOU+PUYs xuBw== X-Gm-Message-State: AJaThX79WgG+ds3HChNUvCAzNZhwXa+s/Ba7xepxrpebN2x/JYlGdFvH 4C7XhAZwnR1OZH+0iXwnEVmVyndYlvY= X-Google-Smtp-Source: AGs4zMbOYh1sn6m83IQ+0A3zTCW3+osUn+iL/LRxUv8gxP32m75i5HUxz1nLpDEHDrTKshbpheJ4Rg== X-Received: by 10.80.144.112 with SMTP id z45mr39117764edz.185.1512558918775; Wed, 06 Dec 2017 03:15:18 -0800 (PST) Received: from localhost.localdomain ([84.203.69.204]) by smtp.gmail.com with ESMTPSA id b17sm1132422edj.21.2017.12.06.03.15.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 Dec 2017 03:15:18 -0800 (PST) From: Pete Batard To: edk2-devel@lists.01.org Cc: liming.gao@intel.com Date: Wed, 6 Dec 2017 11:15:03 +0000 Message-Id: <20171206111509.10144-1-pete@akeo.ie> X-Mailer: git-send-email 2.9.3.windows.2 Subject: [PATCH v2 0/6] Add ARM support for VS2017 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2017 11:10:50 -0000 This is a v2 of the previous patch, that takes into account the alignment of suppressed level 4 warnings between IA32, X64 and ARM, and that also removes compiler options that weren't actually needed. The following series adds ARM compilation support for the VS2017 toolchain. * PATCH 1 targets the disabling of VS Level 4 warnings. The disabled warnings for ARM are now aligned with IA32 and X64. * PATCH 2 adds a NULL handler for the base stack check, since this is a GCC functionality. * PATCH 3 updates MdePkg/Library/BaseLib so that the RVCT assembly sources are also used for MSFT. * PATCH 4 adds the required compiler intrinsics replacements for division, shift and memset/memcpy. * PATCH 5 adds variable argument handlers for print output. Note that this is done without relying on any external headers, with the VA_ARG macro having been reverse engineered from MSFT ARM assembly output. * PATCH 6 enables the selection of ARM in the conf templates. With these patches, VS2017 toolchain users should be able to compile regular UEFI ARM applications using EDK2. Note that, unlike ARM64 support, ARM support does not require a specific update of Visual Studio 2017, as the ARM toolchain has been available from the very first release. Additional notes: We tested compiling and running the full UEFI Shell with this series, as well as a small set of applications and drivers, and found no issues. With an additional patch [1], it is also possible to use this proposal to compile a complete QEMU ARM firmware. As the patch shows, the changes that need to be applied to the EDK2 sources to achieve this are actually very minimal. However, the generated firmware does not currently boot, possibly because of the following warnings being generated by the MS compiler: - ArmCpuDxe.dll : warning LNK4072: section count 118 exceeds max (96); image may not run - UiApp.dll : warning LNK4072: section count 113 exceeds max (96); image may not run As far as I could see, the section count max is hardcoded so a workaround would be needed to address those. Also, because the VS2017 ARM compiler forces a section alignment of 4096 bytes (which in turn forces use to use /FILEALIGN:4096 as a linker option for the firmware generation), the generated firmware exceeds 2MB and we had to double its size to 4MB. At this stage, since the goal of this series is to allow users to compile regular ARM UEFI applications using the VS2017 toolchain, I have non plans to spend more time on the QEMU firmware issues, especially as I suspect that reducing the firmware size back to 2 MB may not be achievable without Microsoft altering their compiler. I am however hopeful that ARM specialists can take this matter over eventually... Regards, /Pete [1] https://github.com/pbatard/edk2/commit/c4ce41094a46f4f3dc7ccc64a90604813f037b13 Pete Batard (6): MdePkg: Disable some Level 4 warnings for VS2017/ARM MdePkg/Library/BaseStackCheckLib: Add Null handler for VS2017/ARM MdePkg/Library/BaseLib: Enable VS2017/ARM builds ArmPkg/Library/CompilerIntrinsicsLib: Enable VS2017/ARM builds MdePkg/Include: Add VA list support for VS2017/ARM BaseTools/Conf: Add VS2017/ARM support ArmPkg/Library/CompilerIntrinsicsLib/Arm/rtdiv.asm | 255 ++++++++++++++++++++ ArmPkg/Library/CompilerIntrinsicsLib/Arm/rtsrsh.asm | 45 ++++ ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf | 13 +- ArmPkg/Library/CompilerIntrinsicsLib/memcpy_ms.c | 34 +++ ArmPkg/Library/CompilerIntrinsicsLib/memset_ms.c | 33 +++ BaseTools/Conf/build_rule.template | 31 ++- BaseTools/Conf/tools_def.template | 28 +++ MdePkg/Include/Arm/ProcessorBind.h | 96 ++++++-- MdePkg/Include/Base.h | 13 + MdePkg/Library/BaseLib/Arm/CpuBreakpoint.asm | 5 +- MdePkg/Library/BaseLib/BaseLib.inf | 16 +- MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf | 5 +- MdePkg/Library/BaseStackCheckLib/BaseStackCheckNull.c | 18 ++ 13 files changed, 562 insertions(+), 30 deletions(-) create mode 100644 ArmPkg/Library/CompilerIntrinsicsLib/Arm/rtdiv.asm create mode 100644 ArmPkg/Library/CompilerIntrinsicsLib/Arm/rtsrsh.asm create mode 100644 ArmPkg/Library/CompilerIntrinsicsLib/memcpy_ms.c create mode 100644 ArmPkg/Library/CompilerIntrinsicsLib/memset_ms.c create mode 100644 MdePkg/Library/BaseStackCheckLib/BaseStackCheckNull.c -- 2.9.3.windows.2