* [PATCH] ArmVirtPkg: add NOOPT target to platform .DSCs
@ 2017-12-06 11:37 Ard Biesheuvel
2017-12-06 14:14 ` Laszlo Ersek
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2017-12-06 11:37 UTC (permalink / raw)
To: edk2-devel; +Cc: lersek, leif.lindholm, Ard Biesheuvel
In order to allow the ArmVirtPkg platforms to be built using the
NOOPT target, add it explicitly to the BUILD_TARGETS define.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
ArmVirtPkg/ArmVirtQemu.dsc | 2 +-
ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +-
ArmVirtPkg/ArmVirtXen.dsc | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
index f09226671827..76a83b99a303 100644
--- a/ArmVirtPkg/ArmVirtQemu.dsc
+++ b/ArmVirtPkg/ArmVirtQemu.dsc
@@ -25,7 +25,7 @@ [Defines]
DSC_SPECIFICATION = 0x00010005
OUTPUT_DIRECTORY = Build/ArmVirtQemu-$(ARCH)
SUPPORTED_ARCHITECTURES = AARCH64|ARM
- BUILD_TARGETS = DEBUG|RELEASE
+ BUILD_TARGETS = DEBUG|RELEASE|NOOPT
SKUID_IDENTIFIER = DEFAULT
FLASH_DEFINITION = ArmVirtPkg/ArmVirtQemu.fdf
diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
index cc2c5a50c925..7d9a9196d640 100644
--- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
+++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
@@ -25,7 +25,7 @@ [Defines]
DSC_SPECIFICATION = 0x00010005
OUTPUT_DIRECTORY = Build/ArmVirtQemuKernel-$(ARCH)
SUPPORTED_ARCHITECTURES = AARCH64|ARM
- BUILD_TARGETS = DEBUG|RELEASE
+ BUILD_TARGETS = DEBUG|RELEASE|NOOPT
SKUID_IDENTIFIER = DEFAULT
FLASH_DEFINITION = ArmVirtPkg/ArmVirtQemuKernel.fdf
diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc
index 9b3cc2bd5a10..175b56d10c8f 100644
--- a/ArmVirtPkg/ArmVirtXen.dsc
+++ b/ArmVirtPkg/ArmVirtXen.dsc
@@ -25,7 +25,7 @@ [Defines]
DSC_SPECIFICATION = 0x00010005
OUTPUT_DIRECTORY = Build/ArmVirtXen-$(ARCH)
SUPPORTED_ARCHITECTURES = AARCH64|ARM
- BUILD_TARGETS = DEBUG|RELEASE
+ BUILD_TARGETS = DEBUG|RELEASE|NOOPT
SKUID_IDENTIFIER = DEFAULT
FLASH_DEFINITION = ArmVirtPkg/ArmVirtXen.fdf
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmVirtPkg: add NOOPT target to platform .DSCs
2017-12-06 11:37 [PATCH] ArmVirtPkg: add NOOPT target to platform .DSCs Ard Biesheuvel
@ 2017-12-06 14:14 ` Laszlo Ersek
2017-12-06 20:50 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Laszlo Ersek @ 2017-12-06 14:14 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel; +Cc: leif.lindholm
On 12/06/17 12:37, Ard Biesheuvel wrote:
> In order to allow the ArmVirtPkg platforms to be built using the
> NOOPT target, add it explicitly to the BUILD_TARGETS define.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> ArmVirtPkg/ArmVirtQemu.dsc | 2 +-
> ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +-
> ArmVirtPkg/ArmVirtXen.dsc | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index f09226671827..76a83b99a303 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -25,7 +25,7 @@ [Defines]
> DSC_SPECIFICATION = 0x00010005
> OUTPUT_DIRECTORY = Build/ArmVirtQemu-$(ARCH)
> SUPPORTED_ARCHITECTURES = AARCH64|ARM
> - BUILD_TARGETS = DEBUG|RELEASE
> + BUILD_TARGETS = DEBUG|RELEASE|NOOPT
> SKUID_IDENTIFIER = DEFAULT
> FLASH_DEFINITION = ArmVirtPkg/ArmVirtQemu.fdf
>
> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> index cc2c5a50c925..7d9a9196d640 100644
> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> @@ -25,7 +25,7 @@ [Defines]
> DSC_SPECIFICATION = 0x00010005
> OUTPUT_DIRECTORY = Build/ArmVirtQemuKernel-$(ARCH)
> SUPPORTED_ARCHITECTURES = AARCH64|ARM
> - BUILD_TARGETS = DEBUG|RELEASE
> + BUILD_TARGETS = DEBUG|RELEASE|NOOPT
> SKUID_IDENTIFIER = DEFAULT
> FLASH_DEFINITION = ArmVirtPkg/ArmVirtQemuKernel.fdf
>
> diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc
> index 9b3cc2bd5a10..175b56d10c8f 100644
> --- a/ArmVirtPkg/ArmVirtXen.dsc
> +++ b/ArmVirtPkg/ArmVirtXen.dsc
> @@ -25,7 +25,7 @@ [Defines]
> DSC_SPECIFICATION = 0x00010005
> OUTPUT_DIRECTORY = Build/ArmVirtXen-$(ARCH)
> SUPPORTED_ARCHITECTURES = AARCH64|ARM
> - BUILD_TARGETS = DEBUG|RELEASE
> + BUILD_TARGETS = DEBUG|RELEASE|NOOPT
> SKUID_IDENTIFIER = DEFAULT
> FLASH_DEFINITION = ArmVirtPkg/ArmVirtXen.fdf
>
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmVirtPkg: add NOOPT target to platform .DSCs
2017-12-06 14:14 ` Laszlo Ersek
@ 2017-12-06 20:50 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2017-12-06 20:50 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: edk2-devel@lists.01.org, Leif Lindholm
On 6 December 2017 at 14:14, Laszlo Ersek <lersek@redhat.com> wrote:
> On 12/06/17 12:37, Ard Biesheuvel wrote:
>> In order to allow the ArmVirtPkg platforms to be built using the
>> NOOPT target, add it explicitly to the BUILD_TARGETS define.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>> ArmVirtPkg/ArmVirtQemu.dsc | 2 +-
>> ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +-
>> ArmVirtPkg/ArmVirtXen.dsc | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
>> index f09226671827..76a83b99a303 100644
>> --- a/ArmVirtPkg/ArmVirtQemu.dsc
>> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
>> @@ -25,7 +25,7 @@ [Defines]
>> DSC_SPECIFICATION = 0x00010005
>> OUTPUT_DIRECTORY = Build/ArmVirtQemu-$(ARCH)
>> SUPPORTED_ARCHITECTURES = AARCH64|ARM
>> - BUILD_TARGETS = DEBUG|RELEASE
>> + BUILD_TARGETS = DEBUG|RELEASE|NOOPT
>> SKUID_IDENTIFIER = DEFAULT
>> FLASH_DEFINITION = ArmVirtPkg/ArmVirtQemu.fdf
>>
>> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
>> index cc2c5a50c925..7d9a9196d640 100644
>> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
>> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
>> @@ -25,7 +25,7 @@ [Defines]
>> DSC_SPECIFICATION = 0x00010005
>> OUTPUT_DIRECTORY = Build/ArmVirtQemuKernel-$(ARCH)
>> SUPPORTED_ARCHITECTURES = AARCH64|ARM
>> - BUILD_TARGETS = DEBUG|RELEASE
>> + BUILD_TARGETS = DEBUG|RELEASE|NOOPT
>> SKUID_IDENTIFIER = DEFAULT
>> FLASH_DEFINITION = ArmVirtPkg/ArmVirtQemuKernel.fdf
>>
>> diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc
>> index 9b3cc2bd5a10..175b56d10c8f 100644
>> --- a/ArmVirtPkg/ArmVirtXen.dsc
>> +++ b/ArmVirtPkg/ArmVirtXen.dsc
>> @@ -25,7 +25,7 @@ [Defines]
>> DSC_SPECIFICATION = 0x00010005
>> OUTPUT_DIRECTORY = Build/ArmVirtXen-$(ARCH)
>> SUPPORTED_ARCHITECTURES = AARCH64|ARM
>> - BUILD_TARGETS = DEBUG|RELEASE
>> + BUILD_TARGETS = DEBUG|RELEASE|NOOPT
>> SKUID_IDENTIFIER = DEFAULT
>> FLASH_DEFINITION = ArmVirtPkg/ArmVirtXen.fdf
>>
>>
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks. Pushed as 80ee06cee70c
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-06 20:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-06 11:37 [PATCH] ArmVirtPkg: add NOOPT target to platform .DSCs Ard Biesheuvel
2017-12-06 14:14 ` Laszlo Ersek
2017-12-06 20:50 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox