From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Jun Nie <jun.nie@linaro.org>
Subject: Re: [PATCH] EmbeddedPkg: AndroidBootApp: fix clang compilation
Date: Wed, 6 Dec 2017 21:41:10 +0000 [thread overview]
Message-ID: <20171206214110.ecnaztphxipqcghf@bivouac.eciton.net> (raw)
In-Reply-To: <CAKv+Gu-6nsauFWoYB3xNJ52CPm8qTHuEL_XzUUT4Q0U0UyDQ9w@mail.gmail.com>
On Wed, Dec 06, 2017 at 08:36:48PM +0000, Ard Biesheuvel wrote:
> On 6 December 2017 at 20:31, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > Address an incorrect function prototype (using ; instead of ,)
> > in AndroidBootImg.h.
> >
> > Also restructure code slightly to avoid a "may be used uninitialized"
> > warning.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thanks!
Pushed as ac811846f2.
> > ---
> > EmbeddedPkg/Include/Protocol/AndroidBootImg.h | 4 ++--
> > EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c | 9 +++++----
> > 2 files changed, 7 insertions(+), 6 deletions(-)
> >
> > diff --git a/EmbeddedPkg/Include/Protocol/AndroidBootImg.h b/EmbeddedPkg/Include/Protocol/AndroidBootImg.h
> > index 1c458d0255..cd3c42e858 100644
> > --- a/EmbeddedPkg/Include/Protocol/AndroidBootImg.h
> > +++ b/EmbeddedPkg/Include/Protocol/AndroidBootImg.h
> > @@ -33,8 +33,8 @@ EFI_STATUS
> > typedef
> > EFI_STATUS
> > (EFIAPI *ANDROID_BOOTIMG_UPDATE_DTB) (
> > - IN EFI_PHYSICAL_ADDRESS OrigDtbBase;
> > - OUT EFI_PHYSICAL_ADDRESS *NewDtbBase;
> > + IN EFI_PHYSICAL_ADDRESS OrigDtbBase,
> > + OUT EFI_PHYSICAL_ADDRESS *NewDtbBase
> > );
> >
> > struct _ANDROID_BOOTIMG_PROTOCOL {
> > diff --git a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c b/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c
> > index 09c4d924f1..2e50cedf6a 100644
> > --- a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c
> > +++ b/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c
> > @@ -357,12 +357,13 @@ AndroidBootImgUpdateFdt (
> > if (EFI_ERROR (Status)) {
> > goto Fdt_Exit;
> > }
> > +
> > + Status = gBS->InstallConfigurationTable (
> > + &gFdtTableGuid,
> > + (VOID *)(UINTN)NewFdtBase
> > + );
> > }
> >
> > - Status = gBS->InstallConfigurationTable (
> > - &gFdtTableGuid,
> > - (VOID *)(UINTN)NewFdtBase
> > - );
> > if (!EFI_ERROR (Status)) {
> > return EFI_SUCCESS;
> > }
> > --
> > 2.11.0
> >
prev parent reply other threads:[~2017-12-06 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 20:31 [PATCH] EmbeddedPkg: AndroidBootApp: fix clang compilation Leif Lindholm
2017-12-06 20:36 ` Ard Biesheuvel
2017-12-06 21:41 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171206214110.ecnaztphxipqcghf@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox