From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::243; helo=mail-wr0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9A5352217CE23 for ; Wed, 6 Dec 2017 13:36:43 -0800 (PST) Received: by mail-wr0-x243.google.com with SMTP id q9so5397223wre.7 for ; Wed, 06 Dec 2017 13:41:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BenK2TUvnddrLTABJfWX+afSmdvtt4lqU9ld+HDzPxo=; b=Jv4rMh4bbyszBXy2hnQB1w9AcnGdEyQkaDD79yZcdaZicz+uX6NY/L8CcR14k41QFy QS+QEMDr+/iyG2h5R1oWD0kmY+KdJcpcJgtswLO4djk11qul/tA8BH8r4n3JoVLYZe1h Hzwjz+ZWUWmrEnTfthA0KCojXzpAB09SXhOho= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BenK2TUvnddrLTABJfWX+afSmdvtt4lqU9ld+HDzPxo=; b=XdhdC7UW1XsnYt5VRdz0dS7Ws7eP2CjYUamnrcsqN9X8f7Z3OnzuUji+YuouMozSHB 4tnqTxaaHgtaKh/wQC+JkJgbbRTGnrOkV/0TSC0HyFATaPg++3TcN6UqinNgZeNVvRqm BtEEQSq/07K5c+Ga8XP3G26CvK3xJcUy1KnH+AWg84oEHPgro31WMbjSVxQW/G4k+Ze2 NvFdDTcNegxSJdAxChGTbYHEmkFPgVvE2Y6C5piYMTz7tZMPKfTg1chexyq+tHsFi90i Q3ASzWxtNOBZJaKQaNdZPCywiRBGl23aABk+Fi6oOBP6Kf5URG8wvfM8vlr6da5q3nfn lozw== X-Gm-Message-State: AKGB3mLqCox8yiASpc4IMRzpzGmwwR0xD38DyxMO37SiUO+Q/AHW+NT9 uaABbO4dBMQA5/IsIWYp85MCkQ== X-Google-Smtp-Source: AGs4zMZ5JbVMGDwIbFUDnFB2wNe8ZwFmyeYM+LmPapVI/t9dQC5ZJACiitHDGMPyRmSlrkknsxmldg== X-Received: by 10.223.189.135 with SMTP id l7mr134544wrh.231.1512596474142; Wed, 06 Dec 2017 13:41:14 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a203sm3822779wmh.45.2017.12.06.13.41.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Dec 2017 13:41:12 -0800 (PST) Date: Wed, 6 Dec 2017 21:41:10 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Jun Nie Message-ID: <20171206214110.ecnaztphxipqcghf@bivouac.eciton.net> References: <20171206203130.8219-1-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] EmbeddedPkg: AndroidBootApp: fix clang compilation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2017 21:36:44 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 06, 2017 at 08:36:48PM +0000, Ard Biesheuvel wrote: > On 6 December 2017 at 20:31, Leif Lindholm wrote: > > Address an incorrect function prototype (using ; instead of ,) > > in AndroidBootImg.h. > > > > Also restructure code slightly to avoid a "may be used uninitialized" > > warning. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Leif Lindholm > > Reviewed-by: Ard Biesheuvel Thanks! Pushed as ac811846f2. > > --- > > EmbeddedPkg/Include/Protocol/AndroidBootImg.h | 4 ++-- > > EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c | 9 +++++---- > > 2 files changed, 7 insertions(+), 6 deletions(-) > > > > diff --git a/EmbeddedPkg/Include/Protocol/AndroidBootImg.h b/EmbeddedPkg/Include/Protocol/AndroidBootImg.h > > index 1c458d0255..cd3c42e858 100644 > > --- a/EmbeddedPkg/Include/Protocol/AndroidBootImg.h > > +++ b/EmbeddedPkg/Include/Protocol/AndroidBootImg.h > > @@ -33,8 +33,8 @@ EFI_STATUS > > typedef > > EFI_STATUS > > (EFIAPI *ANDROID_BOOTIMG_UPDATE_DTB) ( > > - IN EFI_PHYSICAL_ADDRESS OrigDtbBase; > > - OUT EFI_PHYSICAL_ADDRESS *NewDtbBase; > > + IN EFI_PHYSICAL_ADDRESS OrigDtbBase, > > + OUT EFI_PHYSICAL_ADDRESS *NewDtbBase > > ); > > > > struct _ANDROID_BOOTIMG_PROTOCOL { > > diff --git a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c b/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c > > index 09c4d924f1..2e50cedf6a 100644 > > --- a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c > > +++ b/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c > > @@ -357,12 +357,13 @@ AndroidBootImgUpdateFdt ( > > if (EFI_ERROR (Status)) { > > goto Fdt_Exit; > > } > > + > > + Status = gBS->InstallConfigurationTable ( > > + &gFdtTableGuid, > > + (VOID *)(UINTN)NewFdtBase > > + ); > > } > > > > - Status = gBS->InstallConfigurationTable ( > > - &gFdtTableGuid, > > - (VOID *)(UINTN)NewFdtBase > > - ); > > if (!EFI_ERROR (Status)) { > > return EFI_SUCCESS; > > } > > -- > > 2.11.0 > >