From: Leif Lindholm <leif.lindholm@linaro.org>
To: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: edk2-devel@lists.01.org, Yunhua Feng <yunhuax.feng@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: Re: [PATCH] BaseTools: Fix GenSec can't found the depex file
Date: Thu, 7 Dec 2017 11:29:31 +0000 [thread overview]
Message-ID: <20171207112931.2rp4fy4s4uegba27@bivouac.eciton.net> (raw)
In-Reply-To: <1512629477-12264-1-git-send-email-yonghong.zhu@intel.com>
Hi Yonghong,
This patch resolves the issue for the hikey platform, but not for
(edk2-platforms/Platform/Hisilicon/)D03/D05. They fail with
---
Generating FVMAIN FV
######
########################################
#############################Return Value = 2
GenSec: ERROR 0001: Error opening file
/work/git/tianocore/Build/D03/DEBUG_GCC5/AARCH64/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform/OUTPUT/SnpPlatform.depex
GenSec: ERROR 2000: Status is not successful
---
and
---
Generating FVMAIN FV
######
########################################
########################################
################Return Value = 2
GenSec: ERROR 0001: Error opening file
/work/git/tianocore/Build/D05/RELEASE_GCC5/AARCH64/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform/OUTPUT/SnpPlatform.depex
GenFds.py...
: error 7000: Failed to generate section
GenSec: ERROR 2000: Status is not successful
---
respectively.
Again, reverting 37de70b7 makes the build successful again.
Note that the failing drivers are binary, held in edk2-non-osi.
Regards,
Leif
On Thu, Dec 07, 2017 at 02:51:17PM +0800, Yonghong Zhu wrote:
> From: Yunhua Feng <yunhuax.feng@intel.com>
>
> Filter the FileList when multiple genfds thread options is not enabled.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com>
> ---
> BaseTools/Source/Python/GenFds/EfiSection.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/Python/GenFds/EfiSection.py b/BaseTools/Source/Python/GenFds/EfiSection.py
> index 7b3b717191..4276945a10 100644
> --- a/BaseTools/Source/Python/GenFds/EfiSection.py
> +++ b/BaseTools/Source/Python/GenFds/EfiSection.py
> @@ -92,7 +92,8 @@ class EfiSection (EfiSectionClassObject):
> elif os.path.exists(Filename):
> FileList.append(Filename)
> elif '.depex' in FfsInf.FinalTargetSuffixMap or FfsInf.Depex:
> - FileList.append(Filename)
> + if IsMakefile:
> + FileList.append(Filename)
> else:
> FileList, IsSect = Section.Section.GetFileList(FfsInf, self.FileType, self.FileExtension, Dict)
> if IsSect :
> --
> 2.12.2.windows.2
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2017-12-07 11:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 6:51 [PATCH] BaseTools: Fix GenSec can't found the depex file Yonghong Zhu
2017-12-07 11:29 ` Leif Lindholm [this message]
2017-12-07 12:55 ` Zhu, Yonghong
2017-12-07 14:35 ` Leif Lindholm
2017-12-07 14:42 ` Zhu, Yonghong
2017-12-07 16:01 ` Zhu, Yonghong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207112931.2rp4fy4s4uegba27@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox