From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::242; helo=mail-wr0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 279BE2217CE3E for ; Fri, 8 Dec 2017 06:03:40 -0800 (PST) Received: by mail-wr0-x242.google.com with SMTP id z34so10914523wrz.10 for ; Fri, 08 Dec 2017 06:08:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pKThMgwpDUkyKYABYofQ4SLdyeMJksNMKfL9bvhRIIo=; b=a1yCvL++6Gkow5ShJrZ9CofpJzRfqVEq9f6DqzxQnVSwdEyKM3gHRmo3ZwIWuJ+CIE Z2kL4TOjnm+YR7bU8FyvvfRmX5LDik/dr6mwPl7uswWOPGfQFbBMYTp2G2Pf5MlG9nni tyBrX0rRt/Hk9vm6sWval5/hvF0+9RFMiKdz8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pKThMgwpDUkyKYABYofQ4SLdyeMJksNMKfL9bvhRIIo=; b=bnM5G6rzDHx+82TKr3fFfYKhpCQ/CXg76/R6tllVvEvVMvKvUTnG7VAz1hEMs3sGWR 8/RiODXCWjddkOtJSpjAnOGft8LtHhsafH0ePuq40ZEXJo1qmCO/TFf8yL0JTqZbzD/V hyT4/bUD1H6WFsB9fZzUntY6jX+ZTV1LYOljafNNtGStDVqtDYYxJO5/hdFHslyeyb/J F3/d0T7cttpZW/tTgus+OH8AN1g0uk1QSPEm4xsUyoQKL6TDhQAeWVpNEqMVAwfksQJx bqNzgUQpZrptAGsDDawXMZrmQ5XIxqz+/6kmibTui3xtojMtHxjwQQ4QG+Sbg6uvUhWo hJZg== X-Gm-Message-State: AKGB3mK+4AGY+d1GNU32Ke5yBP2ImpVO4V0dKFzKguvdA4D5EuOmpphu gel4Fqj8/YtOy+BGpNbx1IEQAQ== X-Google-Smtp-Source: AGs4zMZls0nVJa+7e3G6mahjTWwmP6uHuaKQuYk22ESUehmLuGnzEwgws710l9ydC4/RvCm3m/XoEA== X-Received: by 10.223.150.163 with SMTP id u32mr21106391wrb.157.1512742093991; Fri, 08 Dec 2017 06:08:13 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id x133sm1747983wmd.44.2017.12.08.06.08.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Dec 2017 06:08:12 -0800 (PST) Date: Fri, 8 Dec 2017 14:08:11 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: Ard Biesheuvel , "edk2-devel@lists.01.org" , Nadav Haklai , Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , Jan =?utf-8?B?RMSFYnJvxZs=?= , Konrad Adamczyk Message-ID: <20171208140810.454i7j467k24ig5o@bivouac.eciton.net> References: <1512674434-32326-1-git-send-email-mw@semihalf.com> <1512674434-32326-6-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v2 5/5] Marvell/Drivers: Drop 'PciEmulation' naming X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 14:03:41 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 08, 2017 at 01:11:27PM +0100, Marcin Wojtas wrote: > 2017-12-08 9:40 GMT+01:00 Ard Biesheuvel : > > On 7 December 2017 at 23:08, Marcin Wojtas wrote: > >> Hi Ard, > >> > >> 2017-12-07 20:49 GMT+01:00 Ard Biesheuvel : > >>> Hi Marcin, > >>> > >>> On 7 December 2017 at 19:20, Marcin Wojtas wrote: > >>>> 'PciEmulation' is not a proper naming for a driver, which > >>>> uses NonDiscoverableDeviceRegistrationLib for handling > >>>> the devices attached via internal bus of the SoC. > >>>> Rename it to MvNonDiscoverableDxe and move under > >>>> Silicon/Marvell/Drivers directory. > >>>> > >>> > >>> Thank you! > >>> > >>>> Contributed-under: TianoCore Contribution Agreement 1.1 > >>>> Signed-off-by: Marcin Wojtas > >>>> --- > >>>> Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 4 +-- > >>>> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 4 +-- > >>>> Silicon/Marvell/{PciEmulation/PciEmulation.c => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.c} | 26 ++++++++++---------- > >>>> Silicon/Marvell/{PciEmulation/PciEmulation.inf => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.inf} | 8 +++--- > >>>> 4 files changed, 21 insertions(+), 21 deletions(-) > >>>> rename Silicon/Marvell/{PciEmulation/PciEmulation.c => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.c} (84%) > >>>> rename Silicon/Marvell/{PciEmulation/PciEmulation.inf => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.inf} (91%) > >>>> > >>> > >>> Could we please have > >>> > >>> Drivers/MvNonDiscoverableDxe/MvNonDiscoverableDxe.inf > >>> > >>> instead? > >>> > >> > >> My intention was to keep a generic naming at the first level inside > >> the Silicon/Drivers/Marvell: > >> I2c Net SdMmc Spi > >> > >> I can change it in a way you want, but to my taste > >> MvNonDiscoverableDxe doesn't fully fit the company above. Do you see > >> any possible compromise? :) > >> > > > > Well, if you want 'generic' at the level below > > Silicon/Drivers/Marvell, you will still need > > MvNonDiscoverableDxe/MvNonDiscoverableDxe.inf below that. > > > > So > > > > Drivers/NonDiscoverable/MvNonDiscoverableDxe/MvNonDiscoverableDxe.inf > > > > perhaps? > > This is ok to me. As we're bikeshedding... What would be the benefit of the above? I could get Drivers/NonDiscoverable/780xxNonDiscoverableDxe, but surely if you're preparing for Armada 37xx (which I would be very happy to see), having something called MvNonDiscoverableDxe is not going to be very identifying. I don't mind a few extra levels of directories in order to clear up usage, but we do need to actually make use of it then. / Leif