From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH edk2-platforms] Silicon/Socionext/SynQuacer/PlatformDxe: add missing IoLib include
Date: Fri, 8 Dec 2017 14:08:40 +0000 [thread overview]
Message-ID: <20171208140840.tt3cwjoksiuxdhcx@bivouac.eciton.net> (raw)
In-Reply-To: <20171208140158.31371-1-ard.biesheuvel@linaro.org>
On Fri, Dec 08, 2017 at 02:01:58PM +0000, Ard Biesheuvel wrote:
> Commit ce95ec196da0 ("Silicon/SynQuacer: enable coherent DMA for NETSEC
> and eMMC") introduced a call to MmioOr32 into PlatformDxe without adding
> the appropriate #include and LibraryClass references, resulting in build
> failures when attempting to build the SynQuacer platforms. So add them.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Tested-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c | 1 +
> Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
> index 643289131214..e58a2093eb49 100644
> --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
> +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
> @@ -16,6 +16,7 @@
> #include <Library/BaseMemoryLib.h>
> #include <Library/DebugLib.h>
> #include <Library/DtPlatformDtbLoaderLib.h>
> +#include <Library/IoLib.h>
> #include <Library/MemoryAllocationLib.h>
> #include <Library/UefiBootServicesTableLib.h>
> #include <Platform/MemoryMap.h>
> diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
> index 478e0c7d33e9..00c1130906c4 100644
> --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
> +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
> @@ -37,6 +37,7 @@ [LibraryClasses]
> BaseMemoryLib
> DebugLib
> DtPlatformDtbLoaderLib
> + IoLib
> MemoryAllocationLib
> UefiBootServicesTableLib
> UefiDriverEntryPoint
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-12-08 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 14:01 [PATCH edk2-platforms] Silicon/Socionext/SynQuacer/PlatformDxe: add missing IoLib include Ard Biesheuvel
2017-12-08 14:08 ` Leif Lindholm [this message]
2017-12-08 14:14 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208140840.tt3cwjoksiuxdhcx@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox