From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::243; helo=mail-wr0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 590522217CE3E for ; Fri, 8 Dec 2017 06:04:10 -0800 (PST) Received: by mail-wr0-x243.google.com with SMTP id z18so10933418wrb.8 for ; Fri, 08 Dec 2017 06:08:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=r3LzJVjaG9cI7wdetRgyMBm3PM66bAMSYpLQ92Ey/P0=; b=FpHBSqGEPA7a9RjF8DOEWmtKA0j9bvvZUFI49M6scvCO23OrJBPkOA3bv//cepKWjJ UD5MtCDB3+oN/zYzg1F/r7CrtWoFxr49tYEbdMyD/g84JOm4CKse5Mqgg39tiyvcXxCO J6mlJb7njlFeq0EBncMk8zzSDVQfPrttX3Nko= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=r3LzJVjaG9cI7wdetRgyMBm3PM66bAMSYpLQ92Ey/P0=; b=DvbmN11O8yaCT37sQOooGhEz9QVIEUljLhRwoPvQNP6OJ/viAeEOQjU00/QwX53J0m fh0dTaNhS10Wrhs1GLk0hNlo6tz1DUSTRolC8Hd4p9cP7UX3zNyiA6+DBYv25Z6lBKzs lLlb9cK1OcBKGcB75Mux51ktpzLRVAHb8mnSQhAgaurOpcbXNbtU6U6KtbM+WjRU/SbN s6BlSzMi5cN7t26w7B0LBtTw3ptk28x/3A5694ejYGo44suTo8+Urt2Fk4r1xE0yUmR/ 0X0F8ZDVI/ttxmCsCOCMN+SmZs/2fh6u2gD7V0MV3C416ntu3Q2pC7qySoP8JEwPrYXZ JUMw== X-Gm-Message-State: AJaThX5l1hEnoAx8vJa284CA3IV/BQCbHHVvEXFcI5jW8gD1P3wLbgIz fFt/sKIY88y7sr1acWWT01x6rC1GywA= X-Google-Smtp-Source: AGs4zMbjTnr9hJ1kWz4oNHWcEP7VbPYtJ4HBLoy1zA1dhICxBQU1uiyQEIlQjQnpLKYWZ9PJbcq5Qg== X-Received: by 10.223.154.105 with SMTP id z96mr25393516wrb.260.1512742123310; Fri, 08 Dec 2017 06:08:43 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o10sm8593482wrg.5.2017.12.08.06.08.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Dec 2017 06:08:42 -0800 (PST) Date: Fri, 8 Dec 2017 14:08:40 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20171208140840.tt3cwjoksiuxdhcx@bivouac.eciton.net> References: <20171208140158.31371-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171208140158.31371-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms] Silicon/Socionext/SynQuacer/PlatformDxe: add missing IoLib include X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 14:04:10 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 08, 2017 at 02:01:58PM +0000, Ard Biesheuvel wrote: > Commit ce95ec196da0 ("Silicon/SynQuacer: enable coherent DMA for NETSEC > and eMMC") introduced a call to MmioOr32 into PlatformDxe without adding > the appropriate #include and LibraryClass references, resulting in build > failures when attempting to build the SynQuacer platforms. So add them. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm Tested-by: Leif Lindholm > --- > Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c | 1 + > Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c > index 643289131214..e58a2093eb49 100644 > --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c > +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf > index 478e0c7d33e9..00c1130906c4 100644 > --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf > +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf > @@ -37,6 +37,7 @@ [LibraryClasses] > BaseMemoryLib > DebugLib > DtPlatformDtbLoaderLib > + IoLib > MemoryAllocationLib > UefiBootServicesTableLib > UefiDriverEntryPoint > -- > 2.11.0 >