From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::244; helo=mail-wr0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 166FC2217CE47 for ; Fri, 8 Dec 2017 06:19:15 -0800 (PST) Received: by mail-wr0-x244.google.com with SMTP id y21so10994165wrc.1 for ; Fri, 08 Dec 2017 06:23:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LsZdxjFlsZjpRg8n5GRHlimein7yoS1GP80Jt6RwY5o=; b=fhCWmy4T+9WrAC/cUQWVrqAGN3HFuzg7RMm7FG2ifvLoFDnURRp0qunm2UgPbJVJ6X ARIotpf2DZBbqt7ZbkdHHUI+t+O8WEduiDUZN//AIOfTbyqo9k7M44PxtRfh41KxoRSU AOe4trpptvitV1VPeGKbEKLZkfiq97QgSRxAw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LsZdxjFlsZjpRg8n5GRHlimein7yoS1GP80Jt6RwY5o=; b=KYHxqpCd+IOZtuemtX0WIyjLgtYII8H8c5IjV6/Ge/R0zJEP40/4GSzeVI2p4FJt2d E4RAyc6UAhRy84sF6qweDPDoeIgX558cj0s4qloECRtiTUU1OzTlA8XTyrf0nbQDGl4t EfD1IFSfCQh3CEYL9/74FyMuPfiqBrEIz5TmzFEpxdd7XWWv0GfCRpLOcT2NhmTWiRQK OxTAbsIbYGhKuw4vYBLH5ZSuz0ZGpZrpPiZKRBkUv32rmXvpQ60chlZFMTYMJ1bS9Kqs euc2VA+bqu5Oq/vSUI75xiVLj/tkxK01aNThekXAx6lc8S2o6fQEppdRnJwH0n5kWlOR DdYw== X-Gm-Message-State: AKGB3mJ8ns8QgTVP4sGBFsPiExpDwrqgAz+PQihWji+jPgJPpHYeSGRm S83ji6V8cAA7Hst3SwSyXsYfcQ== X-Google-Smtp-Source: AGs4zMaZwfVEOwLFr0rQbLngD13MWokWzjuy7I0DSnULgdXXE6Vg+8gax8boA4Da/cTrX9BHcf3ZCw== X-Received: by 10.223.184.125 with SMTP id u58mr21836469wrf.33.1512743028692; Fri, 08 Dec 2017 06:23:48 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y84sm1685307wmg.39.2017.12.08.06.23.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Dec 2017 06:23:47 -0800 (PST) Date: Fri, 8 Dec 2017 14:23:45 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: Ard Biesheuvel , "edk2-devel@lists.01.org" , Nadav Haklai , Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , Jan =?utf-8?B?RMSFYnJvxZs=?= , Konrad Adamczyk Message-ID: <20171208142345.pdr4kmvmadnb6zxh@bivouac.eciton.net> References: <1512674434-32326-1-git-send-email-mw@semihalf.com> <1512674434-32326-6-git-send-email-mw@semihalf.com> <20171208140810.454i7j467k24ig5o@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v2 5/5] Marvell/Drivers: Drop 'PciEmulation' naming X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 14:19:16 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 08, 2017 at 03:13:54PM +0100, Marcin Wojtas wrote: > Hi Leif, > > 2017-12-08 15:08 GMT+01:00 Leif Lindholm : > > On Fri, Dec 08, 2017 at 01:11:27PM +0100, Marcin Wojtas wrote: > >> 2017-12-08 9:40 GMT+01:00 Ard Biesheuvel : > >> > On 7 December 2017 at 23:08, Marcin Wojtas wrote: > >> >> Hi Ard, > >> >> > >> >> 2017-12-07 20:49 GMT+01:00 Ard Biesheuvel : > >> >>> Hi Marcin, > >> >>> > >> >>> On 7 December 2017 at 19:20, Marcin Wojtas wrote: > >> >>>> 'PciEmulation' is not a proper naming for a driver, which > >> >>>> uses NonDiscoverableDeviceRegistrationLib for handling > >> >>>> the devices attached via internal bus of the SoC. > >> >>>> Rename it to MvNonDiscoverableDxe and move under > >> >>>> Silicon/Marvell/Drivers directory. > >> >>>> > >> >>> > >> >>> Thank you! > >> >>> > >> >>>> Contributed-under: TianoCore Contribution Agreement 1.1 > >> >>>> Signed-off-by: Marcin Wojtas > >> >>>> --- > >> >>>> Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 4 +-- > >> >>>> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 4 +-- > >> >>>> Silicon/Marvell/{PciEmulation/PciEmulation.c => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.c} | 26 ++++++++++---------- > >> >>>> Silicon/Marvell/{PciEmulation/PciEmulation.inf => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.inf} | 8 +++--- > >> >>>> 4 files changed, 21 insertions(+), 21 deletions(-) > >> >>>> rename Silicon/Marvell/{PciEmulation/PciEmulation.c => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.c} (84%) > >> >>>> rename Silicon/Marvell/{PciEmulation/PciEmulation.inf => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.inf} (91%) > >> >>>> > >> >>> > >> >>> Could we please have > >> >>> > >> >>> Drivers/MvNonDiscoverableDxe/MvNonDiscoverableDxe.inf > >> >>> > >> >>> instead? > >> >>> > >> >> > >> >> My intention was to keep a generic naming at the first level inside > >> >> the Silicon/Drivers/Marvell: > >> >> I2c Net SdMmc Spi > >> >> > >> >> I can change it in a way you want, but to my taste > >> >> MvNonDiscoverableDxe doesn't fully fit the company above. Do you see > >> >> any possible compromise? :) > >> >> > >> > > >> > Well, if you want 'generic' at the level below > >> > Silicon/Drivers/Marvell, you will still need > >> > MvNonDiscoverableDxe/MvNonDiscoverableDxe.inf below that. > >> > > >> > So > >> > > >> > Drivers/NonDiscoverable/MvNonDiscoverableDxe/MvNonDiscoverableDxe.inf > >> > > >> > perhaps? > >> > >> This is ok to me. > > > > As we're bikeshedding... > > > > What would be the benefit of the above? > > > > I could get Drivers/NonDiscoverable/780xxNonDiscoverableDxe, but > > surely if you're preparing for Armada 37xx (which I would be very > > happy to see), having something called MvNonDiscoverableDxe is not > > going to be very identifying. > > Well, I think we will most likely reuse this driver as is - on A37xx there is > generic AHCI/XHCI and even same Xenon driver. So, are you fine with > what I initially added in this patch > (Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.c, etc.), > or you wish to use Drivers/MvNonDiscoverableDxe/MvNonDiscoverableDxe.c, etc? I'm more on the Drivers/MvNonDiscoverableDxe/MvNonDiscoverableDxe.c side of the fence in that case. NonDiscoverableDevices suggests there will be multiple. (That said, there is no need for the Mv prefix if it's under a Marvell directory.) Regards, Leif