From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH 4/5] ArmPlatformPkg: add Null implementation of NorFlashPlatformLib
Date: Fri, 8 Dec 2017 16:07:03 +0000 [thread overview]
Message-ID: <20171208160703.znbgwsk7m22ds53y@bivouac.eciton.net> (raw)
In-Reply-To: <20171205101326.23732-5-ard.biesheuvel@linaro.org>
On Tue, Dec 05, 2017 at 10:13:25AM +0000, Ard Biesheuvel wrote:
> In order to be able to build ArmPlatformPkg components outside of
> the context of a particular platform, add Null implementation of
> NorFlashPlatformLib.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Question/comment:
Not only ARM Ltd. platforms implement this API.
Would it be worth moving this (as well as
ArmPlatformPkg/Include/Library/NorFlashPlatformLib.h) into EmbeddedPkg
and actually documenting the inputs/outputs?
/
Leif
> ---
> ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.c | 34 ++++++++++++++++++++
> ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.inf | 30 +++++++++++++++++
> 2 files changed, 64 insertions(+)
>
> diff --git a/ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.c b/ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.c
> new file mode 100644
> index 000000000000..264d18719763
> --- /dev/null
> +++ b/ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.c
> @@ -0,0 +1,34 @@
> +/** @file
> +
> + Copyright (c) 2014, Linaro Ltd. All rights reserved.<BR>
> +
> + This program and the accompanying materials
> + are licensed and made available under the terms and conditions of the BSD License
> + which accompanies this distribution. The full text of the license may be found at
> + http://opensource.org/licenses/bsd-license.php
> +
> + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +
> + **/
> +
> +#include <Library/NorFlashPlatformLib.h>
> +
> +EFI_STATUS
> +NorFlashPlatformInitialization (
> + VOID
> + )
> +{
> + return EFI_SUCCESS;
> +}
> +
> +EFI_STATUS
> +NorFlashPlatformGetDevices (
> + OUT NOR_FLASH_DESCRIPTION **NorFlashDescriptions,
> + OUT UINT32 *Count
> + )
> +{
> + *NorFlashDescriptions = NULL;
> + *Count = 0;
> + return EFI_SUCCESS;
> +}
> diff --git a/ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.inf b/ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.inf
> new file mode 100644
> index 000000000000..777a629678e1
> --- /dev/null
> +++ b/ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.inf
> @@ -0,0 +1,30 @@
> +#/** @file
> +#
> +# Component description file for NorFlashPlatformNullLib module
> +#
> +# Copyright (c) 2017, Linaro Ltd. All rights reserved.<BR>
> +#
> +# This program and the accompanying materials
> +# are licensed and made available under the terms and conditions of the BSD License
> +# which accompanies this distribution. The full text of the license may be found at
> +# http://opensource.org/licenses/bsd-license.php
> +#
> +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +#
> +#**/
> +
> +[Defines]
> + INF_VERSION = 0x00010005
> + BASE_NAME = NorFlashPlatformNullLib
> + FILE_GUID = 29b733ad-d066-4df6-8a89-b9df1beb818a
> + MODULE_TYPE = DXE_DRIVER
> + VERSION_STRING = 1.0
> + LIBRARY_CLASS = NorFlashPlatformLib
> +
> +[Sources.common]
> + NorFlashPlatformNullLib.c
> +
> +[Packages]
> + MdePkg/MdePkg.dec
> + ArmPlatformPkg/ArmPlatformPkg.dec
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-12-08 16:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 10:13 [PATCH 0/5] ArmPlatformPkg: create standalone .dsc file Ard Biesheuvel
2017-12-05 10:13 ` [PATCH 1/5] ArmPlatformPkg: remove unused ArmPlatformLibNullSec Ard Biesheuvel
2017-12-05 10:13 ` [PATCH 2/5] ArmPlatformPkg/PrePeiCoreMPCore: use a unique GUID Ard Biesheuvel
2017-12-05 10:13 ` [PATCH 3/5] ArmPlatformPkg: add Null implementation of LcdPlatformlLib Ard Biesheuvel
2017-12-05 10:13 ` [PATCH 4/5] ArmPlatformPkg: add Null implementation of NorFlashPlatformLib Ard Biesheuvel
2017-12-08 16:07 ` Leif Lindholm [this message]
2017-12-08 16:13 ` Ard Biesheuvel
2017-12-08 16:17 ` Leif Lindholm
2017-12-05 10:13 ` [PATCH 5/5] ArmPlatformPkg: add package .DSC file Ard Biesheuvel
2017-12-08 16:19 ` Leif Lindholm
2017-12-08 16:35 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208160703.znbgwsk7m22ds53y@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox