From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::22f; helo=mail-wm0-x22f.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com [IPv6:2a00:1450:400c:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0ED1F2217CE55 for ; Fri, 8 Dec 2017 08:12:39 -0800 (PST) Received: by mail-wm0-x22f.google.com with SMTP id f206so3964916wmf.5 for ; Fri, 08 Dec 2017 08:17:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XlC0zbUMgy4r6rp5nXdLBLdUCyvuJE4PqmR8TPZ90/4=; b=NAKk0LUtG1kZNfj6hF+yLVDXmGifoIZP7EN7xb55r7XG62fHW/oA3cV2d8jgjrBxGu sjVubSLliiMMcR8KWAvojh+sfFcYvmbL8uqphfCmoi9iV+UTzC8rASbO3jtsFeQgamrz Vt54YhMphIei+lCeTL034Z6jbx+he7Ro12w4g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XlC0zbUMgy4r6rp5nXdLBLdUCyvuJE4PqmR8TPZ90/4=; b=BIYisfgjNQIMFVyP9eIM8/HDgjzo+w4ul2f7Vg0ZpTd1ituQFpPjlgYCQ83vU2OeF9 yrJOjYkqW2RMIZASjwNFkH6JyEXiIpdaAXtU0ej7rQByDfBQ1qBzYASX/sbJOywLWs+d ddLbCQaqo1dB87Un1h0qj6CCc4rKsMVdtyKXLMroSAfhGqwYkRefkX2Hywvsfarv6XD6 /yTmOFWyKcTkzpcf7WP4GfAT9HIYC9HKZQILcrPQ+43oLSzL9SdpQzikXoScMoLoz7Yt gCUgF3UOezy7e8s4OzZTigBCk6sLUFBwyDZIpi3ATJPnVQd76y1uhOZ+R/746lhriyKt sveA== X-Gm-Message-State: AKGB3mJKT1DHORIBtnSCCyJOuGjNBIe/HgJez+jbx77khF59TqxsGRPB eJoHS2nEmEvcspZnNE600LeU2BYjY+I= X-Google-Smtp-Source: ACJfBovZ8Wdii2xKeXFVcwkPFTsREBOTYnFQc2ui4e7ItLmcda91XZlzixaOZAtOovL0vsIk9Pxk9A== X-Received: by 10.28.18.80 with SMTP id 77mr155180wms.109.1512749831907; Fri, 08 Dec 2017 08:17:11 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d1sm8431898wra.44.2017.12.08.08.17.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Dec 2017 08:17:10 -0800 (PST) Date: Fri, 8 Dec 2017 16:17:09 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" Message-ID: <20171208161709.td77dhjqborylpg3@bivouac.eciton.net> References: <20171205101326.23732-1-ard.biesheuvel@linaro.org> <20171205101326.23732-5-ard.biesheuvel@linaro.org> <20171208160703.znbgwsk7m22ds53y@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 4/5] ArmPlatformPkg: add Null implementation of NorFlashPlatformLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 16:12:39 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 08, 2017 at 04:13:10PM +0000, Ard Biesheuvel wrote: > On 8 December 2017 at 16:07, Leif Lindholm wrote: > > On Tue, Dec 05, 2017 at 10:13:25AM +0000, Ard Biesheuvel wrote: > >> In order to be able to build ArmPlatformPkg components outside of > >> the context of a particular platform, add Null implementation of > >> NorFlashPlatformLib. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Ard Biesheuvel > > > > Question/comment: > > Not only ARM Ltd. platforms implement this API. > > Would it be worth moving this (as well as > > ArmPlatformPkg/Include/Library/NorFlashPlatformLib.h) into EmbeddedPkg > > and actually documenting the inputs/outputs? > > I'd rather move away from the monolithical NOR flash drivers derived > from ArmPlatformPkg/Drivers/NorFlashDxe, and move to split SPI host > controller drivers and a generic SPI NOR flash driver based on > NorFlashInfoLib. That's a rather sizable chunk of work, though, and > I'm not sure when this will ever get done or by whom. Sure. I'd complain if you were trying to move it into edk2-platforms/Platform/ARM, but leaving this in ArmPlatformPkg seems ok for a non-specified transitional period. / Leif