Re: [PATCH] MdePkg/Uefi ARM: only support native ARM/Thumb images

[Leif Lindholm <leif.lindholm@linaro.org>]

On Fri, Dec 08, 2017 at 03:55:14PM +0000, Ard Biesheuvel wrote:
> The ARM calling convention is fundamentally incompatible with EBC,
> and having a cross compatible machine type identical to the native
> type does not make a lot of sense either. So restrict the compatible
> machine type for ARM to EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, and remove
> the cross compatible.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Looks reasonable.
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  MdePkg/Include/Uefi/UefiBaseType.h | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/MdePkg/Include/Uefi/UefiBaseType.h b/MdePkg/Include/Uefi/UefiBaseType.h
> index 728a0472602a..d9556cd2ec4e 100644
> --- a/MdePkg/Include/Uefi/UefiBaseType.h
> +++ b/MdePkg/Include/Uefi/UefiBaseType.h
> @@ -270,10 +270,9 @@ typedef union {
>  
>  #elif defined (MDE_CPU_ARM)
>  
> -#define EFI_IMAGE_MACHINE_TYPE_SUPPORTED(Machine) \
> -  (((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED) || ((Machine) == EFI_IMAGE_MACHINE_EBC))
> +#define EFI_IMAGE_MACHINE_TYPE_SUPPORTED(Machine) ((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED)
>  
> -#define EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED(Machine) ((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED) 
> +#define EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED(Machine) (FALSE)
>  
>  #elif defined (MDE_CPU_AARCH64)
>  
> -- 
> 2.11.0
>