From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 390E12217CE53 for ; Fri, 8 Dec 2017 08:53:17 -0800 (PST) Received: by mail-wm0-x243.google.com with SMTP id f9so4219824wmh.0 for ; Fri, 08 Dec 2017 08:57:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Mg+z+RADxdOYxw22Do8SVOIo80RqC0ypJP+7JOl7sNc=; b=M5fWjpKtDqfHCM0gZJVas4NQlgUbM10qrPY3P0lkvwbak8sv8gonkPcZVTX3O862pr BKE+JpxVNG3WQzK43MsauWKyMjvE0c2e1s2wMP6g1sWHhDew/4mN11hySA6dquAI3MuR o3YqXEi+md7n+/kUICnBQg6KjpRCs6joOhdrg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Mg+z+RADxdOYxw22Do8SVOIo80RqC0ypJP+7JOl7sNc=; b=n9sqdhOg9r7wBfs/yo9DmimWZzSuZc3cvUfDq3hsLtwczNLatL9XJPrbtykTsfC+kx eP8+91bHbS+sc9v9thKCxSRt38SwlgRFKvE2/Zj1gUEJG/uL8mX/TQyXDvOWNpbea4WV 17w2O2/UqZFTx7cTXW8N79CVKatuYllnAeZqtu35tKrKn/O3PE5lHIwIZuGEBPc6HUDI tSxo6bLKXUZQVLVY+z4you5iwZ2sgcobnFmaDLVMGsSlKl0FiPlhyrsVALDg2De3nBNs DjzJj39ZtHYb6upAPCFlc15bap6mnW9FcTKrxOf2ZoyT0E2I8jQ4Pfxg6FyrQWKZFyhH Kz/Q== X-Gm-Message-State: AKGB3mLgCZpa5quvKlyGVSkplxgJQf1GilUUGCkH+XGewBUu1av3CgmV quvAOijYIsk2uk1hyWMxG5GOTw== X-Google-Smtp-Source: AGs4zMZ8wlPDmHGr1drw8m2YcIxLNF8bFtSy3L60ZF8OWCwG3g7mTfYeI2FEl2WrvLeVxKc0Efww+A== X-Received: by 10.28.125.85 with SMTP id y82mr4068095wmc.25.1512752271086; Fri, 08 Dec 2017 08:57:51 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f69sm2108540wmi.46.2017.12.08.08.57.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Dec 2017 08:57:50 -0800 (PST) Date: Fri, 8 Dec 2017 16:57:48 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, michael.d.kinney@intel.com, liming.gao@intel.com Message-ID: <20171208165748.lvdqnjwjg6at4fgk@bivouac.eciton.net> References: <20171208155514.18926-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171208155514.18926-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] MdePkg/Uefi ARM: only support native ARM/Thumb images X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 16:53:18 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 08, 2017 at 03:55:14PM +0000, Ard Biesheuvel wrote: > The ARM calling convention is fundamentally incompatible with EBC, > and having a cross compatible machine type identical to the native > type does not make a lot of sense either. So restrict the compatible > machine type for ARM to EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, and remove > the cross compatible. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Looks reasonable. Reviewed-by: Leif Lindholm > --- > MdePkg/Include/Uefi/UefiBaseType.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/MdePkg/Include/Uefi/UefiBaseType.h b/MdePkg/Include/Uefi/UefiBaseType.h > index 728a0472602a..d9556cd2ec4e 100644 > --- a/MdePkg/Include/Uefi/UefiBaseType.h > +++ b/MdePkg/Include/Uefi/UefiBaseType.h > @@ -270,10 +270,9 @@ typedef union { > > #elif defined (MDE_CPU_ARM) > > -#define EFI_IMAGE_MACHINE_TYPE_SUPPORTED(Machine) \ > - (((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED) || ((Machine) == EFI_IMAGE_MACHINE_EBC)) > +#define EFI_IMAGE_MACHINE_TYPE_SUPPORTED(Machine) ((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED) > > -#define EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED(Machine) ((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED) > +#define EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED(Machine) (FALSE) > > #elif defined (MDE_CPU_AARCH64) > > -- > 2.11.0 >