* [PATCH] ArmPlatformPkg/LcdPlatformNullLib: fix incorrect library class
@ 2017-12-08 17:10 Ard Biesheuvel
2017-12-08 19:11 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2017-12-08 17:10 UTC (permalink / raw)
To: edk2-devel; +Cc: leif.lindholm, Ard Biesheuvel
Use LcdPlatformLib not LcdPlatformNullLib (which is the name of this
instance) as LIBRARY_CLASS attribute.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
index 41c1d9638812..2cec9b970b5b 100644
--- a/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
+++ b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
@@ -18,7 +18,7 @@ [Defines]
FILE_GUID = b78d02bb-d0b5-4389-bc7f-b39ee846c784
MODULE_TYPE = BASE
VERSION_STRING = 1.0
- LIBRARY_CLASS = LcdPlatformNullLib
+ LIBRARY_CLASS = LcdPlatformLib
[Sources]
LcdPlatformNullLib.c
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmPlatformPkg/LcdPlatformNullLib: fix incorrect library class
2017-12-08 17:10 [PATCH] ArmPlatformPkg/LcdPlatformNullLib: fix incorrect library class Ard Biesheuvel
@ 2017-12-08 19:11 ` Leif Lindholm
2017-12-08 19:38 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2017-12-08 19:11 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel
On Fri, Dec 08, 2017 at 05:10:51PM +0000, Ard Biesheuvel wrote:
> Use LcdPlatformLib not LcdPlatformNullLib (which is the name of this
> instance) as LIBRARY_CLASS attribute.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Ah, oops.
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
> index 41c1d9638812..2cec9b970b5b 100644
> --- a/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
> +++ b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
> @@ -18,7 +18,7 @@ [Defines]
> FILE_GUID = b78d02bb-d0b5-4389-bc7f-b39ee846c784
> MODULE_TYPE = BASE
> VERSION_STRING = 1.0
> - LIBRARY_CLASS = LcdPlatformNullLib
> + LIBRARY_CLASS = LcdPlatformLib
>
> [Sources]
> LcdPlatformNullLib.c
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmPlatformPkg/LcdPlatformNullLib: fix incorrect library class
2017-12-08 19:11 ` Leif Lindholm
@ 2017-12-08 19:38 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2017-12-08 19:38 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel@lists.01.org
On 8 December 2017 at 19:11, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Fri, Dec 08, 2017 at 05:10:51PM +0000, Ard Biesheuvel wrote:
>> Use LcdPlatformLib not LcdPlatformNullLib (which is the name of this
>> instance) as LIBRARY_CLASS attribute.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Ah, oops.
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Thanks. Pushed as a5be96819fb66b5ce7a5251b6680c71b2dd459c1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-08 19:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-08 17:10 [PATCH] ArmPlatformPkg/LcdPlatformNullLib: fix incorrect library class Ard Biesheuvel
2017-12-08 19:11 ` Leif Lindholm
2017-12-08 19:38 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox