From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH] ArmPlatformPkg/LcdPlatformNullLib: fix incorrect library class
Date: Fri, 8 Dec 2017 19:11:31 +0000 [thread overview]
Message-ID: <20171208191131.c4b2igyih3t73lkv@bivouac.eciton.net> (raw)
In-Reply-To: <20171208171051.21184-1-ard.biesheuvel@linaro.org>
On Fri, Dec 08, 2017 at 05:10:51PM +0000, Ard Biesheuvel wrote:
> Use LcdPlatformLib not LcdPlatformNullLib (which is the name of this
> instance) as LIBRARY_CLASS attribute.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Ah, oops.
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
> index 41c1d9638812..2cec9b970b5b 100644
> --- a/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
> +++ b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
> @@ -18,7 +18,7 @@ [Defines]
> FILE_GUID = b78d02bb-d0b5-4389-bc7f-b39ee846c784
> MODULE_TYPE = BASE
> VERSION_STRING = 1.0
> - LIBRARY_CLASS = LcdPlatformNullLib
> + LIBRARY_CLASS = LcdPlatformLib
>
> [Sources]
> LcdPlatformNullLib.c
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-12-08 19:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 17:10 [PATCH] ArmPlatformPkg/LcdPlatformNullLib: fix incorrect library class Ard Biesheuvel
2017-12-08 19:11 ` Leif Lindholm [this message]
2017-12-08 19:38 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208191131.c4b2igyih3t73lkv@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox