From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::232; helo=mail-wm0-x232.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 682BA2214E322 for ; Mon, 11 Dec 2017 03:43:30 -0800 (PST) Received: by mail-wm0-x232.google.com with SMTP id g130so12866094wme.0 for ; Mon, 11 Dec 2017 03:48:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vKt+fuyq/bEIZgwIBH1GbxKa2np8N09YX+RbmNA4MUA=; b=KCG9saaUWSqGUXGr27o1rvNpSKb0v8PfqTHBUznei5QqYl2ExtmxIv9LcS9XTCh+ET qCnYTxWEYayqYSVzWD6ADNx+FlRTk3b8no372XHEAkf+ezMlJpeGBQ8L6g5CkXTlEmnG EPnhGAARUGFwopiEeAS2NPYge942qohD8imj4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vKt+fuyq/bEIZgwIBH1GbxKa2np8N09YX+RbmNA4MUA=; b=E5zE553I/k8wHLuE91tvtNcrPBPMm2Rfxy/wsc9iRfld2G4ZbQWmqRU4ux7rqHCN0v l/UC1x2ctymahgIXZBaUiCQpqK/vkJNN6QqEs/FQaIE3ksGFuV2OEXUIOEQNsPopXMNi VXsS5H+kDmeBBu1o+43NZrLUNvxMEdSYL2vcsYjCGUINM+FrWPPNyiKO60RPcxGd3ywo GFjxzl+zqE7HN8QweWrynkHk8nItJ/XLC1pG2xro/W+907vXlP079jJyaJKvYd7jaIti ogXRopDl38OfZftFLR1S0vK3lQp83dEtG8kUmPERvO0kouMx7aIidR6hUziYeeLJZc3M gvAQ== X-Gm-Message-State: AKGB3mJL0uTrvxAzoclgh9vkezhFKBFPy+hTvHgvc+J9im+Tr8TmGDsQ tR1bwXPWJ+qxCP80wIvMm4I3DYN9LtM= X-Google-Smtp-Source: ACJfBoteRJ8no84KXjyv+rWfG++pSFJiTtYzXDRZ13nH6UePdbKxnxTvSYd7vQqmeJCjI3qQuEt3YQ== X-Received: by 10.28.149.203 with SMTP id x194mr522734wmd.145.1512992885721; Mon, 11 Dec 2017 03:48:05 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id c54sm18376056wra.84.2017.12.11.03.48.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Dec 2017 03:48:04 -0800 (PST) Date: Mon, 11 Dec 2017 11:48:03 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20171211114802.43vrwz7kqtxnavxz@bivouac.eciton.net> References: <20171209095624.20915-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171209095624.20915-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] ArmPkg/PlatformBootManagerLib: add missing newline X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 11:43:30 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Dec 09, 2017 at 09:56:24AM +0000, Ard Biesheuvel wrote: > Add a missing newline to the version string output that is displayed > on the serial console, or the next line will be appended to it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > index ccdb3e0a5d78..61ab61ccc780 100644 > --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > @@ -549,7 +549,7 @@ PlatformBootManagerAfterConsole ( > Status = BootLogoEnableLogo (); > if (EFI_ERROR (Status)) { > if (FirmwareVerLength > 0) { > - Print (VERSION_STRING_PREFIX L"%s", > + Print (VERSION_STRING_PREFIX L"%s\n", > PcdGetPtr (PcdFirmwareVersionString)); > } > Print (L"Press ESCAPE for boot options "); > -- > 2.11.0 >