* [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error @ 2017-12-12 12:46 Laszlo Ersek 2017-12-12 12:54 ` Yao, Jiewen 0 siblings, 1 reply; 4+ messages in thread From: Laszlo Ersek @ 2017-12-12 12:46 UTC (permalink / raw) To: edk2-devel-01; +Cc: Eric Dong, Star Zeng > MdeModulePkg/Core/PiSmmCore/PiSmmCore.c: In function > 'SmmReadyToBootHandler': > MdeModulePkg/Core/PiSmmCore/PiSmmCore.c:323:14: error: passing argument > 3 of 'SmmLocateProtocol' from incompatible pointer type [-Werror] > ); > ^ > In file included from MdeModulePkg/Core/PiSmmCore/PiSmmCore.c:15:0: > MdeModulePkg/Core/PiSmmCore/PiSmmCore.h:586:1: note: expected 'void **' > but argument is of type 'struct EFI_SMM_SX_DISPATCH2_PROTOCOL **' > SmmLocateProtocol ( > ^ > cc1: all warnings being treated as errors Cc: Eric Dong <eric.dong@intel.com> Cc: Star Zeng <star.zeng@intel.com> Fixes: 7b9b55b2ef7be13608605dc58a54b9ca04be4e40 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek <lersek@redhat.com> --- MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c index dbb89932e75b..1ccb9c7787ad 100644 --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c @@ -319,7 +319,7 @@ SmmReadyToBootHandler ( Status = SmmLocateProtocol ( &gEfiSmmSxDispatch2ProtocolGuid, NULL, - &SxDispatch + (VOID **)&SxDispatch ); if (!EFI_ERROR (Status)) { // -- 2.14.1.3.gb7cf6e02401b ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error 2017-12-12 12:46 [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error Laszlo Ersek @ 2017-12-12 12:54 ` Yao, Jiewen 2017-12-12 13:10 ` Laszlo Ersek 0 siblings, 1 reply; 4+ messages in thread From: Yao, Jiewen @ 2017-12-12 12:54 UTC (permalink / raw) To: Laszlo Ersek, edk2-devel-01; +Cc: Dong, Eric, Zeng, Star Thanks ,Laszlo. Reviewed-by: Jiewen.yao@intel.com Since it breaks the build, can we check in as soon as possible? Thank you Yao Jiewen > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, December 12, 2017 8:47 PM > To: edk2-devel-01 <edk2-devel@lists.01.org> > Cc: Dong, Eric <eric.dong@intel.com>; Zeng, Star <star.zeng@intel.com> > Subject: [edk2] [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error > > > MdeModulePkg/Core/PiSmmCore/PiSmmCore.c: In function > > 'SmmReadyToBootHandler': > > MdeModulePkg/Core/PiSmmCore/PiSmmCore.c:323:14: error: passing > argument > > 3 of 'SmmLocateProtocol' from incompatible pointer type [-Werror] > > ); > > ^ > > In file included from MdeModulePkg/Core/PiSmmCore/PiSmmCore.c:15:0: > > MdeModulePkg/Core/PiSmmCore/PiSmmCore.h:586:1: note: expected 'void > **' > > but argument is of type 'struct EFI_SMM_SX_DISPATCH2_PROTOCOL **' > > SmmLocateProtocol ( > > ^ > > cc1: all warnings being treated as errors > > Cc: Eric Dong <eric.dong@intel.com> > Cc: Star Zeng <star.zeng@intel.com> > Fixes: 7b9b55b2ef7be13608605dc58a54b9ca04be4e40 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek <lersek@redhat.com> > --- > MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c > b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c > index dbb89932e75b..1ccb9c7787ad 100644 > --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c > +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c > @@ -319,7 +319,7 @@ SmmReadyToBootHandler ( > Status = SmmLocateProtocol ( > &gEfiSmmSxDispatch2ProtocolGuid, > NULL, > - &SxDispatch > + (VOID **)&SxDispatch > ); > if (!EFI_ERROR (Status)) { > // > -- > 2.14.1.3.gb7cf6e02401b > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error 2017-12-12 12:54 ` Yao, Jiewen @ 2017-12-12 13:10 ` Laszlo Ersek 2017-12-13 0:35 ` Zeng, Star 0 siblings, 1 reply; 4+ messages in thread From: Laszlo Ersek @ 2017-12-12 13:10 UTC (permalink / raw) To: Yao, Jiewen, edk2-devel-01; +Cc: Dong, Eric, Zeng, Star On 12/12/17 13:54, Yao, Jiewen wrote: > Thanks ,Laszlo. > Reviewed-by: Jiewen.yao@intel.com Thanks! > Since it breaks the build, can we check in as soon as possible? Sure; commit dfc5a4dec602. Thanks! Laszlo >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo >> Ersek >> Sent: Tuesday, December 12, 2017 8:47 PM >> To: edk2-devel-01 <edk2-devel@lists.01.org> >> Cc: Dong, Eric <eric.dong@intel.com>; Zeng, Star <star.zeng@intel.com> >> Subject: [edk2] [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error >> >>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c: In function >>> 'SmmReadyToBootHandler': >>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c:323:14: error: passing >> argument >>> 3 of 'SmmLocateProtocol' from incompatible pointer type [-Werror] >>> ); >>> ^ >>> In file included from MdeModulePkg/Core/PiSmmCore/PiSmmCore.c:15:0: >>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.h:586:1: note: expected 'void >> **' >>> but argument is of type 'struct EFI_SMM_SX_DISPATCH2_PROTOCOL **' >>> SmmLocateProtocol ( >>> ^ >>> cc1: all warnings being treated as errors >> >> Cc: Eric Dong <eric.dong@intel.com> >> Cc: Star Zeng <star.zeng@intel.com> >> Fixes: 7b9b55b2ef7be13608605dc58a54b9ca04be4e40 >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Laszlo Ersek <lersek@redhat.com> >> --- >> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> index dbb89932e75b..1ccb9c7787ad 100644 >> --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> @@ -319,7 +319,7 @@ SmmReadyToBootHandler ( >> Status = SmmLocateProtocol ( >> &gEfiSmmSxDispatch2ProtocolGuid, >> NULL, >> - &SxDispatch >> + (VOID **)&SxDispatch >> ); >> if (!EFI_ERROR (Status)) { >> // >> -- >> 2.14.1.3.gb7cf6e02401b >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error 2017-12-12 13:10 ` Laszlo Ersek @ 2017-12-13 0:35 ` Zeng, Star 0 siblings, 0 replies; 4+ messages in thread From: Zeng, Star @ 2017-12-13 0:35 UTC (permalink / raw) To: Laszlo Ersek, Yao, Jiewen, edk2-devel-01; +Cc: Dong, Eric, Zeng, Star Thanks for the fix. Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek Sent: Tuesday, December 12, 2017 9:10 PM To: Yao, Jiewen <jiewen.yao@intel.com>; edk2-devel-01 <edk2-devel@lists.01.org> Cc: Dong, Eric <eric.dong@intel.com>; Zeng, Star <star.zeng@intel.com> Subject: Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error On 12/12/17 13:54, Yao, Jiewen wrote: > Thanks ,Laszlo. > Reviewed-by: Jiewen.yao@intel.com Thanks! > Since it breaks the build, can we check in as soon as possible? Sure; commit dfc5a4dec602. Thanks! Laszlo >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf >> Of Laszlo Ersek >> Sent: Tuesday, December 12, 2017 8:47 PM >> To: edk2-devel-01 <edk2-devel@lists.01.org> >> Cc: Dong, Eric <eric.dong@intel.com>; Zeng, Star >> <star.zeng@intel.com> >> Subject: [edk2] [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error >> >>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c: In function >>> 'SmmReadyToBootHandler': >>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c:323:14: error: passing >> argument >>> 3 of 'SmmLocateProtocol' from incompatible pointer type [-Werror] >>> ); >>> ^ >>> In file included from MdeModulePkg/Core/PiSmmCore/PiSmmCore.c:15:0: >>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.h:586:1: note: expected 'void >> **' >>> but argument is of type 'struct EFI_SMM_SX_DISPATCH2_PROTOCOL **' >>> SmmLocateProtocol ( >>> ^ >>> cc1: all warnings being treated as errors >> >> Cc: Eric Dong <eric.dong@intel.com> >> Cc: Star Zeng <star.zeng@intel.com> >> Fixes: 7b9b55b2ef7be13608605dc58a54b9ca04be4e40 >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Laszlo Ersek <lersek@redhat.com> >> --- >> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> index dbb89932e75b..1ccb9c7787ad 100644 >> --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> @@ -319,7 +319,7 @@ SmmReadyToBootHandler ( >> Status = SmmLocateProtocol ( >> &gEfiSmmSxDispatch2ProtocolGuid, >> NULL, >> - &SxDispatch >> + (VOID **)&SxDispatch >> ); >> if (!EFI_ERROR (Status)) { >> // >> -- >> 2.14.1.3.gb7cf6e02401b >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-13 0:30 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-12-12 12:46 [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error Laszlo Ersek 2017-12-12 12:54 ` Yao, Jiewen 2017-12-12 13:10 ` Laszlo Ersek 2017-12-13 0:35 ` Zeng, Star
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox