From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5D35621A1099A for ; Tue, 12 Dec 2017 10:19:44 -0800 (PST) Received: by mail-wm0-x244.google.com with SMTP id 9so476917wme.4 for ; Tue, 12 Dec 2017 10:24:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=S2Z8Dscmc+1ptPp6k09E3vzOc/MmJ05b0aIPjFDIu9g=; b=ZBGr3Wgp2Ln3SSpsJ9zt6rS7UYJYowSjKM58W7QQHG4kmGqEoWmlIHPmFdwI8Ni9B1 G935cOrB6njIWAl2KW+wQc3mOV8EBK6IvsltS1NPeFRPkXT68FYC4NLEXILYsl0RV1T3 oLSzJKBkreBqw28tktgtEoexIIdSoXVN9vpTM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=S2Z8Dscmc+1ptPp6k09E3vzOc/MmJ05b0aIPjFDIu9g=; b=grgcDzXNuywnodskuYZ/ZipeVncerktSMUJAjclCPF0OISm0dMu+rRhogDkIpMbxHW UItg67SvBeM6T0T4qisMBYsjMi9Fm+dVWqTpJYfSjQGkP9mfBRFJDwpi8xIhQbOJKjS7 sVTVCF7j4RNLCYSwwRthuYUr6q8W8gQH3iHLEAZNs/bnmrNz+ObjipqXybpTLPZEBfVC f6wzJBfSB4phydaUDJ6ArvDiSrmM/AzQ4al9+w0ErEHVvEOXmYVpPwhrUDGHhfYKNCq2 PigIbLd/DqDBZFm2yu0zle2Hh/MDMuo9ahbEr4/Z4hnxhQCzcB5W47EzU7jOHlvXjZ7k 5pAw== X-Gm-Message-State: AKGB3mJoHtvJBxiKTIqOLC4E8/CX0Pjo3SfkwxIO3w0f/6A9MpPhOzVJ 2IEesw1pIhEzpIfzSPv2EMTT6vRDRDE= X-Google-Smtp-Source: ACJfBou282nKVvUFgslG8ADTVuKnyU3U7sruc84kWRRimbap45laVFbJk09aoW8uvOndF8OFc2ic5w== X-Received: by 10.28.105.90 with SMTP id e87mr2475211wmc.35.1513103061962; Tue, 12 Dec 2017 10:24:21 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e197sm302645wmf.42.2017.12.12.10.24.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Dec 2017 10:24:20 -0800 (PST) Date: Tue, 12 Dec 2017 18:24:19 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Daniel Thompson , Masami Hiramatsu Message-ID: <20171212182419.fxaftkg2oj6cmt4m@bivouac.eciton.net> References: <20171212103807.18836-1-ard.biesheuvel@linaro.org> <20171212103807.18836-3-ard.biesheuvel@linaro.org> <20171212181719.bp4g56wdcnt56vtj@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 2/8] Platform/Socionext/SynQuacer: expose build number as firmware version X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 18:19:44 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 12, 2017 at 06:20:00PM +0000, Ard Biesheuvel wrote: > On 12 December 2017 at 18:17, Leif Lindholm wrote: > > On Tue, Dec 12, 2017 at 10:38:01AM +0000, Ard Biesheuvel wrote: > >> Expose the contents of the .DSC macro BUILD_NUMBER via the > >> PCD gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString (if > 1), > >> and as the FMP system firmware version (for capsule update). > >> > >> Also, set the firmware vendor to 'Linaro Enterprise Group', to > >> distinguish our builds from builds by other parties. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Ard Biesheuvel > >> --- > >> Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 8 +++++++- > >> Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf | 1 + > >> Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc | 6 ++++-- > >> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 8 +++++++- > >> Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf | 1 + > >> Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc | 6 ++++-- > >> 6 files changed, 24 insertions(+), 6 deletions(-) > >> > >> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > >> index 8fbd7b2d908f..5ec26f9cdd34 100644 > >> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > >> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > >> @@ -26,6 +26,7 @@ [Defines] > >> BUILD_TARGETS = DEBUG|RELEASE > >> SKUID_IDENTIFIER = DEFAULT > >> FLASH_DEFINITION = Platform/Socionext/DeveloperBox/DeveloperBox.fdf > >> + BUILD_NUMBER = 1 > >> > >> [BuildOptions] > >> RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 > >> @@ -222,7 +223,7 @@ [PcdsFeatureFlag] > >> gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE > >> > >> [PcdsFixedAtBuild.common] > >> - gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"Linaro" > >> + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|L"Linaro Enterprise Group" > > > > Actually, could you just delete this Pcd and let it fall back to the > > default value of "EDK II"? > > > > Yes. But perhaps it makes sense to put $(FW_VENDOR) in there if it is > defined, so we can set it at build time? I would like to have a way to > put something in the FirmwareVendor field in the UEFI system table > that can help us identify firmware builds done by Linaro. Sure, that makes sense. Although we already have FIRMWARE_VER for similar purposes, so something to match that name? I.e. FIRMWARE_VENDOR. / Leif