From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH edk2-platforms v3 0/2] ArmPlatformPkg PCD cleanup
Date: Tue, 12 Dec 2017 19:13:20 +0000 [thread overview]
Message-ID: <20171212191320.ih6ux6ug4v3q2rl2@bivouac.eciton.net> (raw)
In-Reply-To: <20171212190747.15742-1-ard.biesheuvel@linaro.org>
On Tue, Dec 12, 2017 at 07:07:45PM +0000, Ard Biesheuvel wrote:
> Remove lots and lots of PCD assignments of obsolete PCDs that are about
> to be removed from ArmPlatformPkg.
For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> v3: Don't replace instances of gArmPlatformTokenSpaceGuid.PcdFirmwareVendor
> with gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor. First of all, the
> latter expects a Unicode string, but blindly replacing them would result
> in user visible changes in the firmware vendor reported by the OS.
> Instead, replace the only meaningful reference with a dedicated new PCD
> (for fastboot), and just drop all other assignments.
> Patch #2 is therefore modified as well, so I dropped Leif's R-b
>
> Ard Biesheuvel (2):
> Platform/ARM/VExpressPkg: use dedicated PCD for fastboot product name
> Platform Silicon: remove obsolete ArmPlatformPkg PCD assignments
>
> Platform/ARM/JunoPkg/ArmJuno.dsc | 13 -------------
> Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 3 ---
> Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 15 +--------------
> Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 17 -----------------
> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 10 ----------
> Platform/ARM/VExpressPkg/ArmVExpressPkg.dec | 1 +
> Platform/ARM/VExpressPkg/Drivers/ArmVExpressFastBootDxe/ArmVExpressFastBoot.c | 2 +-
> Platform/ARM/VExpressPkg/Drivers/ArmVExpressFastBootDxe/ArmVExpressFastBootDxe.inf | 2 +-
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf | 1 -
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf | 1 -
> Platform/Hisilicon/D02/Pv660D02.dsc | 20 --------------------
> Platform/Hisilicon/D03/D03.dsc | 20 --------------------
> Platform/Hisilicon/D05/D05.dsc | 12 ------------
> Platform/Hisilicon/HiKey/HiKey.dsc | 1 -
> Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLib.inf | 1 -
> Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf | 1 -
> Silicon/Hisilicon/Hisilicon.dsc.inc | 14 --------------
> Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.inf | 1 -
> Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf | 1 -
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 5 -----
> 20 files changed, 4 insertions(+), 137 deletions(-)
>
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-12-12 19:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 19:07 [PATCH edk2-platforms v3 0/2] ArmPlatformPkg PCD cleanup Ard Biesheuvel
2017-12-12 19:07 ` [PATCH edk2-platforms v3 1/2] Platform/ARM/VExpressPkg: use dedicated PCD for fastboot product name Ard Biesheuvel
2017-12-12 19:07 ` [PATCH edk2-platforms v3 2/2] Platform Silicon: remove obsolete ArmPlatformPkg PCD assignments Ard Biesheuvel
2017-12-12 19:13 ` Leif Lindholm [this message]
2017-12-12 19:16 ` [PATCH edk2-platforms v3 0/2] ArmPlatformPkg PCD cleanup Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171212191320.ih6ux6ug4v3q2rl2@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox