[staging/DynamicTables] What about edk2-platforms.

[staging/DynamicTables] What about edk2-platforms.

[Evan Lloyd]

We are about to submit a new (ACPI 6.2) version of Sami's Dynamic Tables module.
As suggested in previous threads, the aim is to submit it to edk2-staging.
To that end, following the instructions at https://github.com/tianocore/edk2-staging/blob/about/README
(paragraph 4 a) "Maintainer sends patch email to edk2-devel", we need to generate a patch.

The problem is that the patch involves modules in both edk2 and edk2-platforms.
What is the best strategy to use for that scenario?
Is there any plan to have an edk2-platforms-staging?
If not, we could roll the bits of platforms into edk2-staging, but that may engender problems later.
Does anyone have any advice on how best to handle this, please?

Regards,
Evan
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [staging/DynamicTables] What about edk2-platforms.

[Kinney, Michael D]

Evan,

This is a good question.

Another staging repo is possible, but may not be required.

You could add the platform content to edk2-staging and get 
everything working using that content.  When edk2-staging 
is ready for truck, you need to create the patches for
the edk2 and edk2-platforms repos for review and commit.
I think you can use filter-branch to extract the patch
sets for each repo.

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Evan Lloyd
> Sent: Thursday, December 14, 2017 10:38 AM
> To: edk2-devel (edk2-devel@lists.01.org) <edk2-
> devel@lists.01.org>; Leif Lindholm
> <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Subject: [edk2] [staging/DynamicTables] What about
> edk2-platforms.
> 
> We are about to submit a new (ACPI 6.2) version of
> Sami's Dynamic Tables module.
> As suggested in previous threads, the aim is to submit
> it to edk2-staging.
> To that end, following the instructions at
> https://github.com/tianocore/edk2-
> staging/blob/about/README
> (paragraph 4 a) "Maintainer sends patch email to edk2-
> devel", we need to generate a patch.
> 
> The problem is that the patch involves modules in both
> edk2 and edk2-platforms.
> What is the best strategy to use for that scenario?
> Is there any plan to have an edk2-platforms-staging?
> If not, we could roll the bits of platforms into edk2-
> staging, but that may engender problems later.
> Does anyone have any advice on how best to handle this,
> please?
> 
> Regards,
> Evan
> IMPORTANT NOTICE: The contents of this email and any
> attachments are confidential and may also be
> privileged. If you are not the intended recipient,
> please notify the sender immediately and do not
> disclose the contents to any other person, use it for
> any purpose, or store or copy the information in any
> medium. Thank you.
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: [staging/DynamicTables] What about edk2-platforms.

[Ard Biesheuvel]

On 15 December 2017 at 02:43, Kinney, Michael D
<michael.d.kinney@intel.com> wrote:
> Evan,
>
> This is a good question.
>
> Another staging repo is possible, but may not be required.
>
> You could add the platform content to edk2-staging and get
> everything working using that content.  When edk2-staging
> is ready for truck, you need to create the patches for
> the edk2 and edk2-platforms repos for review and commit.
> I think you can use filter-branch to extract the patch
> sets for each repo.
>

I don't think that is workable, if I understand Evan's use case correctly.

The feature implementation will likely consist of core feature code
(intended for edk2), and changes to existing platform code in
edk2-platforms to make use of it. The only way to add this to
edk2-staging is to import the entire platform from edk2-platforms to
live alongside the EDK2 packages and layer the platform changes on
top.

>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-
>> bounces@lists.01.org] On Behalf Of Evan Lloyd
>> Sent: Thursday, December 14, 2017 10:38 AM
>> To: edk2-devel (edk2-devel@lists.01.org) <edk2-
>> devel@lists.01.org>; Leif Lindholm
>> <leif.lindholm@linaro.org>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Subject: [edk2] [staging/DynamicTables] What about
>> edk2-platforms.
>>
>> We are about to submit a new (ACPI 6.2) version of
>> Sami's Dynamic Tables module.
>> As suggested in previous threads, the aim is to submit
>> it to edk2-staging.
>> To that end, following the instructions at
>> https://github.com/tianocore/edk2-
>> staging/blob/about/README
>> (paragraph 4 a) "Maintainer sends patch email to edk2-
>> devel", we need to generate a patch.
>>
>> The problem is that the patch involves modules in both
>> edk2 and edk2-platforms.
>> What is the best strategy to use for that scenario?
>> Is there any plan to have an edk2-platforms-staging?
>> If not, we could roll the bits of platforms into edk2-
>> staging, but that may engender problems later.
>> Does anyone have any advice on how best to handle this,
>> please?
>>
>> Regards,
>> Evan
>> IMPORTANT NOTICE: The contents of this email and any
>> attachments are confidential and may also be
>> privileged. If you are not the intended recipient,
>> please notify the sender immediately and do not
>> disclose the contents to any other person, use it for
>> any purpose, or store or copy the information in any
>> medium. Thank you.
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel

Re: [staging/DynamicTables] What about edk2-platforms.

[Leif Lindholm]

On Thu, Dec 14, 2017 at 06:38:14PM +0000, Evan Lloyd wrote:
> We are about to submit a new (ACPI 6.2) version of Sami's Dynamic Tables module.
> As suggested in previous threads, the aim is to submit it to edk2-staging.
> To that end, following the instructions at https://github.com/tianocore/edk2-staging/blob/about/README
> (paragraph 4 a) "Maintainer sends patch email to edk2-devel", we need to generate a patch.
> 
> The problem is that the patch involves modules in both edk2 and edk2-platforms.
> What is the best strategy to use for that scenario?
> Is there any plan to have an edk2-platforms-staging?
> If not, we could roll the bits of platforms into edk2-staging, but that may engender problems later.
> Does anyone have any advice on how best to handle this, please?

As a third responder, I feel obliged to offer a third opinion.

My instinctive reaction is to set up a devel-dynamictables branch in
edk2-platforms, that rebases periodically on master and maintains
alignment as required with the edk2-staging branch.

/
    Leif

Re: [staging/DynamicTables] What about edk2-platforms.

[Kinney, Michael D]

I like this idea the best. 

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Leif Lindholm
> Sent: Friday, December 15, 2017 5:12 AM
> To: Evan Lloyd <Evan.Lloyd@arm.com>
> Cc: edk2-devel (edk2-devel@lists.01.org) <edk2-
> devel@lists.01.org>; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>
> Subject: Re: [edk2] [staging/DynamicTables] What about
> edk2-platforms.
> 
> On Thu, Dec 14, 2017 at 06:38:14PM +0000, Evan Lloyd
> wrote:
> > We are about to submit a new (ACPI 6.2) version of
> Sami's Dynamic Tables module.
> > As suggested in previous threads, the aim is to
> submit it to edk2-staging.
> > To that end, following the instructions at
> https://github.com/tianocore/edk2-
> staging/blob/about/README
> > (paragraph 4 a) "Maintainer sends patch email to
> edk2-devel", we need to generate a patch.
> >
> > The problem is that the patch involves modules in
> both edk2 and edk2-platforms.
> > What is the best strategy to use for that scenario?
> > Is there any plan to have an edk2-platforms-staging?
> > If not, we could roll the bits of platforms into
> edk2-staging, but that may engender problems later.
> > Does anyone have any advice on how best to handle
> this, please?
> 
> As a third responder, I feel obliged to offer a third
> opinion.
> 
> My instinctive reaction is to set up a devel-
> dynamictables branch in
> edk2-platforms, that rebases periodically on master and
> maintains
> alignment as required with the edk2-staging branch.
> 
> /
>     Leif
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel