From: Leif Lindholm <leif.lindholm@linaro.org>
To: edk2-devel@lists.01.org
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <liming.gao@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Star Zeng <star.zeng@intel.com>, Eric Dong <eric.dong@intel.com>
Subject: [PATCH v2 0/3] Use central definitions for EFI_VARIABLE_*
Date: Fri, 15 Dec 2017 16:59:22 +0000 [thread overview]
Message-ID: <20171215165925.12306-1-leif.lindholm@linaro.org> (raw)
The set of variable attribute definitions in <Uefi/UefiMultiPhase.h> is
used by C code, but VfrCompile does not seem happy with parts of that
header file.
Long-term, this should probably be fixed in VfrCompile, but a simple
solution for now is to conditionalise the complicating segments of
UefiMultiPhase.h on !VFRCOMPILE and include this directly in .vfr source.
v1 -> v2:
Instead of breaking parts of UefiMultiPhase.h out into a new header,
conditionalise the problematic bits on !VFRCOMPILE.
Leaving out the reviewed-bys on 2/3 since the underlying mechanism
changes...
Leif Lindholm (3):
MdePkg: restrict UefiMultiPhase.h contents if VFRCOMPILE defined
MdeModulePkg: use central variable definitions in DriverSampleDxe
EmbeddedPkg: use central variable definitions in .vfr files
EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefHii.vfr | 9 +---
EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformHii.vfr | 9 +---
MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr | 9 +---
MdePkg/Include/Uefi/UefiMultiPhase.h | 44 ++++++++++----------
4 files changed, 26 insertions(+), 45 deletions(-)
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
--
2.11.0
next reply other threads:[~2017-12-15 16:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 16:59 Leif Lindholm [this message]
2017-12-15 16:59 ` [PATCH v2 1/3] MdePkg: restrict UefiMultiPhase.h contents if VFRCOMPILE defined Leif Lindholm
2017-12-17 11:23 ` Zeng, Star
2018-02-22 20:09 ` Leif Lindholm
2018-02-23 2:33 ` Zeng, Star
2018-02-23 10:25 ` Gao, Liming
2018-02-23 14:24 ` Leif Lindholm
2018-02-23 11:40 ` Leif Lindholm
2017-12-15 16:59 ` [PATCH v2 2/3] MdeModulePkg: use central variable definitions in DriverSampleDxe Leif Lindholm
2017-12-17 11:20 ` Zeng, Star
2017-12-15 16:59 ` [PATCH v2 3/3] EmbeddedPkg: use central variable definitions in .vfr files Leif Lindholm
2018-02-22 16:33 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215165925.12306-1-leif.lindholm@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox