From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 01A6222280C2D for ; Wed, 27 Dec 2017 00:00:35 -0800 (PST) Received: by mail-wm0-x242.google.com with SMTP id b199so38278857wme.1 for ; Wed, 27 Dec 2017 00:05:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=0ysqrXjXKdnUSwkX/38m+tULMFd7/zIXX93wAlv5tTE=; b=JtDcSd/TPtQiMRIPA52q7bpTIEijNcUk8WsBHuKhxMuxyCo02OuYHz6ISAGwS4/C1y Z9YaDEPrgBwT1jln1umWdPWqtdHykY0U8ULrZCfEpDMnsZBrxNu1aly6CJ6Qj4v12yJX gK2g5vMZqnJGOyCpAMEJ6lRWj0we81KHB2eGg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=0ysqrXjXKdnUSwkX/38m+tULMFd7/zIXX93wAlv5tTE=; b=YiPYCGoNKrfE3RdSPdlf8dcWNnIZZBDWAqV2nUJUJpWSp8TXjJ078pq0+z8dLfxRCe nmI2RppoH30iLPk/i4ZAtFtdP/OITE7Y++2gogybkX3tF9k0Wizd8+zMjaR57YJCTnAD Sbz+pSkfrjXO0HlQtm+w0X3+WtnULJHhj2K7cmfU0LhURoeQvsptzbEYSp8PZCSUMo5v vDye70ZEMVj5VnNRsKtBCJA8pXTTfWK4WyLgSrRJNPKHTfSoDpGNsZ2UZLF6tSsc2H1I XsE3TVCzep+ziEMZ1Ys+2QmUm4gcGhCFwnPSJE7Bw8dfMcS9aXcEk8KpH/o2JNj8RTeg ZZ3Q== X-Gm-Message-State: AKGB3mIzzubZdBEfxAgByuglS0hVggs5nft6HW3wJoBBNngX178Y+nVu 6yC7TM+Thb1JLg1sG6qY9bFbstr7cqU= X-Google-Smtp-Source: ACJfBou1Ohdjk1UWRMZNMrVHH/eYKUndYINpWvlBmbPp2/45I5eYzTJeVFdNsOYBk1kAAnPjZwhSwQ== X-Received: by 10.28.183.132 with SMTP id h126mr24617705wmf.17.1514361929230; Wed, 27 Dec 2017 00:05:29 -0800 (PST) Received: from localhost.localdomain ([105.137.110.132]) by smtp.gmail.com with ESMTPSA id f4sm42370255wra.75.2017.12.27.00.05.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Dec 2017 00:05:28 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org, qin.long@intel.com, ting.ye@intel.com Cc: Ard Biesheuvel Date: Wed, 27 Dec 2017 08:05:22 +0000 Message-Id: <20171227080522.10388-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.11.0 Subject: [PATCH] CryptoPkg/OpensslLib AARCH64: suppress format string warning X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Dec 2017 08:00:36 -0000 On GCC Build: openssl-1.1.0g introduced one additional build warning: ...\openssl\crypto\asn1\x_int64.c:105:32: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'int64_t {aka long long int}' [-Werror=format=] return BIO_printf(out, "%"BIO_PRI64"d\n", **(int64_t **)pval); ^ Add "-Wno-error=format" to GCC build flags to suppress this warning, since we have no real printf usage in BaseCryptLib, and BIO_printf() was already wrapped as a dummy implementation in CryptoPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +- CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Library/OpensslLib/OpensslLib.inf index 5302ad7fb5ef..602953eefff7 100644 --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf @@ -560,7 +560,7 @@ [BuildOptions] GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format -DNO_MSABI_VA_FUNCS GCC:*_*_IPF_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) - GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) + GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=format # suppress the following warnings in openssl so we don't break the build with warnings-as-errors: # 1295: Deprecated declaration - give arg types diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf index 0c7f9e9e66f4..f697243f9787 100644 --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf @@ -521,7 +521,7 @@ [BuildOptions] GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format -DNO_MSABI_VA_FUNCS GCC:*_*_IPF_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) - GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) + GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=format # suppress the following warnings in openssl so we don't break the build with warnings-as-errors: # 1295: Deprecated declaration - give arg types -- 2.11.0