* [Patch 0/4] Update source file as DOS format @ 2017-12-27 15:23 Liming Gao 2017-12-27 15:23 ` [Patch 1/4] IntelFspWrapperPkg: Convert INF file to dos format Liming Gao ` (3 more replies) 0 siblings, 4 replies; 8+ messages in thread From: Liming Gao @ 2017-12-27 15:23 UTC (permalink / raw) To: edk2-devel Liming Gao (4): IntelFspWrapperPkg: Convert INF file to dos format NetworkPkg: Convert source file to DOS format SourceLevelDebugPkg: Convert source file to DOS format SecurityPkg: Convert source file to DOS format .../PeiFspWrapperApiTestLib.inf | 2 +- NetworkPkg/HttpDxe/HttpProto.c | 2 +- .../SecureBootConfigDxe/SecureBootConfigImpl.c | 26 +++++++++++----------- .../SecPeiDebugAgent/SecPeiDebugAgentLib.c | 4 ++-- 4 files changed, 17 insertions(+), 17 deletions(-) -- 2.11.0.windows.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Patch 1/4] IntelFspWrapperPkg: Convert INF file to dos format 2017-12-27 15:23 [Patch 0/4] Update source file as DOS format Liming Gao @ 2017-12-27 15:23 ` Liming Gao [not found] ` <4A89E2EF3DFEDB4C8BFDE51014F606A14E199C4B@SHSMSX104.ccr.corp.intel.com> 2017-12-27 15:23 ` [Patch 2/4] NetworkPkg: Convert source file to DOS format Liming Gao ` (2 subsequent siblings) 3 siblings, 1 reply; 8+ messages in thread From: Liming Gao @ 2017-12-27 15:23 UTC (permalink / raw) To: edk2-devel; +Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao <liming.gao@intel.com> Cc: Jiewen Yao <jiewen.yao@intel.com> --- .../Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTestLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTestLib.inf b/IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTestLib.inf index 4d2cbd850f..865a0205d6 100644 --- a/IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTestLib.inf +++ b/IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTestLib.inf @@ -53,4 +53,4 @@ HobLib [Guids] - gFspBootLoaderTolumHobGuid ## SOMETIMES_CONSUMES ## GUID \ No newline at end of file + gFspBootLoaderTolumHobGuid ## SOMETIMES_CONSUMES ## GUID -- 2.11.0.windows.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
[parent not found: <4A89E2EF3DFEDB4C8BFDE51014F606A14E199C4B@SHSMSX104.ccr.corp.intel.com>]
* Re: [Patch 1/4] IntelFspWrapperPkg: Convert INF file to dos format [not found] ` <4A89E2EF3DFEDB4C8BFDE51014F606A14E199C4B@SHSMSX104.ccr.corp.intel.com> @ 2017-12-28 3:26 ` Yao, Jiewen 0 siblings, 0 replies; 8+ messages in thread From: Yao, Jiewen @ 2017-12-28 3:26 UTC (permalink / raw) To: Gao, Liming, edk2-devel@lists.01.org Reviewed-by: Jiewen.yao@intel.com > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming > Gao > Sent: Wednesday, December 27, 2017 11:23 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen.yao@intel.com> > Subject: [edk2] [Patch 1/4] IntelFspWrapperPkg: Convert INF file to dos format > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao <liming.gao@intel.com> > Cc: Jiewen Yao <jiewen.yao@intel.com> > --- > .../Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTestLib.inf | 2 > +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTes > tLib.inf > b/IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTes > tLib.inf > index 4d2cbd850f..865a0205d6 100644 > --- > a/IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTes > tLib.inf > +++ > b/IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTes > tLib.inf > @@ -53,4 +53,4 @@ > HobLib > > [Guids] > - gFspBootLoaderTolumHobGuid ## SOMETIMES_CONSUMES ## > GUID > \ No newline at end of file > + gFspBootLoaderTolumHobGuid ## SOMETIMES_CONSUMES ## > GUID > -- > 2.11.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Patch 2/4] NetworkPkg: Convert source file to DOS format 2017-12-27 15:23 [Patch 0/4] Update source file as DOS format Liming Gao 2017-12-27 15:23 ` [Patch 1/4] IntelFspWrapperPkg: Convert INF file to dos format Liming Gao @ 2017-12-27 15:23 ` Liming Gao 2017-12-28 0:38 ` Wu, Jiaxin 2017-12-27 15:23 ` [Patch 3/4] SourceLevelDebugPkg: " Liming Gao 2017-12-27 15:23 ` [Patch 4/4] SecurityPkg: " Liming Gao 3 siblings, 1 reply; 8+ messages in thread From: Liming Gao @ 2017-12-27 15:23 UTC (permalink / raw) To: edk2-devel; +Cc: Wu Jiaxin Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao <liming.gao@intel.com> Cc: Wu Jiaxin <jiaxin.wu@intel.com> --- NetworkPkg/HttpDxe/HttpProto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c index 925281a9c0..d7fe271168 100644 --- a/NetworkPkg/HttpDxe/HttpProto.c +++ b/NetworkPkg/HttpDxe/HttpProto.c @@ -867,7 +867,7 @@ HttpCleanProtocol ( if (HttpInstance->TlsSb != NULL && HttpInstance->TlsChildHandle != NULL) { // // Destroy the TLS instance. - // + // HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, HttpInstance->TlsChildHandle); } -- 2.11.0.windows.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Patch 2/4] NetworkPkg: Convert source file to DOS format 2017-12-27 15:23 ` [Patch 2/4] NetworkPkg: Convert source file to DOS format Liming Gao @ 2017-12-28 0:38 ` Wu, Jiaxin 0 siblings, 0 replies; 8+ messages in thread From: Wu, Jiaxin @ 2017-12-28 0:38 UTC (permalink / raw) To: Gao, Liming, edk2-devel@lists.01.org Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com> > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Liming Gao > Sent: Wednesday, December 27, 2017 11:23 PM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin <jiaxin.wu@intel.com> > Subject: [edk2] [Patch 2/4] NetworkPkg: Convert source file to DOS format > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao <liming.gao@intel.com> > Cc: Wu Jiaxin <jiaxin.wu@intel.com> > --- > NetworkPkg/HttpDxe/HttpProto.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/NetworkPkg/HttpDxe/HttpProto.c > b/NetworkPkg/HttpDxe/HttpProto.c > index 925281a9c0..d7fe271168 100644 > --- a/NetworkPkg/HttpDxe/HttpProto.c > +++ b/NetworkPkg/HttpDxe/HttpProto.c > @@ -867,7 +867,7 @@ HttpCleanProtocol ( > if (HttpInstance->TlsSb != NULL && HttpInstance->TlsChildHandle != NULL) { > // > // Destroy the TLS instance. > - // > + // > HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, HttpInstance- > >TlsChildHandle); > } > > -- > 2.11.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Patch 3/4] SourceLevelDebugPkg: Convert source file to DOS format 2017-12-27 15:23 [Patch 0/4] Update source file as DOS format Liming Gao 2017-12-27 15:23 ` [Patch 1/4] IntelFspWrapperPkg: Convert INF file to dos format Liming Gao 2017-12-27 15:23 ` [Patch 2/4] NetworkPkg: Convert source file to DOS format Liming Gao @ 2017-12-27 15:23 ` Liming Gao 2017-12-27 15:23 ` [Patch 4/4] SecurityPkg: " Liming Gao 3 siblings, 0 replies; 8+ messages in thread From: Liming Gao @ 2017-12-27 15:23 UTC (permalink / raw) To: edk2-devel; +Cc: Wu Hao A Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao <liming.gao@intel.com> Cc: Wu Hao A <hao.a.wu@intel.com> --- .../Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c index 9a827ef4db..9f5223a695 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c +++ b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c @@ -32,7 +32,7 @@ GLOBAL_REMOVE_IF_UNREFERENCED EFI_PEI_PPI_DESCRIPTOR mVectorHandoffInf } }; -GLOBAL_REMOVE_IF_UNREFERENCED EFI_PEI_NOTIFY_DESCRIPTOR mDebugAgentMemoryDiscoveredNotifyList[1] = { +GLOBAL_REMOVE_IF_UNREFERENCED EFI_PEI_NOTIFY_DESCRIPTOR mDebugAgentMemoryDiscoveredNotifyList[1] = { { (EFI_PEI_PPI_DESCRIPTOR_NOTIFY_CALLBACK | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST), &gEfiPeiMemoryDiscoveredPpiGuid, @@ -554,7 +554,7 @@ InitializeDebugAgent ( // Register for a callback once memory has been initialized. // If memery has been ready, the callback funtion will be invoked immediately // - Status = PeiServicesNotifyPpi (&mDebugAgentMemoryDiscoveredNotifyList[0]); + Status = PeiServicesNotifyPpi (&mDebugAgentMemoryDiscoveredNotifyList[0]); if (EFI_ERROR (Status)) { DEBUG ((EFI_D_ERROR, "DebugAgent: Failed to register memory discovered callback function!\n")); CpuDeadLoop (); -- 2.11.0.windows.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Patch 4/4] SecurityPkg: Convert source file to DOS format 2017-12-27 15:23 [Patch 0/4] Update source file as DOS format Liming Gao ` (2 preceding siblings ...) 2017-12-27 15:23 ` [Patch 3/4] SourceLevelDebugPkg: " Liming Gao @ 2017-12-27 15:23 ` Liming Gao 2017-12-28 1:56 ` Zhang, Chao B 3 siblings, 1 reply; 8+ messages in thread From: Liming Gao @ 2017-12-27 15:23 UTC (permalink / raw) To: edk2-devel; +Cc: Qin Long Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao <liming.gao@intel.com> Cc: Qin Long <qin.long@intel.com> --- .../SecureBootConfigDxe/SecureBootConfigImpl.c | 26 +++++++++++----------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c index 4ec0f8d13a..e3066f77be 100644 --- a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c +++ b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c @@ -3145,9 +3145,9 @@ DeleteSignatureEx ( if (DelType == Delete_Signature_List_All) { VariableDataSize = 0; } else { - // - // Traverse to target EFI_SIGNATURE_LIST but others will be skipped. - // + // + // Traverse to target EFI_SIGNATURE_LIST but others will be skipped. + // while ((RemainingSize > 0) && (RemainingSize >= ListWalker->SignatureListSize) && ListIndex < PrivateData->ListIndex) { CopyMem ((UINT8 *)NewVariableData + Offset, ListWalker, ListWalker->SignatureListSize); Offset += ListWalker->SignatureListSize; @@ -3157,17 +3157,17 @@ DeleteSignatureEx ( ListIndex++; } - // - // Handle the target EFI_SIGNATURE_LIST. - // If CheckedCount == SIGNATURE_DATA_COUNTS (ListWalker) or DelType == Delete_Signature_List_One - // it means delete the whole EFI_SIGNATURE_LIST, So we just skip this EFI_SIGNATURE_LIST. - // - if (CheckedCount < SIGNATURE_DATA_COUNTS (ListWalker) && DelType == Delete_Signature_Data) { + // + // Handle the target EFI_SIGNATURE_LIST. + // If CheckedCount == SIGNATURE_DATA_COUNTS (ListWalker) or DelType == Delete_Signature_List_One + // it means delete the whole EFI_SIGNATURE_LIST, So we just skip this EFI_SIGNATURE_LIST. + // + if (CheckedCount < SIGNATURE_DATA_COUNTS (ListWalker) && DelType == Delete_Signature_Data) { NewCertList = (EFI_SIGNATURE_LIST *)(NewVariableData + Offset); // // Copy header. // - CopyMem ((UINT8 *)NewVariableData + Offset, ListWalker, sizeof (EFI_SIGNATURE_LIST) + ListWalker->SignatureHeaderSize); + CopyMem ((UINT8 *)NewVariableData + Offset, ListWalker, sizeof (EFI_SIGNATURE_LIST) + ListWalker->SignatureHeaderSize); Offset += sizeof (EFI_SIGNATURE_LIST) + ListWalker->SignatureHeaderSize; DataWalker = (EFI_SIGNATURE_DATA *)((UINT8 *)ListWalker + sizeof(EFI_SIGNATURE_LIST) + ListWalker->SignatureHeaderSize); @@ -3188,9 +3188,9 @@ DeleteSignatureEx ( } } - RemainingSize -= ListWalker->SignatureListSize; - ListWalker = (EFI_SIGNATURE_LIST *)((UINT8 *)ListWalker + ListWalker->SignatureListSize); - + RemainingSize -= ListWalker->SignatureListSize; + ListWalker = (EFI_SIGNATURE_LIST *)((UINT8 *)ListWalker + ListWalker->SignatureListSize); + // // Copy remaining data, maybe 0. // -- 2.11.0.windows.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Patch 4/4] SecurityPkg: Convert source file to DOS format 2017-12-27 15:23 ` [Patch 4/4] SecurityPkg: " Liming Gao @ 2017-12-28 1:56 ` Zhang, Chao B 0 siblings, 0 replies; 8+ messages in thread From: Zhang, Chao B @ 2017-12-28 1:56 UTC (permalink / raw) To: Gao, Liming, edk2-devel@lists.01.org; +Cc: Long, Qin Reviewed-by : Chao Zhang <chao.b.zhang@intel.com> -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, December 27, 2017 11:23 PM To: edk2-devel@lists.01.org Cc: Long, Qin <qin.long@intel.com> Subject: [edk2] [Patch 4/4] SecurityPkg: Convert source file to DOS format Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao <liming.gao@intel.com> Cc: Qin Long <qin.long@intel.com> --- .../SecureBootConfigDxe/SecureBootConfigImpl.c | 26 +++++++++++----------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c index 4ec0f8d13a..e3066f77be 100644 --- a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c +++ b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootCo +++ nfigImpl.c @@ -3145,9 +3145,9 @@ DeleteSignatureEx ( if (DelType == Delete_Signature_List_All) { VariableDataSize = 0; } else { - // - // Traverse to target EFI_SIGNATURE_LIST but others will be skipped. - // + // + // Traverse to target EFI_SIGNATURE_LIST but others will be skipped. + // while ((RemainingSize > 0) && (RemainingSize >= ListWalker->SignatureListSize) && ListIndex < PrivateData->ListIndex) { CopyMem ((UINT8 *)NewVariableData + Offset, ListWalker, ListWalker->SignatureListSize); Offset += ListWalker->SignatureListSize; @@ -3157,17 +3157,17 @@ DeleteSignatureEx ( ListIndex++; } - // - // Handle the target EFI_SIGNATURE_LIST. - // If CheckedCount == SIGNATURE_DATA_COUNTS (ListWalker) or DelType == Delete_Signature_List_One - // it means delete the whole EFI_SIGNATURE_LIST, So we just skip this EFI_SIGNATURE_LIST. - // - if (CheckedCount < SIGNATURE_DATA_COUNTS (ListWalker) && DelType == Delete_Signature_Data) { + // + // Handle the target EFI_SIGNATURE_LIST. + // If CheckedCount == SIGNATURE_DATA_COUNTS (ListWalker) or DelType == Delete_Signature_List_One + // it means delete the whole EFI_SIGNATURE_LIST, So we just skip this EFI_SIGNATURE_LIST. + // + if (CheckedCount < SIGNATURE_DATA_COUNTS (ListWalker) && DelType == + Delete_Signature_Data) { NewCertList = (EFI_SIGNATURE_LIST *)(NewVariableData + Offset); // // Copy header. // - CopyMem ((UINT8 *)NewVariableData + Offset, ListWalker, sizeof (EFI_SIGNATURE_LIST) + ListWalker->SignatureHeaderSize); + CopyMem ((UINT8 *)NewVariableData + Offset, ListWalker, sizeof + (EFI_SIGNATURE_LIST) + ListWalker->SignatureHeaderSize); Offset += sizeof (EFI_SIGNATURE_LIST) + ListWalker->SignatureHeaderSize; DataWalker = (EFI_SIGNATURE_DATA *)((UINT8 *)ListWalker + sizeof(EFI_SIGNATURE_LIST) + ListWalker->SignatureHeaderSize); @@ -3188,9 +3188,9 @@ DeleteSignatureEx ( } } - RemainingSize -= ListWalker->SignatureListSize; - ListWalker = (EFI_SIGNATURE_LIST *)((UINT8 *)ListWalker + ListWalker->SignatureListSize); - + RemainingSize -= ListWalker->SignatureListSize; + ListWalker = (EFI_SIGNATURE_LIST *)((UINT8 *)ListWalker + + ListWalker->SignatureListSize); + // // Copy remaining data, maybe 0. // -- 2.11.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-12-28 3:21 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-12-27 15:23 [Patch 0/4] Update source file as DOS format Liming Gao 2017-12-27 15:23 ` [Patch 1/4] IntelFspWrapperPkg: Convert INF file to dos format Liming Gao [not found] ` <4A89E2EF3DFEDB4C8BFDE51014F606A14E199C4B@SHSMSX104.ccr.corp.intel.com> 2017-12-28 3:26 ` Yao, Jiewen 2017-12-27 15:23 ` [Patch 2/4] NetworkPkg: Convert source file to DOS format Liming Gao 2017-12-28 0:38 ` Wu, Jiaxin 2017-12-27 15:23 ` [Patch 3/4] SourceLevelDebugPkg: " Liming Gao 2017-12-27 15:23 ` [Patch 4/4] SecurityPkg: " Liming Gao 2017-12-28 1:56 ` Zhang, Chao B
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox