From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::244; helo=mail-wr0-x244.google.com; envelope-from=sigmaepsilon92@gmail.com; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 82D2B22280C5B for ; Wed, 27 Dec 2017 11:24:01 -0800 (PST) Received: by mail-wr0-x244.google.com with SMTP id g17so28292562wrd.13 for ; Wed, 27 Dec 2017 11:28:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5tH4KA99CBO0dO7Japobqmt1EXQ9hao38QYk7JDt/mY=; b=UpSWagxvGLo/WSUI1iAmV8W9fJ/tWjf6U9E4Sj8kbc4FNdAz18a6sNG0xLW7KprfDg GcrE0KhzLH9qCJnuXXt9sIPGMLIyzYag+/Tp6SWyd3x+3OBgRQiz5S3+wFgZ2lvrg2O1 MV+LZ4WECrr00tfRgeohceYYm/wV+lx93HpXbMEfM+kUZmGMft0P+jbAGi7WAdXiDIyU yXqSdCVVWXyAh8LKNdRgttOzA/jrbbgNYNr5W1rCNZQkzTVmF2blUcoN7brK/NfLrt3R TfJ7eK5DV0vCyO2BJHR8LINxCl0LnRw+KnkpVu7M6XZNr1lzXBVKcBE8qoa/rvCNQmFm 0GNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5tH4KA99CBO0dO7Japobqmt1EXQ9hao38QYk7JDt/mY=; b=rCfQeolGVUpq987Ed6USU5XXUI0GrL/ZZ/FSWU6g4/iCC08LOA4XR9CuOLEbDhEuAe kA/y5ZtPVq6nntNlQADWWpgIjvGgNx5DT/qL4Jtgboas8fRdKOyDdaMtrGYy7okhjedb JsFdw+Q0/4Eh17bC6sY1NNGsEt3mwK2qWUdEFk3zeU+UoVZzoPnZtKbmIuUfH2lJBwlr r5zG/5ctC6xDz3KFIG/ypFAcC2wXsrGomhVQ15pHI4yrT2Htx5rqgCl7OmpjKtakrKTX 0+PrEzHczckebGaGck8gFdZDb2YQpEl7ppDallfWBX3IwjVH3Rfw+fWFfMAg2dHuKy/y GAbQ== X-Gm-Message-State: AKGB3mIjjq3RHl0WxOepPbkOE4BI1nnJn8FPlpQ4BUJAkG/ILTtvx+Nh Pho13sA4Dmgo21N+HU4+BIghpWKW X-Google-Smtp-Source: ACJfBouMIlffXbpiFN+oO08notVL+nsLHKIbgV6P44iNqVoom5a2wnziC9Bnz6jLuwznGQ49wNvtcg== X-Received: by 10.223.182.81 with SMTP id i17mr29977451wre.224.1514402935652; Wed, 27 Dec 2017 11:28:55 -0800 (PST) Received: from m1cha-NB.fritz.box (p57B5F2FC.dip0.t-ipconnect.de. [87.181.242.252]) by smtp.gmail.com with ESMTPSA id b48sm79475226wrb.1.2017.12.27.11.28.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Dec 2017 11:28:55 -0800 (PST) From: M1cha To: edk2-devel@lists.01.org Cc: Ard Biesheuvel , Michael D Kinney , Liming Gao Date: Wed, 27 Dec 2017 20:28:50 +0100 Message-Id: <20171227192850.26774-2-sigmaepsilon92@gmail.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20171227192850.26774-1-sigmaepsilon92@gmail.com> References: <20171227192850.26774-1-sigmaepsilon92@gmail.com> Subject: [PATCH v3 3/3] MdePkg: add NORETURN attribute to LongJump and InternalLongJump X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Dec 2017 19:24:02 -0000 This fixes compiler warnings when using them in functions which should return a value but rely on LongJump to never return instead. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Zimmermann --- V3: fix VS compilation errors MdePkg/Include/Library/BaseLib.h | 1 + MdePkg/Library/BaseLib/BaseLibInternals.h | 1 + MdePkg/Library/BaseLib/Ebc/SetJumpLongJump.c | 1 + MdePkg/Library/BaseLib/Ia32/LongJump.c | 1 + MdePkg/Library/BaseLib/LongJump.c | 1 + 5 files changed, 5 insertions(+) diff --git a/MdePkg/Include/Library/BaseLib.h b/MdePkg/Include/Library/BaseLib.h index 10976032adaa..c6783f4624e2 100644 --- a/MdePkg/Include/Library/BaseLib.h +++ b/MdePkg/Include/Library/BaseLib.h @@ -4927,6 +4927,7 @@ SetJump ( restored and must be non-zero. **/ +NORETURN VOID EFIAPI LongJump ( diff --git a/MdePkg/Library/BaseLib/BaseLibInternals.h b/MdePkg/Library/BaseLib/BaseLibInternals.h index 9dca97a0dcc9..5cc83d2956e5 100644 --- a/MdePkg/Library/BaseLib/BaseLibInternals.h +++ b/MdePkg/Library/BaseLib/BaseLibInternals.h @@ -441,6 +441,7 @@ InternalAssertJumpBuffer ( @param Value The value to return when the SetJump() context is restored. **/ +NORETURN VOID EFIAPI InternalLongJump ( diff --git a/MdePkg/Library/BaseLib/Ebc/SetJumpLongJump.c b/MdePkg/Library/BaseLib/Ebc/SetJumpLongJump.c index e309e8b57d7a..f48d7d17c4e4 100644 --- a/MdePkg/Library/BaseLib/Ebc/SetJumpLongJump.c +++ b/MdePkg/Library/BaseLib/Ebc/SetJumpLongJump.c @@ -54,6 +54,7 @@ SetJump ( @param Value The value to return when the SetJump() context is restored. **/ +NORETURN VOID EFIAPI InternalLongJump ( diff --git a/MdePkg/Library/BaseLib/Ia32/LongJump.c b/MdePkg/Library/BaseLib/Ia32/LongJump.c index 73973a9cceae..8fc86f9efb69 100644 --- a/MdePkg/Library/BaseLib/Ia32/LongJump.c +++ b/MdePkg/Library/BaseLib/Ia32/LongJump.c @@ -28,6 +28,7 @@ **/ __declspec (naked) +NORETURN VOID EFIAPI InternalLongJump ( diff --git a/MdePkg/Library/BaseLib/LongJump.c b/MdePkg/Library/BaseLib/LongJump.c index 062be8f2daa1..fef764d6787e 100644 --- a/MdePkg/Library/BaseLib/LongJump.c +++ b/MdePkg/Library/BaseLib/LongJump.c @@ -33,6 +33,7 @@ restored and must be non-zero. **/ +NORETURN VOID EFIAPI LongJump ( -- 2.15.1