From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mx.groups.io with SMTP id smtpd.web11.15331.1636721992531315768 for ; Fri, 12 Nov 2021 04:59:52 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=c8Yj6RUl; spf=pass (domain: linux.ibm.com, ip: 148.163.156.1, mailfrom: jejb@linux.ibm.com) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1ACBlPnf006956; Fri, 12 Nov 2021 12:59:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : reply-to : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=O4SZokxGbqQ9rX18DCsHbzyMhpls6BVRSADd4koHssM=; b=c8Yj6RUlwASE75gRH8gh60fk0Mi8kD6D+W/ObwGI/jpEyoA507MibGA0kYVKafkMmfgb AnOwbDq60y8M4ytPsUCJ45yVp5nrmVWeKrzpZdEKDl1mN5qx4hn1nIey1cXricfXdguc 2Lq9KfHAayAL1l3/mqOz9v+Fc+ssJ3BPa8+Y4jXuhfmuJmY8G6FFZS4jOxVUA8ixeGst 7lM7OhV67sqAnD9dHdPrlKiD0YAFgCHAJ/R4E6lKt0nG1ow5hhMrHEvRWaFYEBIlgbAT XJKlZcS/VcI1g5s/BzStJjvVw8IEqD8rD5VLW7lzUMi0mOdks4isLMugfylO4CjK1CEK iw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3c9qq21fmd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Nov 2021 12:59:29 +0000 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 1ACC6Ixj015236; Fri, 12 Nov 2021 12:59:28 GMT Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 3c9qq21fkq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Nov 2021 12:59:28 +0000 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1ACCwESU022322; Fri, 12 Nov 2021 12:59:27 GMT Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by ppma04dal.us.ibm.com with ESMTP id 3c5hbe1mdp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Nov 2021 12:59:27 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1ACCxQfs18285270 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Nov 2021 12:59:26 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 979167805F; Fri, 12 Nov 2021 12:59:26 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5E7A978063; Fri, 12 Nov 2021 12:59:24 +0000 (GMT) Received: from jarvis.int.hansenpartnership.com (unknown [9.211.121.135]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 12 Nov 2021 12:59:24 +0000 (GMT) Message-ID: <2017be5719de43921aacf26267fe9621f3ebc53e.camel@linux.ibm.com> Subject: Re: [PATCH v12 22/32] UefiCpuPkg/MpInitLib: use PcdConfidentialComputingAttr to check SEV status From: "James Bottomley" Reply-To: jejb@linux.ibm.com To: "Ni, Ray" , Brijesh Singh , "devel@edk2.groups.io" Cc: "Xu, Min M" , "Yao, Jiewen" , Tom Lendacky , "Justen, Jordan L" , Ard Biesheuvel , Erdem Aktas , Michael Roth , Gerd Hoffmann , "Kinney, Michael D" , Liming Gao , "Liu, Zhiguang" , "Kumar, Rahul1" , "Dong, Eric" Date: Fri, 12 Nov 2021 07:59:23 -0500 In-Reply-To: References: <20211110221457.2397234-1-brijesh.singh@amd.com> <20211110221457.2397234-23-brijesh.singh@amd.com> User-Agent: Evolution 3.34.4 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: o-zh_OtH9pchhVflZ9Bo61VoCQb3VDs5 X-Proofpoint-ORIG-GUID: R4aFl9eZ9mWxFw5xcfHwCnGZL0vJkDg2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-12_04,2021-11-12_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 adultscore=0 mlxlogscore=999 phishscore=0 impostorscore=0 mlxscore=0 clxscore=1011 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111120071 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Fri, 2021-11-12 at 01:27 +0000, Ni, Ray wrote: [...] > > + > > + return (CurrentAttr == Attr); > > 2. I guess a "BOOLEAN" type cast is needed. It shouldn't. Unless there's a major screw up in the way BOOLEAN works in the UEFI API, all logic operations should already be of type BOOLEAN and if they're not that would be what needs fixing. James