From: Gary Lin <glin@suse.com>
To: Fu Siyuan <siyuan.fu@intel.com>
Cc: edk2-devel@lists.01.org, Ye Ting <ting.ye@intel.com>,
Wang Fan <fan.wang@intel.com>, Wu Jiaxin <jiaxin.wu@intel.com>
Subject: Re: [Patch 2/5] NetworkPkg: Check allocated buffer pointer before use.
Date: Tue, 2 Jan 2018 14:26:57 +0800 [thread overview]
Message-ID: <20180102062657.2ksvvd6gnr3toolo@GaryWorkstation> (raw)
In-Reply-To: <20180102052744.9928-3-siyuan.fu@intel.com>
On Tue, Jan 02, 2018 at 01:27:41PM +0800, Fu Siyuan wrote:
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> Cc: Wang Fan <fan.wang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> ---
> NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c
> index f2239fd8c0..327b4cf1cf 100644
> --- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c
> +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c
> @@ -2,7 +2,7 @@
> Functions implementation related with DHCPv6 for UefiPxeBc Driver.
>
> (C) Copyright 2014 Hewlett-Packard Development Company, L.P.<BR>
> - Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD License
> @@ -2030,6 +2030,9 @@ PxeBcDhcp6CallBack (
> SelectAd = &Private->OfferBuffer[Private->SelectIndex - 1].Dhcp6.Packet.Offer;
> *NewPacket = AllocateZeroPool (SelectAd->Size);
> ASSERT (*NewPacket != NULL);
I guess this ASSERT can be removed since *NewPacket is checked later.
Gary Lin
> + if (*NewPacket == NULL) {
> + return EFI_ABORTED;
> + }
> CopyMem (*NewPacket, SelectAd, SelectAd->Size);
> }
> break;
> --
> 2.13.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
next prev parent reply other threads:[~2018-01-02 6:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 5:27 [Patch 0/5] Refine PXE driver code logic Fu Siyuan
2018-01-02 5:27 ` [Patch 1/5] NetworkPkg: Abort the PXE process if DHCP has been started by other instance Fu Siyuan
2018-01-02 5:27 ` [Patch 2/5] NetworkPkg: Check allocated buffer pointer before use Fu Siyuan
2018-01-02 6:26 ` Gary Lin [this message]
2018-01-02 5:27 ` [Patch 3/5] NetworkPkg: Fix memory leak problem in PXE driver Fu Siyuan
2018-01-02 5:27 ` [Patch 4/5] NetworkPkg: Add assert for buffer pointer from DHCP driver Fu Siyuan
2018-01-02 5:27 ` [Patch 5/5] NetworkPkg: Update PXE driver to check for NULL pointer before use it Fu Siyuan
2018-01-02 5:43 ` Subramanian, Sriram
2018-01-02 5:45 ` [Patch 0/5] Refine PXE driver code logic Subramanian, Sriram
2018-01-02 5:50 ` Subramanian, Sriram
2018-01-04 1:02 ` Fu, Siyuan
2018-01-02 6:59 ` Wu, Jiaxin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180102062657.2ksvvd6gnr3toolo@GaryWorkstation \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox