From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 348D5222A54C6 for ; Tue, 2 Jan 2018 16:29:28 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2018 16:34:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,499,1508828400"; d="scan'208";a="17653424" Received: from lgao4-mobl1.ccr.corp.intel.com ([10.255.26.107]) by fmsmga004.fm.intel.com with ESMTP; 02 Jan 2018 16:34:30 -0800 From: Liming Gao To: edk2-devel@lists.01.org Date: Wed, 3 Jan 2018 08:34:28 +0800 Message-Id: <20180103003428.13040-1-liming.gao@intel.com> X-Mailer: git-send-email 2.11.0.windows.1 Subject: [Patch] BaseTools CommonLib: Fix printf %llx issue on UINT64 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jan 2018 00:29:29 -0000 UINT64 is defined as the different type for the different ARCHs. To let it work for all archs and compilers, add (unsigned long long) for the input value together with %llx. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- BaseTools/Source/C/Common/PcdValueCommon.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/BaseTools/Source/C/Common/PcdValueCommon.c b/BaseTools/Source/C/Common/PcdValueCommon.c index 6ca0994744..42f76ddbbc 100644 --- a/BaseTools/Source/C/Common/PcdValueCommon.c +++ b/BaseTools/Source/C/Common/PcdValueCommon.c @@ -266,11 +266,7 @@ Returns: sprintf(PcdList[Index].Value, "0x%08x", (UINT32)(Value & 0xffffffff)); break; case PcdDataTypeUint64: -#ifdef __GNUC__ - sprintf(PcdList[Index].Value, "0x%016lx", Value); -#else - sprintf(PcdList[Index].Value, "0x%016llx", Value); -#endif + sprintf(PcdList[Index].Value, "0x%016llx", (unsigned long long)Value); break; case PcdDataTypePointer: fprintf (stderr, "PCD %s.%s.%s.%s is structure. Use PcdSetPtr()\n", SkuName, DefaultValueName, TokenSpaceGuidName, TokenName); -- 2.11.0.windows.1