From: Leif Lindholm <leif.lindholm@linaro.org>
To: Heyi Guo <heyi.guo@linaro.org>
Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org,
graeme.gregory@linaro.org, ard.biesheuvel@linaro.org,
guoheyi@huawei.com, wanghuiqiang@huawei.com,
huangming23@huawei.com, zhangjinsong2@huawei.com,
mengfanrong@huawei.com, waip23@126.com
Subject: Re: [PATCH edk2-non-osi v1 0/3] Improve D0x platforms and bug fix
Date: Mon, 22 Jan 2018 13:09:27 +0000 [thread overview]
Message-ID: <20180122130926.ynt35i6hdawhy4ma@bivouac.eciton.net> (raw)
In-Reply-To: <1516287765-35576-1-git-send-email-heyi.guo@linaro.org>
On Thu, Jan 18, 2018 at 11:02:42PM +0800, Heyi Guo wrote:
> Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git
> branch: rp-1802-osi-v1
>
> *** BLURB HERE ***
I'm happy with the layout this set, but I would have preferred if
this cover-letter instead of "*** BLURB HERE ***" pointed out
explicitly the ordering requirements with regards to the
edk2-platforms set.
However, since we don't have any source code to help guide us in what
changes have been implemented, the individual commit messages for each
patch need to be more detailed - I will comment on those separately.
/
Leif
> Heyi Guo (2):
> Hisilicon D0x: Fix network interface order issue
> Hisilicon D0x: Move SnpPlatform to edk2-platforms.
>
> Jason Zhang (1):
> Hisilicon D03/D05: Move SasPlatform to edk2-platforms
>
> Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 26688 -> 26592 bytes
> Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3040 -> 0 bytes
> Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf | 24 --------------------
> Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi | Bin 3040 -> 0 bytes
> Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf | 24 --------------------
> Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 28544 -> 28448 bytes
> Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3392 -> 0 bytes
> Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf | 24 --------------------
> Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi | Bin 3424 -> 0 bytes
> Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf | 24 --------------------
> 10 files changed, 96 deletions(-)
> delete mode 100644 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi
> delete mode 100644 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf
> delete mode 100644 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi
> delete mode 100644 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf
> delete mode 100644 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi
> delete mode 100644 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf
> delete mode 100644 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi
> delete mode 100644 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf
>
> --
> 1.9.1
>
prev parent reply other threads:[~2018-01-22 13:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 15:02 [PATCH edk2-non-osi v1 0/3] Improve D0x platforms and bug fix Heyi Guo
2018-01-18 15:02 ` [PATCH edk2-non-osi v1 1/3] Hisilicon D03/D05: Move SasPlatform to edk2-platforms Heyi Guo
2018-01-20 11:12 ` Ard Biesheuvel
2018-01-22 13:11 ` Leif Lindholm
2018-01-18 15:02 ` [PATCH edk2-non-osi v1 2/3] Hisilicon D0x: Fix network interface order issue Heyi Guo
2018-01-20 11:12 ` Ard Biesheuvel
2018-01-22 13:12 ` Leif Lindholm
2018-01-18 15:02 ` [PATCH edk2-non-osi v1 3/3] Hisilicon D0x: Move SnpPlatform to edk2-platforms Heyi Guo
2018-01-20 11:12 ` Ard Biesheuvel
2018-01-22 13:14 ` Leif Lindholm
2018-01-22 13:09 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122130926.ynt35i6hdawhy4ma@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox