From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::244; helo=mail-wr0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EABBF2232BE0E for ; Mon, 22 Jan 2018 05:04:07 -0800 (PST) Received: by mail-wr0-x244.google.com with SMTP id v15so5754311wrb.8 for ; Mon, 22 Jan 2018 05:09:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4wyCZ2j3yge+C4O5IBMq1l51Bh9tpC45ZpndJ6A4njs=; b=O7EmqlAiiZ6SGtlDQNfEhrRfihlAeRXJjU3Qj4/RhQB7zd7JWs2NXxmec6GO0qfeGC 4X6Yyuplc9M9+S2P5yD9L8+akpKEV0Q0PtZlUCO6K/wPCI3tuCJJNvJY9YEvWjGv2zoT Qa+xSI3t+0ID0HSzVR6PAC9Kyjkv2BeHUkTBs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4wyCZ2j3yge+C4O5IBMq1l51Bh9tpC45ZpndJ6A4njs=; b=Ht4fLsYmNO85i72BaIKg1FKg98uBIfW6yziCYhbwWQA+dbUpjQKTwXTbpg3oaxetj8 +JSE5ZqBoJjUnVkMQJi5z96JmI7JijGtRPvcxuxeYDaZ8wA4y4vvzn/YBsk3+hm+GknN mlanq6Do7VOuIpyiyKOQi8PVY/eJqXvDQUD57jyY9LJt4LW0XFrturPZWBNIV2yL3YQw exOee8MArTqMFuXR/GAxI5iuoND93UiLscL8nVFVYsWaC4IABe1akMX03LeAvUhf9GkM FbCMorCc83GP4TcgFuCbBQ/ao4rqSmphYnRpFHu0Ss9+75odX74wy3o/DkNu/ykWOe9Y 3sxg== X-Gm-Message-State: AKwxyteNlMoZdVrlbzH7KOBWDA+4WAQDdWvd4dvr+f6N7+6EqX45avMu 0i5u3ZqJjDIUxIdUa++1WXuCpg== X-Google-Smtp-Source: AH8x224Y1rDVP5lIN8G+MUj/BsIi59vmddeUHFl3wIILeIh/8qN+PuAPw3bJ++OqeqrLvPPWNK3u+w== X-Received: by 10.223.136.150 with SMTP id f22mr6306404wrf.246.1516626571672; Mon, 22 Jan 2018 05:09:31 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id m6sm7078521wmd.37.2018.01.22.05.09.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Jan 2018 05:09:29 -0800 (PST) Date: Mon, 22 Jan 2018 13:09:27 +0000 From: Leif Lindholm To: Heyi Guo Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, mengfanrong@huawei.com, waip23@126.com Message-ID: <20180122130926.ynt35i6hdawhy4ma@bivouac.eciton.net> References: <1516287765-35576-1-git-send-email-heyi.guo@linaro.org> MIME-Version: 1.0 In-Reply-To: <1516287765-35576-1-git-send-email-heyi.guo@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-non-osi v1 0/3] Improve D0x platforms and bug fix X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 13:04:08 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 18, 2018 at 11:02:42PM +0800, Heyi Guo wrote: > Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git > branch: rp-1802-osi-v1 > > *** BLURB HERE *** I'm happy with the layout this set, but I would have preferred if this cover-letter instead of "*** BLURB HERE ***" pointed out explicitly the ordering requirements with regards to the edk2-platforms set. However, since we don't have any source code to help guide us in what changes have been implemented, the individual commit messages for each patch need to be more detailed - I will comment on those separately. / Leif > Heyi Guo (2): > Hisilicon D0x: Fix network interface order issue > Hisilicon D0x: Move SnpPlatform to edk2-platforms. > > Jason Zhang (1): > Hisilicon D03/D05: Move SasPlatform to edk2-platforms > > Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 26688 -> 26592 bytes > Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3040 -> 0 bytes > Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf | 24 -------------------- > Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi | Bin 3040 -> 0 bytes > Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf | 24 -------------------- > Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 28544 -> 28448 bytes > Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3392 -> 0 bytes > Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf | 24 -------------------- > Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi | Bin 3424 -> 0 bytes > Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf | 24 -------------------- > 10 files changed, 96 deletions(-) > delete mode 100644 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi > delete mode 100644 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf > delete mode 100644 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi > delete mode 100644 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf > delete mode 100644 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi > delete mode 100644 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf > delete mode 100644 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi > delete mode 100644 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf > > -- > 1.9.1 >