Re: [PATCH edk2-non-osi v1 3/3] Hisilicon D0x: Move SnpPlatform to edk2-platforms.

[Leif Lindholm <leif.lindholm@linaro.org>]

Same comments as for 1/3:
"Move" statements belong in 0/3 - this one simply deletes.

This patch is also missing signed-off-bys and contributed-unders.

/
    Leif

On Thu, Jan 18, 2018 at 11:02:45PM +0800, Heyi Guo wrote:
> ---
>  Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3040 -> 0 bytes
>  Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf |  24 --------------------
>  Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3392 -> 0 bytes
>  Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf |  24 --------------------
>  4 files changed, 48 deletions(-)
> 
> diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi b/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi
> deleted file mode 100644
> index 5e7d8bd..0000000
> Binary files a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi and /dev/null differ
> diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf b/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf
> deleted file mode 100644
> index 10b2003..0000000
> --- a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -#/** @file
> -#
> -#    Copyright (c) 2017, Hisilicon Limited. All rights reserved.
> -#    Copyright (c) 2017, Linaro Limited. All rights reserved.
> -#
> -#    This program and the accompanying materials
> -#    are licensed and made available under the terms and conditions of the BSD License
> -#    which accompanies this distribution. The full text of the license may be found at
> -#    http://opensource.org/licenses/bsd-license.php
> -#
> -#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> -#
> -#**/
> -
> -[Defines]
> -  INF_VERSION                    = 0x00010019
> -  BASE_NAME                      = SnpPlatform
> -  FILE_GUID                      = 102D8FC9-20A4-42EB-AC14-1C98BA5B17A8
> -  MODULE_TYPE                    = DXE_DRIVER
> -  VERSION_STRING                 = 1.0
> -
> -[Binaries.AARCH64]
> -  PE32|SnpPlatform.efi|*
> diff --git a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi b/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi
> deleted file mode 100644
> index 42c26de..0000000
> Binary files a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi and /dev/null differ
> diff --git a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf b/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf
> deleted file mode 100644
> index 10b2003..0000000
> --- a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -#/** @file
> -#
> -#    Copyright (c) 2017, Hisilicon Limited. All rights reserved.
> -#    Copyright (c) 2017, Linaro Limited. All rights reserved.
> -#
> -#    This program and the accompanying materials
> -#    are licensed and made available under the terms and conditions of the BSD License
> -#    which accompanies this distribution. The full text of the license may be found at
> -#    http://opensource.org/licenses/bsd-license.php
> -#
> -#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> -#
> -#**/
> -
> -[Defines]
> -  INF_VERSION                    = 0x00010019
> -  BASE_NAME                      = SnpPlatform
> -  FILE_GUID                      = 102D8FC9-20A4-42EB-AC14-1C98BA5B17A8
> -  MODULE_TYPE                    = DXE_DRIVER
> -  VERSION_STRING                 = 1.0
> -
> -[Binaries.AARCH64]
> -  PE32|SnpPlatform.efi|*
> -- 
> 1.9.1
>