From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::241; helo=mail-wm0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5CE962232BE0E for ; Mon, 22 Jan 2018 05:08:53 -0800 (PST) Received: by mail-wm0-x241.google.com with SMTP id x4so17465064wmc.0 for ; Mon, 22 Jan 2018 05:14:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/uWL2j4GNtqnYm0MU/JWtPRf7Yx0TXRdGvWtc4Dk+yg=; b=AzVF0cTHGi4GVFvR0MNXfWLoZOrFSH+ttsnXSn8aufBKmZlnKtLh4JDpNN/sOIz9PO xrYAKRO9pU5PbQH8ugC2Yrl9JqswZv/Kzp8SQBe3r34/g/hWgOE6GQZ6ou6iJ5fDXcDt I3Kp4wsuctalY1e18zqB+ZWc9/MWc58tFXE/g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/uWL2j4GNtqnYm0MU/JWtPRf7Yx0TXRdGvWtc4Dk+yg=; b=iZvMFFh/0q0Ta57O8zO1vTumm9BeMZa4WaAEOXw1DwfiFHU/iaEMrwcIyUM3vqNynz 3SHKNeyxuQsMGzqcCl5oR1YxrBTGl2DBICCGvw+wOKQsX29GbSIc9X6EpnNZ0YTW9KZF +vCC21JkNRb5FNgCIo52Tq/E5QX4AwvvsOXYhx7tEYanitjQkj7MulhbbKXC4uw/Zrq5 kV8rbUrxtNcuFgs+M4exbj+uLdb5eq8dDx2eIrQszMz0J08ANUtMgE3gEza6MeNACgys 2zWO3HG3WPnS2bhY4Z996xVaG2JpzqCAqZGKgcTgOLkcpriiJYX6EVejT56DTv5r9pLX JWRg== X-Gm-Message-State: AKwxytdxAhZxHrLg/M/QCOuPmNvoiaYv7B5jN1xdgW+JF3L6L8/yFrrE ywGcpm0SSMLBjqulCN3lW/Bi6A== X-Google-Smtp-Source: AH8x2260LhZUUct0SoGYlFUX5/JRb5q5JK6jaBHKtoIwwnR4INhy6xH9HvoLsFKGDkL6uqpu48eOXw== X-Received: by 10.28.94.12 with SMTP id s12mr1160347wmb.155.1516626857849; Mon, 22 Jan 2018 05:14:17 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id u27sm12669923wrf.77.2018.01.22.05.14.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Jan 2018 05:14:16 -0800 (PST) Date: Mon, 22 Jan 2018 13:14:15 +0000 From: Leif Lindholm To: Heyi Guo Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, mengfanrong@huawei.com, waip23@126.com Message-ID: <20180122131415.ayo4xutzyv36iowo@bivouac.eciton.net> References: <1516287765-35576-1-git-send-email-heyi.guo@linaro.org> <1516287765-35576-4-git-send-email-heyi.guo@linaro.org> MIME-Version: 1.0 In-Reply-To: <1516287765-35576-4-git-send-email-heyi.guo@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-non-osi v1 3/3] Hisilicon D0x: Move SnpPlatform to edk2-platforms. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 13:08:53 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Same comments as for 1/3: "Move" statements belong in 0/3 - this one simply deletes. This patch is also missing signed-off-bys and contributed-unders. / Leif On Thu, Jan 18, 2018 at 11:02:45PM +0800, Heyi Guo wrote: > --- > Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3040 -> 0 bytes > Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf | 24 -------------------- > Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3392 -> 0 bytes > Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf | 24 -------------------- > 4 files changed, 48 deletions(-) > > diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi b/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi > deleted file mode 100644 > index 5e7d8bd..0000000 > Binary files a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi and /dev/null differ > diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf b/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf > deleted file mode 100644 > index 10b2003..0000000 > --- a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf > +++ /dev/null > @@ -1,24 +0,0 @@ > -#/** @file > -# > -# Copyright (c) 2017, Hisilicon Limited. All rights reserved. > -# Copyright (c) 2017, Linaro Limited. All rights reserved. > -# > -# This program and the accompanying materials > -# are licensed and made available under the terms and conditions of the BSD License > -# which accompanies this distribution. The full text of the license may be found at > -# http://opensource.org/licenses/bsd-license.php > -# > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > -# > -#**/ > - > -[Defines] > - INF_VERSION = 0x00010019 > - BASE_NAME = SnpPlatform > - FILE_GUID = 102D8FC9-20A4-42EB-AC14-1C98BA5B17A8 > - MODULE_TYPE = DXE_DRIVER > - VERSION_STRING = 1.0 > - > -[Binaries.AARCH64] > - PE32|SnpPlatform.efi|* > diff --git a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi b/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi > deleted file mode 100644 > index 42c26de..0000000 > Binary files a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi and /dev/null differ > diff --git a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf b/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf > deleted file mode 100644 > index 10b2003..0000000 > --- a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf > +++ /dev/null > @@ -1,24 +0,0 @@ > -#/** @file > -# > -# Copyright (c) 2017, Hisilicon Limited. All rights reserved. > -# Copyright (c) 2017, Linaro Limited. All rights reserved. > -# > -# This program and the accompanying materials > -# are licensed and made available under the terms and conditions of the BSD License > -# which accompanies this distribution. The full text of the license may be found at > -# http://opensource.org/licenses/bsd-license.php > -# > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > -# > -#**/ > - > -[Defines] > - INF_VERSION = 0x00010019 > - BASE_NAME = SnpPlatform > - FILE_GUID = 102D8FC9-20A4-42EB-AC14-1C98BA5B17A8 > - MODULE_TYPE = DXE_DRIVER > - VERSION_STRING = 1.0 > - > -[Binaries.AARCH64] > - PE32|SnpPlatform.efi|* > -- > 1.9.1 >