From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B84E32234434C for ; Mon, 22 Jan 2018 06:09:53 -0800 (PST) Received: by mail-wm0-x244.google.com with SMTP id b21so17130639wme.4 for ; Mon, 22 Jan 2018 06:15:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4JwMGuxVUPUO2KMxWUE66PWUB2JZOxjxZcJ4GE+HIHI=; b=W+t3bz4SR+wnA5uGuMJpMj75vWWtKRNSkzdYQ491/5Ex3xTtNth6m3YrPP8MiSDJgQ lIz1/QLbwwQkZk7KHKLa0yQOGmt4wBYOZxSnfWuk6pSAAbYKLtXO0ikpBZFyWFd2rUBt RVfxosWwd0ZamIL+b1jI8y+93VzN7eMupFT6o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4JwMGuxVUPUO2KMxWUE66PWUB2JZOxjxZcJ4GE+HIHI=; b=ZQgYOZP8IXx/gUTRfDf+djtGS7O1hfzTNvH5oNcM5JuH15pRvCEWigGHq3RTPWj/SM oPwK5TTWnFCH0gV8Ozpz/kXTnEB7qVaSQRxY+wbQnod3M3oAFwEOeOP6Q5CZmUubHR/H tTwfsGkqvGyyPUIdNsn8Vb1Tbz6rJe77UQhLzaec2BRZPhcZtighsirqXU5nbgi7RqZL WzvRXcmT3MFKvsVPcGCPPIuSh7YE+0h4ZTK4Z43X5cwHFZ3L/e9YEYuQlIwjIw04yzCj Sg47exu8fNzd95jDYLxu6ss7hln5rmL7jTrzCWv1jT1L5eGkE2MJ43J+GBLUjU0Ug0Uf Wong== X-Gm-Message-State: AKwxytfGKu7LQyTA66xEDj+qoPeWn7tDbKHDbdl2W7MOFS1EDmkGWKh9 ij6z5Fv3C6ZKPnMNr5DH50z8bQ== X-Google-Smtp-Source: AH8x224hPgkWyUA+5IAQdR0pPOEnJNYCVDBS+5H1sBQdx6+QWOYn0KoSO05w0mGPUUdyJFMV1kl8Zg== X-Received: by 10.28.232.81 with SMTP id f78mr5872300wmh.31.1516630518279; Mon, 22 Jan 2018 06:15:18 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id k7sm12106283wrg.38.2018.01.22.06.15.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Jan 2018 06:15:16 -0800 (PST) Date: Mon, 22 Jan 2018 14:15:13 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, mengfanrong@huawei.com, waip23@126.com Message-ID: <20180122141513.kzusrd4ct4sxtj3g@bivouac.eciton.net> References: <1516287703-35516-1-git-send-email-huangming23@huawei.com> <1516287703-35516-2-git-send-email-huangming23@huawei.com> <20180122135318.3ew44wno3sp7ruog@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: <20180122135318.3ew44wno3sp7ruog@bivouac.eciton.net> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 01/14] Hisilicon/D05: Add PPTT support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 14:09:54 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 22, 2018 at 01:53:18PM +0000, Leif Lindholm wrote: > > diff --git a/Silicon/Hisilicon/Hi1616/Pptt/Pptt.inf b/Silicon/Hisilicon/Hi1616/Pptt/Pptt.inf > > new file mode 100644 > > index 0000000..ce26b97 > > --- /dev/null > > +++ b/Silicon/Hisilicon/Hi1616/Pptt/Pptt.inf > > @@ -0,0 +1,55 @@ > > +/** @file > > +* > > +* Copyright (c) 2017, Hisilicon Limited. All rights reserved. > > +* Copyright (c) 2017, Linaro Limited. All rights reserved. > > 2018? > > > +* > > +* This program and the accompanying materials > > +* are licensed and made available under the terms and conditions of the BSD License > > +* which accompanies this distribution. The full text of the license may be found at > > +* http://opensource.org/licenses/bsd-license.php > > +* > > +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > > +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > > +* > > +* Based on the files under ArmPlatformPkg/ArmJunoPkg/AcpiTables/ > > Platform/ARM/JunoPkg/AcpiTables. > > > +* > > +**/ > > + > > +[Defines] > > + INF_VERSION = 0x00010005 > > A new .inf should probably claim 0x00010020. WARNING: extended periods of non-work may adversely affect your hexadecimal arithmetic skills. Clearly this should say 0x0001001a for 1.26. (Thanks, Ard.) / Leif > > + BASE_NAME = AcpiPptt > > + FILE_GUID = AAB14F90-DC2E-4f33-A594-C7894A5B412D > > + MODULE_TYPE = DXE_DRIVER > > + VERSION_STRING = 1.0 > > + ENTRY_POINT = PpttEntryPoint > > + > > +[Sources.common] > > + Pptt.c > > + Pptt.h > > + > > +[Packages] > > + MdePkg/MdePkg.dec > > + edk2-platforms/Silicon/Hisilicon/HisiPkg.dec > > This is incorrect - path resolution should be using PACKAGES_PATH and > refer only to Silicon/Hisilicon/HisiPkg.dec. > > > + ArmPkg/ArmPkg.dec > > Please sort these alphabetically. > > > + > > +[LibraryClasses] > > + ArmLib > > + HobLib > > + UefiRuntimeServicesTableLib > > + UefiDriverEntryPoint > > + BaseMemoryLib > > + DebugLib > > Please sort these alphabetically. > > > + > > +[Guids] > > + > > + > > +[Protocols] > > + gEfiAcpiTableProtocolGuid # PROTOCOL ALWAYS_CONSUMED > > + gEfiAcpiSdtProtocolGuid > > Please sort these alphabetically (where there is not a more logical > grouping available). > > / > Leif > > > + > > +[Pcd] > > + > > + > > +[Depex] > > + gEfiAcpiTableProtocolGuid AND gEfiAcpiSdtProtocolGuid > > + > > -- > > 1.9.1 > >